You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/02/20 23:04:37 UTC
[GitHub] [incubator-pekko-http] mdedetrich opened a new pull request, #73: Add copyright headers
mdedetrich opened a new pull request, #73:
URL: https://github.com/apache/incubator-pekko-http/pull/73
`CopyrightHeader` has also been updated to make sure the header check is consistently applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #73: Add copyright headers
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #73:
URL: https://github.com/apache/incubator-pekko-http/pull/73#discussion_r1112783131
##########
project/CopyrightHeader.scala:
##########
@@ -1,11 +1,21 @@
/*
- * Copyright (C) 2018-2020 Lightbend Inc. <https://www.lightbend.com>
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * license agreements; and to You under the Apache License, version 2.0:
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * This file is part of the Apache Pekko project, derived from Akka.
+ */
+
+/*
+ * Copyright (C) 2018-2022 Lightbend Inc. <https://www.lightbend.com>
Review Comment:
No it wasn't, evidently did a mistake on this specific file. Thanks for picking it up, fixing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich merged pull request #73: Add copyright headers
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #73:
URL: https://github.com/apache/incubator-pekko-http/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #73: Add copyright headers
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #73:
URL: https://github.com/apache/incubator-pekko-http/pull/73#issuecomment-1437681549
@pjfanning Are you sure this necessary? I was under the impression that source files are treated completely separately from configuration files (such as `.properties` or `.conf` files).
I haven't really seen copyright header on configuration files because then you get into problems with people copying and then modifying those configuration files as a base conf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on pull request #73: Add copyright headers
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #73:
URL: https://github.com/apache/incubator-pekko-http/pull/73#issuecomment-1437679623
not a big deal but could you update the conf files as https://github.com/apache/incubator-pekko-connectors/pull/31 does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #73: Add copyright headers
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #73:
URL: https://github.com/apache/incubator-pekko-http/pull/73#discussion_r1112777664
##########
project/CopyrightHeader.scala:
##########
@@ -1,11 +1,21 @@
/*
- * Copyright (C) 2018-2020 Lightbend Inc. <https://www.lightbend.com>
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * license agreements; and to You under the Apache License, version 2.0:
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * This file is part of the Apache Pekko project, derived from Akka.
+ */
+
+/*
+ * Copyright (C) 2018-2022 Lightbend Inc. <https://www.lightbend.com>
Review Comment:
Was that update intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #73: Add copyright headers
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #73:
URL: https://github.com/apache/incubator-pekko-http/pull/73#discussion_r1112787159
##########
project/CopyrightHeader.scala:
##########
@@ -1,11 +1,21 @@
/*
- * Copyright (C) 2018-2020 Lightbend Inc. <https://www.lightbend.com>
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * license agreements; and to You under the Apache License, version 2.0:
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * This file is part of the Apache Pekko project, derived from Akka.
+ */
+
+/*
+ * Copyright (C) 2018-2022 Lightbend Inc. <https://www.lightbend.com>
Review Comment:
I have just force pushed the changes, please recheck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #73: Add copyright headers
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #73:
URL: https://github.com/apache/incubator-pekko-http/pull/73#issuecomment-1438124581
> lgtm - we can look at conf files later
Mailing list discussion started at https://lists.apache.org/thread/9plz30o8g2258jmnb9mym3bfsdfyh9pz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org