You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/04/07 03:46:13 UTC
Review Request 58258: Added a new agent authorization test which runs
a task group.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58258/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7339
https://issues.apache.org/jira/browse/MESOS-7339
Repository: mesos
Description
-------
This patch adds a new test,
`SlaveAuthorizerTest.AuthorizeRunTaskGroupOnAgent`,
which verifies that task groups can be launched when
executor authentication is required and the local
authorizer is loaded.
Diffs
-----
src/tests/slave_authorization_tests.cpp 3657e0a3d19d75cef92e5bf90b65ef00c291b032
Diff: https://reviews.apache.org/r/58258/diff/1/
Testing
-------
`make check` when configured with SSL enabled.
Thanks,
Greg Mann
Re: Review Request 58258: Added a new agent authorization test which
runs a task group.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58258/#review171314
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58251, 58252, 58253, 58254, 58255, 58258]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 7, 2017, 3:46 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58258/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 3:46 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7339
> https://issues.apache.org/jira/browse/MESOS-7339
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new test,
> `SlaveAuthorizerTest.AuthorizeRunTaskGroupOnAgent`,
> which verifies that task groups can be launched when
> executor authentication is required and the local
> authorizer is loaded.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp 3657e0a3d19d75cef92e5bf90b65ef00c291b032
>
>
> Diff: https://reviews.apache.org/r/58258/diff/1/
>
>
> Testing
> -------
>
> `make check` when configured with SSL enabled.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58258: Added a new agent authorization test which
runs a task group.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58258/#review171610
-----------------------------------------------------------
src/tests/slave_authorization_tests.cpp
Lines 499-506 (patched)
<https://reviews.apache.org/r/58258/#comment244555>
Why do you need to test the `run_tasks` ACL in this test?
src/tests/slave_authorization_tests.cpp
Lines 566 (patched)
<https://reviews.apache.org/r/58258/#comment244553>
why do you need to configure this?
src/tests/slave_authorization_tests.cpp
Lines 566 (patched)
<https://reviews.apache.org/r/58258/#comment244554>
why do you need to configure this?
- Vinod Kone
On April 7, 2017, 3:46 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58258/
> -----------------------------------------------------------
>
> (Updated April 7, 2017, 3:46 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7339
> https://issues.apache.org/jira/browse/MESOS-7339
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new test,
> `SlaveAuthorizerTest.AuthorizeRunTaskGroupOnAgent`,
> which verifies that task groups can be launched when
> executor authentication is required and the local
> authorizer is loaded.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp 3657e0a3d19d75cef92e5bf90b65ef00c291b032
>
>
> Diff: https://reviews.apache.org/r/58258/diff/1/
>
>
> Testing
> -------
>
> `make check` when configured with SSL enabled.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58258: Added a new agent authorization test which
runs a task group.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58258/#review172292
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 13, 2017, 8:19 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58258/
> -----------------------------------------------------------
>
> (Updated April 13, 2017, 8:19 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7339
> https://issues.apache.org/jira/browse/MESOS-7339
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new test,
> `SlaveAuthorizerTest.AuthorizeRunTaskGroup`, which
> verifies that task groups can be launched when
> executor authentication is required and the local
> authorizer is loaded.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp 3657e0a3d19d75cef92e5bf90b65ef00c291b032
>
>
> Diff: https://reviews.apache.org/r/58258/diff/6/
>
>
> Testing
> -------
>
> `make check` when configured with SSL enabled.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58258: Added a new agent authorization test which
runs a task group.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58258/
-----------------------------------------------------------
(Updated April 13, 2017, 8:19 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7339
https://issues.apache.org/jira/browse/MESOS-7339
Repository: mesos
Description
-------
This patch adds a new test,
`SlaveAuthorizerTest.AuthorizeRunTaskGroup`, which
verifies that task groups can be launched when
executor authentication is required and the local
authorizer is loaded.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 3657e0a3d19d75cef92e5bf90b65ef00c291b032
Diff: https://reviews.apache.org/r/58258/diff/6/
Changes: https://reviews.apache.org/r/58258/diff/5-6/
Testing
-------
`make check` when configured with SSL enabled.
Thanks,
Greg Mann
Re: Review Request 58258: Added a new agent authorization test which
runs a task group.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58258/#review171814
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58251, 58252, 58253, 58254, 58255, 58258]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 12, 2017, 6:46 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58258/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 6:46 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7339
> https://issues.apache.org/jira/browse/MESOS-7339
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new test,
> `SlaveAuthorizerTest.AuthorizeRunTaskGroup`, which
> verifies that task groups can be launched when
> executor authentication is required and the local
> authorizer is loaded.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp 3657e0a3d19d75cef92e5bf90b65ef00c291b032
>
>
> Diff: https://reviews.apache.org/r/58258/diff/5/
>
>
> Testing
> -------
>
> `make check` when configured with SSL enabled.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58258: Added a new agent authorization test which
runs a task group.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58258/
-----------------------------------------------------------
(Updated April 12, 2017, 6:46 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
Changes
-------
Changed test to only run a single task.
Bugs: MESOS-7339
https://issues.apache.org/jira/browse/MESOS-7339
Repository: mesos
Description
-------
This patch adds a new test,
`SlaveAuthorizerTest.AuthorizeRunTaskGroup`, which
verifies that task groups can be launched when
executor authentication is required and the local
authorizer is loaded.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 3657e0a3d19d75cef92e5bf90b65ef00c291b032
Diff: https://reviews.apache.org/r/58258/diff/5/
Changes: https://reviews.apache.org/r/58258/diff/4-5/
Testing
-------
`make check` when configured with SSL enabled.
Thanks,
Greg Mann
Re: Review Request 58258: Added a new agent authorization test which
runs a task group.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58258/
-----------------------------------------------------------
(Updated April 12, 2017, 6:07 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
Changes
-------
Removed unnecessary code regarding the task user.
Bugs: MESOS-7339
https://issues.apache.org/jira/browse/MESOS-7339
Repository: mesos
Description
-------
This patch adds a new test,
`SlaveAuthorizerTest.AuthorizeRunTaskGroup`, which
verifies that task groups can be launched when
executor authentication is required and the local
authorizer is loaded.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 3657e0a3d19d75cef92e5bf90b65ef00c291b032
Diff: https://reviews.apache.org/r/58258/diff/4/
Changes: https://reviews.apache.org/r/58258/diff/3-4/
Testing
-------
`make check` when configured with SSL enabled.
Thanks,
Greg Mann
Re: Review Request 58258: Added a new agent authorization test which
runs a task group.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58258/
-----------------------------------------------------------
(Updated April 12, 2017, 5:57 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7339
https://issues.apache.org/jira/browse/MESOS-7339
Repository: mesos
Description
-------
This patch adds a new test,
`SlaveAuthorizerTest.AuthorizeRunTaskGroup`, which
verifies that task groups can be launched when
executor authentication is required and the local
authorizer is loaded.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 3657e0a3d19d75cef92e5bf90b65ef00c291b032
Diff: https://reviews.apache.org/r/58258/diff/3/
Changes: https://reviews.apache.org/r/58258/diff/2-3/
Testing
-------
`make check` when configured with SSL enabled.
Thanks,
Greg Mann
Re: Review Request 58258: Added a new agent authorization test which
runs a task group.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58258/
-----------------------------------------------------------
(Updated April 12, 2017, 5:10 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7339
https://issues.apache.org/jira/browse/MESOS-7339
Repository: mesos
Description (updated)
-------
This patch adds a new test,
`SlaveAuthorizerTest.AuthorizeRunTaskGroup`, which
verifies that task groups can be launched when
executor authentication is required and the local
authorizer is loaded.
Diffs (updated)
-----
src/tests/slave_authorization_tests.cpp 3657e0a3d19d75cef92e5bf90b65ef00c291b032
Diff: https://reviews.apache.org/r/58258/diff/2/
Changes: https://reviews.apache.org/r/58258/diff/1-2/
Testing
-------
`make check` when configured with SSL enabled.
Thanks,
Greg Mann