You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/08 10:38:20 UTC
[GitHub] [apisix-dashboard] LiteSun opened a new pull request #456: feat: preview pluginchart
LiteSun opened a new pull request #456:
URL: https://github.com/apache/apisix-dashboard/pull/456
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- Related issues
___
### Bugfix
- Description
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
added pluginchart preview in route step4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #456: feat: preview pluginchart
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #456:
URL: https://github.com/apache/apisix-dashboard/pull/456
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #456: feat: preview pluginchart
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #456:
URL: https://github.com/apache/apisix-dashboard/pull/456#discussion_r484935433
##########
File path: src/pages/Route/components/CreateStep4/CreateStep4.tsx
##########
@@ -44,7 +46,12 @@ const CreateStep4: React.FC<Props> = ({ form1, form2, redirect, ...rest }) => {
<h2 style={style}>{formatMessage({ id: 'route.create.define.api.backend.server' })}</h2>
<Step2 {...rest} form={form2} disabled />
<h2 style={style}>{formatMessage({ id: 'route.create.plugin.configuration' })}</h2>
- <PluginPage data={rest.data.step3Data.plugins} disabled />
+ {Boolean(Object.keys(plugins).length !== 0) && (
+ <PluginPage data={rest.data.step3Data.plugins} disabled />
+ )}
+ {Boolean(Object.keys(script).length !== 0) && (
+ <PluginChart data={rest.data.step3Data.script.chart} readonly onChange={() => {}} />
Review comment:
PluginChart is a React component from `api7-dashboard/pluginchart` module, which is used to render chart according to the schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #456: feat: preview pluginchart
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #456:
URL: https://github.com/apache/apisix-dashboard/pull/456#issuecomment-689268971
cc @moonming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #456: feat: preview pluginchart
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #456:
URL: https://github.com/apache/apisix-dashboard/pull/456#discussion_r485291538
##########
File path: src/pages/Route/components/CreateStep4/CreateStep4.tsx
##########
@@ -44,7 +46,12 @@ const CreateStep4: React.FC<Props> = ({ form1, form2, redirect, ...rest }) => {
<h2 style={style}>{formatMessage({ id: 'route.create.define.api.backend.server' })}</h2>
<Step2 {...rest} form={form2} disabled />
<h2 style={style}>{formatMessage({ id: 'route.create.plugin.configuration' })}</h2>
- <PluginPage data={rest.data.step3Data.plugins} disabled />
+ {Boolean(Object.keys(plugins).length !== 0) && (
+ <PluginPage data={rest.data.step3Data.plugins} disabled />
+ )}
+ {Boolean(Object.keys(script).length !== 0) && (
+ <PluginChart data={rest.data.step3Data.script.chart} readonly onChange={() => {}} />
Review comment:
it seems PluginOrchestration is a better choice, I will change`PluginChart` to `PluginOrchestration` later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #456: feat: preview pluginchart
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #456:
URL: https://github.com/apache/apisix-dashboard/pull/456#discussion_r484875289
##########
File path: src/pages/Route/components/CreateStep4/CreateStep4.tsx
##########
@@ -44,7 +46,12 @@ const CreateStep4: React.FC<Props> = ({ form1, form2, redirect, ...rest }) => {
<h2 style={style}>{formatMessage({ id: 'route.create.define.api.backend.server' })}</h2>
<Step2 {...rest} form={form2} disabled />
<h2 style={style}>{formatMessage({ id: 'route.create.plugin.configuration' })}</h2>
- <PluginPage data={rest.data.step3Data.plugins} disabled />
+ {Boolean(Object.keys(plugins).length !== 0) && (
+ <PluginPage data={rest.data.step3Data.plugins} disabled />
+ )}
+ {Boolean(Object.keys(script).length !== 0) && (
+ <PluginChart data={rest.data.step3Data.script.chart} readonly onChange={() => {}} />
Review comment:
what is `PluginChart`? do you mean `plugin orchestration`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org