You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "vasily.v.levchenko@gmail.com (JIRA)" <ji...@apache.org> on 2007/08/12 15:35:43 UTC
[jira] Created: (HARMONY-4622) [drlvm][jit][opt] Dublicated
functionality in Loop.cpp and loop_unrolling.cpp
[drlvm][jit][opt] Dublicated functionality in Loop.cpp and loop_unrolling.cpp
-----------------------------------------------------------------------------
Key: HARMONY-4622
URL: https://issues.apache.org/jira/browse/HARMONY-4622
Project: Harmony
Issue Type: Bug
Reporter: vasily.v.levchenko@gmail.com
Priority: Trivial
Hi folks,
I've found some duplication code in Jitrino for loop unroll optimization:
loop.unroll, loop.unroll_count in Loop.cpp and reacher set of parameter in loop_unroll.cpp.
The unroll optimization in Loop.cpp seems to be good candidate to be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-4622) [drlvm][jit][opt] Dublicated
functionality in Loop.cpp and loop_unrolling.cpp
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Fursov reassigned HARMONY-4622:
---------------------------------------
Assignee: Mikhail Fursov
> [drlvm][jit][opt] Dublicated functionality in Loop.cpp and loop_unrolling.cpp
> -----------------------------------------------------------------------------
>
> Key: HARMONY-4622
> URL: https://issues.apache.org/jira/browse/HARMONY-4622
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: vasily.v.levchenko@gmail.com
> Assignee: Mikhail Fursov
> Priority: Trivial
>
> Hi folks,
> I've found some duplication code in Jitrino for loop unroll optimization:
> loop.unroll, loop.unroll_count in Loop.cpp and reacher set of parameter in loop_unroll.cpp.
> The unroll optimization in Loop.cpp seems to be good candidate to be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4622) [drlvm][jit][opt] Dublicated
functionality in Loop.cpp and loop_unrolling.cpp
Posted by "vasily.v.levchenko@gmail.com (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
vasily.v.levchenko@gmail.com updated HARMONY-4622:
--------------------------------------------------
Component/s: DRLVM
> [drlvm][jit][opt] Dublicated functionality in Loop.cpp and loop_unrolling.cpp
> -----------------------------------------------------------------------------
>
> Key: HARMONY-4622
> URL: https://issues.apache.org/jira/browse/HARMONY-4622
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: vasily.v.levchenko@gmail.com
> Priority: Trivial
>
> Hi folks,
> I've found some duplication code in Jitrino for loop unroll optimization:
> loop.unroll, loop.unroll_count in Loop.cpp and reacher set of parameter in loop_unroll.cpp.
> The unroll optimization in Loop.cpp seems to be good candidate to be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4622) [drlvm][jit][opt] Dublicated
functionality in Loop.cpp and loop_unrolling.cpp
Posted by "vasily.v.levchenko@gmail.com (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519405 ]
vasily.v.levchenko@gmail.com commented on HARMONY-4622:
-------------------------------------------------------
Thanks Mikhail.
It looks good.
> [drlvm][jit][opt] Dublicated functionality in Loop.cpp and loop_unrolling.cpp
> -----------------------------------------------------------------------------
>
> Key: HARMONY-4622
> URL: https://issues.apache.org/jira/browse/HARMONY-4622
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: vasily.v.levchenko@gmail.com
> Assignee: Mikhail Fursov
> Priority: Trivial
> Attachments: unroll.diff
>
>
> Hi folks,
> I've found some duplication code in Jitrino for loop unroll optimization:
> loop.unroll, loop.unroll_count in Loop.cpp and reacher set of parameter in loop_unroll.cpp.
> The unroll optimization in Loop.cpp seems to be good candidate to be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4622) [drlvm][jit][opt] Dublicated
functionality in Loop.cpp and loop_unrolling.cpp
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Fursov resolved HARMONY-4622.
-------------------------------------
Resolution: Fixed
Committed revision 565339
> [drlvm][jit][opt] Dublicated functionality in Loop.cpp and loop_unrolling.cpp
> -----------------------------------------------------------------------------
>
> Key: HARMONY-4622
> URL: https://issues.apache.org/jira/browse/HARMONY-4622
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: vasily.v.levchenko@gmail.com
> Assignee: Mikhail Fursov
> Priority: Trivial
> Attachments: unroll.diff
>
>
> Hi folks,
> I've found some duplication code in Jitrino for loop unroll optimization:
> loop.unroll, loop.unroll_count in Loop.cpp and reacher set of parameter in loop_unroll.cpp.
> The unroll optimization in Loop.cpp seems to be good candidate to be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4622) [drlvm][jit][opt] Dublicated
functionality in Loop.cpp and loop_unrolling.cpp
Posted by "Egor Pasko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519391 ]
Egor Pasko commented on HARMONY-4622:
-------------------------------------
actually, Loop.cpp not only does unrolling, but also some peeling and loop invariants initialization. It is rather messy in some ways, for example, ABCD does not work very well with this stuff (dunno why yet). But, it could be a significant performance degradation if we remove the "peel" completely.
A want just to make sure that you are proposing to remove only unrolling and leave other peel stuff as is for now..
> [drlvm][jit][opt] Dublicated functionality in Loop.cpp and loop_unrolling.cpp
> -----------------------------------------------------------------------------
>
> Key: HARMONY-4622
> URL: https://issues.apache.org/jira/browse/HARMONY-4622
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: vasily.v.levchenko@gmail.com
> Priority: Trivial
>
> Hi folks,
> I've found some duplication code in Jitrino for loop unroll optimization:
> loop.unroll, loop.unroll_count in Loop.cpp and reacher set of parameter in loop_unroll.cpp.
> The unroll optimization in Loop.cpp seems to be good candidate to be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4622) [drlvm][jit][opt] Dublicated
functionality in Loop.cpp and loop_unrolling.cpp
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519402 ]
Mikhail Fursov commented on HARMONY-4622:
-----------------------------------------
Yes, your observation is right. Loop.cpp contains older unrolling version which does not remove loop-exits checks at all and is obsolete by new loop_unroll.cpp optimization.
I will provide a patch to remove it.
> [drlvm][jit][opt] Dublicated functionality in Loop.cpp and loop_unrolling.cpp
> -----------------------------------------------------------------------------
>
> Key: HARMONY-4622
> URL: https://issues.apache.org/jira/browse/HARMONY-4622
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: vasily.v.levchenko@gmail.com
> Assignee: Mikhail Fursov
> Priority: Trivial
>
> Hi folks,
> I've found some duplication code in Jitrino for loop unroll optimization:
> loop.unroll, loop.unroll_count in Loop.cpp and reacher set of parameter in loop_unroll.cpp.
> The unroll optimization in Loop.cpp seems to be good candidate to be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4622) [drlvm][jit][opt] Dublicated
functionality in Loop.cpp and loop_unrolling.cpp
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Fursov updated HARMONY-4622:
------------------------------------
Attachment: unroll.diff
unroll.diff: the patch
> [drlvm][jit][opt] Dublicated functionality in Loop.cpp and loop_unrolling.cpp
> -----------------------------------------------------------------------------
>
> Key: HARMONY-4622
> URL: https://issues.apache.org/jira/browse/HARMONY-4622
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: vasily.v.levchenko@gmail.com
> Assignee: Mikhail Fursov
> Priority: Trivial
> Attachments: unroll.diff
>
>
> Hi folks,
> I've found some duplication code in Jitrino for loop unroll optimization:
> loop.unroll, loop.unroll_count in Loop.cpp and reacher set of parameter in loop_unroll.cpp.
> The unroll optimization in Loop.cpp seems to be good candidate to be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4622) [drlvm][jit][opt] Dublicated
functionality in Loop.cpp and loop_unrolling.cpp
Posted by "Egor Pasko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519409 ]
Egor Pasko commented on HARMONY-4622:
-------------------------------------
looks good
> [drlvm][jit][opt] Dublicated functionality in Loop.cpp and loop_unrolling.cpp
> -----------------------------------------------------------------------------
>
> Key: HARMONY-4622
> URL: https://issues.apache.org/jira/browse/HARMONY-4622
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: vasily.v.levchenko@gmail.com
> Assignee: Mikhail Fursov
> Priority: Trivial
> Attachments: unroll.diff
>
>
> Hi folks,
> I've found some duplication code in Jitrino for loop unroll optimization:
> loop.unroll, loop.unroll_count in Loop.cpp and reacher set of parameter in loop_unroll.cpp.
> The unroll optimization in Loop.cpp seems to be good candidate to be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.