You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/02 14:49:08 UTC

[GitHub] [flink] cpugputpu opened a new pull request #11286: [FLINK-16386]Use LinkedHashMap for deterministic order SqlFunctionUtils.java

cpugputpu opened a new pull request #11286: [FLINK-16386]Use LinkedHashMap for deterministic order SqlFunctionUtils.java
URL: https://github.com/apache/flink/pull/11286
 
 
   ## What is the purpose of the change
   This PR aims to solve the issue here: https://issues.apache.org/jira/browse/FLINK-16386
   The fix is to use LinkedHashMap instead of HashMap. In this way, the test in `org.apache.flink.table.planner.expressions.ScalarFunctionsTest#testStringToMap` will not suffer from failure any more and the code will be more stable, free of this non-deterministic behaviour.
   
   ## Verifying this change
   This change is already covered by existing tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): don't know
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on issue #11286: [FLINK-16386][sql]Use LinkedHashMap for deterministic order SqlFunctionUtils.java

Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11286: [FLINK-16386][sql]Use LinkedHashMap for deterministic order SqlFunctionUtils.java
URL: https://github.com/apache/flink/pull/11286#issuecomment-593458352
 
 
   Just like last time, we should first evaluated whether the test should be adjusted instead.
   
   Please discuss the issue in the JIRA, and only open a PR once you have been assigned.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol closed pull request #11286: [FLINK-16386][sql]Use LinkedHashMap for deterministic order SqlFunctionUtils.java

Posted by GitBox <gi...@apache.org>.
zentol closed pull request #11286: [FLINK-16386][sql]Use LinkedHashMap for deterministic order SqlFunctionUtils.java
URL: https://github.com/apache/flink/pull/11286
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11286: [FLINK-16386][sql]Use LinkedHashMap for deterministic order SqlFunctionUtils.java

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11286: [FLINK-16386][sql]Use LinkedHashMap for deterministic order SqlFunctionUtils.java
URL: https://github.com/apache/flink/pull/11286#issuecomment-593451623
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cee5408799c1924058e091489ae4311178d807f8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cee5408799c1924058e091489ae4311178d807f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cee5408799c1924058e091489ae4311178d807f8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11286: [FLINK-16386]Use LinkedHashMap for deterministic order SqlFunctionUtils.java

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11286: [FLINK-16386]Use LinkedHashMap for deterministic order SqlFunctionUtils.java
URL: https://github.com/apache/flink/pull/11286#issuecomment-593440416
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit cee5408799c1924058e091489ae4311178d807f8 (Mon Mar 02 14:52:35 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16386).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services