You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vivek Ratnavel Subramanian <vi...@gmail.com> on 2017/01/05 22:10:08 UTC

Review Request 55232: Grafana datasource changes to accommodate new visualizations for TopN

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55232/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-19373
    https://issues.apache.org/jira/browse/AMBARI-19373


Repository: ambari


Description
-------

We need a visualization of a scatter plot for NNTop metrics for HDFS.


Diffs
-----

  ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js eb883e8 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-topn.json PRE-CREATION 

Diff: https://reviews.apache.org/r/55232/diff/


Testing
-------

Verified Manually using a canary build in a 5 node cluster.


Thanks,

Vivek Ratnavel Subramanian


Re: Review Request 55232: Grafana datasource changes to accommodate new visualizations for TopN

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55232/#review160775
-----------------------------------------------------------


Ship it!




Ship It!

- Yusaku Sako


On Jan. 5, 2017, 11:44 p.m., Vivek Ratnavel Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55232/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 11:44 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19373
>     https://issues.apache.org/jira/browse/AMBARI-19373
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We need a visualization of a scatter plot for NNTop metrics for HDFS.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js eb883e8 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-topn.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55232/diff/
> 
> 
> Testing
> -------
> 
> Verified Manually using a canary build in a 5 node cluster.
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>


Re: Review Request 55232: Grafana datasource changes to accommodate new visualizations for TopN

Posted by Vivek Ratnavel Subramanian <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55232/
-----------------------------------------------------------

(Updated Jan. 5, 2017, 11:44 p.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Changes
-------

1) Removed labels for the first three graphs.
2) Included the word "Sliding Window" in titles of all graphs.
3) Added an option "All" to the hosts dropdown and had it selected by default.

Verified Manually.


Bugs: AMBARI-19373
    https://issues.apache.org/jira/browse/AMBARI-19373


Repository: ambari


Description
-------

We need a visualization of a scatter plot for NNTop metrics for HDFS.


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js eb883e8 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-topn.json PRE-CREATION 

Diff: https://reviews.apache.org/r/55232/diff/


Testing
-------

Verified Manually using a canary build in a 5 node cluster.


Thanks,

Vivek Ratnavel Subramanian