Re: svn commit: rev 2209 - trunk/subversion/libsvn_ra_dav

[Karl Fogel <kf...@newton.ch.collab.net>]

philip@tigris.org writes:
> Log:
> Patch by Miklos Fazekas <bo...@mac.com> to fix unitialised memory read,
> confirmed with valgrind.
> 
> * subversion/libsvn_ra_dav/session.c (get_proxy): Initialise port_str
>   instead of proxy_port.

Since we don't have "svn blame" yet, I'll 'fess up :-).

Thanks for the fix!



> Modified: trunk/subversion/libsvn_ra_dav/session.c
> ==============================================================================
> --- trunk/subversion/libsvn_ra_dav/session.c	(original)
> +++ trunk/subversion/libsvn_ra_dav/session.c	Fri Jun 14 08:31:39 2002
> @@ -209,9 +209,9 @@
>  
>    /* If we find nothing, default to nulls. */
>    *proxy_host     = NULL;
> -  *proxy_port     = -1;
>    *proxy_username = NULL;
>    *proxy_password = NULL;
> +  port_str = NULL;
>  
>    SVN_ERR( svn_config_read_proxies(&cfg, pool) );
>  
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org