[GitHub] storm pull request:

[diginoise <gi...@git.apache.org>]

Github user diginoise commented on the pull request:

    https://github.com/apache/storm/commit/96da31ed0068dde3b4309ee417382be5084ce941#commitcomment-17367854
  
    Please note that making the logger name as `org.apache.storm.metric.LoggingMetricsConsumer` will cause the logger created within this class (using class' name) to actually use ROOT logger, instead of this logger, and the metrics entries are being logged into the standard OUT log of each worker. 
    
    One must create a separate logger outside of `org.apache.storm.*` hierarchy, i.e. the name cannot use the fully qualified name of the class where logging is happening from. 
    
    Calling it say `METRICS_LOGGER` and then creating it by calling `LoggerFactory.getLogger("METRICS_LOG")` inside `LoggingMetricsConsumer` would prevent log entries appearing in the logs governed by the ROOT logger.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---