You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "ankitsultana (via GitHub)" <gi...@apache.org> on 2023/03/13 17:11:32 UTC
[GitHub] [pinot] ankitsultana opened a new issue, #10415: [multistage] Type Inference for Case/When Has Some Issues
ankitsultana opened a new issue, #10415:
URL: https://github.com/apache/pinot/issues/10415
Detected this in https://github.com/apache/pinot/pull/10409
There's a todo left in `FunctionOperand` as well related to this: https://github.com/apache/pinot/blob/master/pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/FunctionOperand.java#L53
Essentially after the PR linked above, for the query below a couple of project nodes are merged and the case/when starts returning a Double at runtime which is compared against `16.0` which is a float.
```
SELECT intCol, CASE WHEN (SELECT SUM(floatCol) FROM {tbl1}) > 16.0 THEN 'Large sum' ELSE 'Small sum' END AS aggVal, strCol FROM {tbl1}
```
cc: @walterddr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr closed issue #10415: [multistage] Type Inference for Case/When Has Some Issues
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr closed issue #10415: [multistage] Type Inference for Case/When Has Some Issues
URL: https://github.com/apache/pinot/issues/10415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on issue #10415: [multistage] Type Inference for Case/When Has Some Issues
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on issue #10415:
URL: https://github.com/apache/pinot/issues/10415#issuecomment-1487516112
@ankitsultana could you share some query examples that have failed? so we can add test cases for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] abhioncbr commented on issue #10415: [multistage] Type Inference for Case/When Has Some Issues
Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr commented on issue #10415:
URL: https://github.com/apache/pinot/issues/10415#issuecomment-1482957361
@walterddr just pushed the [initial commit](https://github.com/apache/pinot/pull/10472); I want to validate my approach and understanding. Can you please have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ankitsultana commented on issue #10415: [multistage] Type Inference for Case/When Has Some Issues
Posted by "ankitsultana (via GitHub)" <gi...@apache.org>.
ankitsultana commented on issue #10415:
URL: https://github.com/apache/pinot/issues/10415#issuecomment-1489796365
Only case I had detected was present in the UTs. I think the PR already removes the "ignored" flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on issue #10415: [multistage] Type Inference for Case/When Has Some Issues
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on issue #10415:
URL: https://github.com/apache/pinot/issues/10415#issuecomment-1490562521
thank you will comment on the PR for some additional test examples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] abhioncbr commented on issue #10415: [multistage] Type Inference for Case/When Has Some Issues
Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr commented on issue #10415:
URL: https://github.com/apache/pinot/issues/10415#issuecomment-1477877761
Please assign this ticket to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org