You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/10 11:43:26 UTC
[GitHub] [airflow] ashb opened a new pull request #18140: Mark passing pre/post execute callbacks to operators as experimental.
ashb opened a new pull request #18140:
URL: https://github.com/apache/airflow/pull/18140
My primary concern here is that by being able to arbitrarily "change"
what an operator does will greatly increase the "accidental complexity"
of both Airflow (for us as developers) and of the DAG itself (for our
users).
By marking this features as experimental we reserve the right to delete
it at any point (for instance once we add better methods of doing what
the OP wanted with these hooks.)
See discussion starting https://github.com/apache/airflow/pull/17576#issuecomment-916361093
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18140: Mark passing pre/post execute callbacks to operators as experimental.
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18140:
URL: https://github.com/apache/airflow/pull/18140#issuecomment-916840480
/cc @malthe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #18140: Mark passing pre/post execute callbacks to operators as experimental.
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #18140:
URL: https://github.com/apache/airflow/pull/18140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18140: Mark passing pre/post execute callbacks to operators as experimental.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18140:
URL: https://github.com/apache/airflow/pull/18140#issuecomment-916860998
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org