You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by PSUdaemon <gi...@git.apache.org> on 2016/09/28 05:21:43 UTC
[GitHub] trafficserver pull request #1057: Fix clang-analyzer
GitHub user PSUdaemon opened a pull request:
https://github.com/apache/trafficserver/pull/1057
Fix clang-analyzer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PSUdaemon/trafficserver fix_clang_analyzer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1057.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1057
----
commit 70f0cd57ae9e44a430c80716fb60b031ea7a4163
Author: Phil Sorber <so...@apache.org>
Date: 2016-09-28T05:21:00Z
Fix clang-analyzer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1057: Fix clang-analyzer
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1057#discussion_r80844805
--- Diff: lib/atscppapi/examples/websocket/WebSocket.h ---
@@ -38,6 +38,11 @@ using atscppapi::InterceptPlugin;
using atscppapi::Transaction;
using atscppapi::GlobalPlugin;
+namespace
+{
+GlobalPlugin *plugin;
+}
--- End diff --
Shouldn't this be in the ``.cc`` file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1057: Fix clang-analyzer
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1057
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/888/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1057: TS-4699: Fix static analysis warnings
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1057
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/889/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1057: TS-4699: Fix static analysis warnings
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon closed the pull request at:
https://github.com/apache/trafficserver/pull/1057
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1057: Fix clang-analyzer
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1057#discussion_r80906705
--- Diff: lib/atscppapi/examples/websocket/WebSocket.h ---
@@ -38,6 +38,11 @@ using atscppapi::InterceptPlugin;
using atscppapi::Transaction;
using atscppapi::GlobalPlugin;
+namespace
+{
+GlobalPlugin *plugin;
+}
--- End diff --
That header file is only included for by this one plugin. I can move it though. I'll also fix the coverity issues that just came out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1057: Fix clang-analyzer
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1057
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/783/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1057: TS-4699: Fix static analysis warnings
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1057
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/784/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---