You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@shindig.apache.org by hs...@apache.org on 2012/08/14 03:19:54 UTC

svn commit: r1372695 - in /shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets: AbstractSpecFactory.java DefaultGadgetSpecFactory.java

Author: hsaputra
Date: Tue Aug 14 01:19:54 2012
New Revision: 1372695

URL: http://svn.apache.org/viewvc?rev=1372695&view=rev
Log:
Make the default gadget Spec Factory classes to be easier to extend/ override

Modified:
    shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java
    shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java

Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java?rev=1372695&r1=1372694&r2=1372695&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java Tue Aug 14 01:19:54 2012
@@ -166,6 +166,10 @@ public abstract class AbstractSpecFactor
     private Uri gadgetUri = null;
     private boolean ignoreCache = false;
 
+    // Expose public constructor
+    public Query() {
+    }
+
     public Query setSpecUri(Uri specUri) {
       this.specUri = specUri;
       return this;

Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java?rev=1372695&r1=1372694&r2=1372695&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java Tue Aug 14 01:19:54 2012
@@ -42,7 +42,7 @@ public class DefaultGadgetSpecFactory ex
     implements GadgetSpecFactory {
   public static final String CACHE_NAME = "gadgetSpecs";
   public static final String RAW_GADGETSPEC_XML_PARAM_NAME = "rawxml";
-  static final Uri RAW_GADGET_URI = Uri.parse("http://localhost/raw.xml");
+  public static final Uri RAW_GADGET_URI = Uri.parse("http://localhost/raw.xml");
 
   @Inject
   public DefaultGadgetSpecFactory(ExecutorService executor,
@@ -78,7 +78,7 @@ public class DefaultGadgetSpecFactory ex
         .setContainer(context.getContainer())
         .setGadgetUri(gadgetUri)
         .setIgnoreCache(context.getIgnoreCache());
-    return super.getSpec(query);
+    return getSpec(query);
   }
 
   private static final String BOM_ENTITY = "&#xFEFF;";