You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/19 12:00:08 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #1909: minor: add a diagram to docstring for DictionaryArray
alamb opened a new pull request, #1909:
URL: https://github.com/apache/arrow-rs/pull/1909
Rationale:
I made a diagram while working with @AssHero on https://github.com/apache/arrow-datafusion/pull/2721 which I felt would be generally helpful as the `keys` and `values` terminology often gets confusing.
Changes:
Add some more docstrings to `DictionaryArray` based on https://github.com/apache/arrow-datafusion/pull/2721#discussion_r901091846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1909: minor: add a diagram to docstring for DictionaryArray
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1909:
URL: https://github.com/apache/arrow-rs/pull/1909#issuecomment-1161611538
> DictionaryArray is always used when you have data with many repeated values. So maybe it is better to give an example with short and fat values array and long keys array.
Good point @HaoYang670 -- I updated the diagram in https://github.com/apache/arrow-rs/pull/1909/commits/8cf0dd3d68d6c7ec0f2d41574b0ac13fa7b20a8e -- what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] waynexia commented on a diff in pull request #1909: minor: add a diagram to docstring for DictionaryArray
Posted by GitBox <gi...@apache.org>.
waynexia commented on code in PR #1909:
URL: https://github.com/apache/arrow-rs/pull/1909#discussion_r901114505
##########
arrow/src/array/array_dictionary.rs:
##########
@@ -33,6 +33,31 @@ use crate::error::Result;
/// This is mostly used to represent strings or a limited set of primitive types as integers,
/// for example when doing NLP analysis or representing chromosomes by name.
///
+/// [`DictionaryArray`] are represented using a `keys` array and a
+/// `values` array, which may be diferent lengths. The `keys` array
Review Comment:
```suggestion
/// `values` array, which may be different lengths. The `keys` array
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1909: minor: add a diagram to docstring for DictionaryArray
Posted by GitBox <gi...@apache.org>.
alamb merged PR #1909:
URL: https://github.com/apache/arrow-rs/pull/1909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on a diff in pull request #1909: minor: add a diagram to docstring for DictionaryArray
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on code in PR #1909:
URL: https://github.com/apache/arrow-rs/pull/1909#discussion_r901107414
##########
arrow/src/array/array_dictionary.rs:
##########
@@ -33,6 +33,31 @@ use crate::error::Result;
/// This is mostly used to represent strings or a limited set of primitive types as integers,
/// for example when doing NLP analysis or representing chromosomes by name.
///
+/// [`DictionaryArray`] are represented using a `keys` array and a
+/// `values` array, which may be diferent lengths. The `keys` array
+/// stores indexes in the `values` array which holding holds
Review Comment:
```suggestion
/// stores indexes in the `values` array which holds
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1909: minor: add a diagram to docstring for DictionaryArray
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1909:
URL: https://github.com/apache/arrow-rs/pull/1909#issuecomment-1159709368
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1909](https://codecov.io/gh/apache/arrow-rs/pull/1909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ecaa747) into [master](https://codecov.io/gh/apache/arrow-rs/commit/ded63168de4dce7e4e92753bd39d60d20bfb683e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ded6316) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1909 +/- ##
=======================================
Coverage 83.41% 83.42%
=======================================
Files 214 214
Lines 56991 56991
=======================================
+ Hits 47541 47542 +1
+ Misses 9450 9449 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/array\_dictionary.rs](https://codecov.io/gh/apache/arrow-rs/pull/1909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X2RpY3Rpb25hcnkucnM=) | `91.91% <ø> (ø)` | |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1909/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `66.21% <0.00%> (+0.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1909?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1909?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ded6316...ecaa747](https://codecov.io/gh/apache/arrow-rs/pull/1909?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org