[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #833: HDDS-3314. scmcli container info command failing intermittently

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #833: HDDS-3314. scmcli container info command failing intermittently
URL: https://github.com/apache/hadoop-ozone/pull/833#discussion_r409885190
 
 

 ##########
 File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerOperationClient.java
 ##########
 @@ -382,7 +382,7 @@ public ContainerDataProto readContainer(long containerID,
       Pipeline pipeline) throws IOException {
     XceiverClientSpi client = null;
     try {
-      client = xceiverClientManager.acquireClient(pipeline);
+      client = xceiverClientManager.acquireClientForReadData(pipeline);
 
 Review comment:
   I have not really understood this change, as we just changed from acquireClient  -> acquireClientForReadData.
   How that will handle failures, and how it will retry on other datanodes.
   
   And also InfoSubCommand Uses below code, and it is not calling readContainer.
         final ContainerWithPipeline container = scmClient.
             getContainerWithPipeline(containerID);
   
   >       final ContainerWithPipeline container = scmClient.
   >           getContainerWithPipeline(containerID);
   >       Preconditions.checkNotNull(container, "Container cannot be null");

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org