You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shahidki31 <gi...@git.apache.org> on 2018/10/06 04:50:29 UTC
[GitHub] spark pull request #22650: [SPARK-25575][FOLLOWUP]SQL tab in the spark UI su...
GitHub user shahidki31 opened a pull request:
https://github.com/apache/spark/pull/22650
[SPARK-25575][FOLLOWUP]SQL tab in the spark UI support hide tables
## What changes were proposed in this pull request?
After the PR, https://github.com/apache/spark/pull/22592, SQL tab supports collapsing table.
However, after refreshing the page, it doesn't store it previous stage. This was due to a typo in the argument list in the collapseTablePageLoadCommand() function.
## How was this patch tested?
bin/spark-shell
```
sql("create table a (id int)")
for(i <- 1 to 100) sql(s"insert into a values ($i)")
```
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shahidki31/spark SPARK-25575-followUp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22650.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22650
----
commit cd9ef14c4060d38a26dd31555b53a6bf9820fe17
Author: Shahid <sh...@...>
Date: 2018-10-06T04:30:54Z
SPARK-25566
[Spark Job History] SQL UI Page does not support Pagination
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22650: [SPARK-25575][FOLLOWUP]SQL tab in the spark UI support h...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22650
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22650: [SPARK-25575][WEBUI][FOLLOWUP]SQL tab in the spark UI su...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22650
**[Test build #4359 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4359/testReport)** for PR 22650 at commit [`cd9ef14`](https://github.com/apache/spark/commit/cd9ef14c4060d38a26dd31555b53a6bf9820fe17).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22650: [SPARK-25575][FOLLOWUP]SQL tab in the spark UI support h...
Posted by shahidki31 <gi...@git.apache.org>.
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22650
Hi @srowen , Kindly review and merge.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22650: [SPARK-25575][FOLLOWUP]SQL tab in the spark UI support h...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22650
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22650: [SPARK-25575][FOLLOWUP]SQL tab in the spark UI support h...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22650
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22650: [SPARK-25575][WEBUI][FOLLOWUP]SQL tab in the spark UI su...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22650
Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22650: [SPARK-25575][WEBUI][FOLLOWUP]SQL tab in the spark UI su...
Posted by shahidki31 <gi...@git.apache.org>.
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22650
Thanks a lot @srown
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22650: [SPARK-25575][WEBUI][FOLLOWUP]SQL tab in the spark UI su...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22650
**[Test build #4359 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4359/testReport)** for PR 22650 at commit [`cd9ef14`](https://github.com/apache/spark/commit/cd9ef14c4060d38a26dd31555b53a6bf9820fe17).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22650: [SPARK-25575][WEBUI][FOLLOWUP]SQL tab in the spar...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22650
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22650: [SPARK-25575][FOLLOWUP]SQL tab in the spark UI support h...
Posted by shahidki31 <gi...@git.apache.org>.
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22650
Hi @srowen , Kindly review and merge. This PR will be dependent on the PR https://github.com/apache/spark/pull/22645
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org