You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/11/16 08:16:36 UTC
[GitHub] [maven-enforcer] timtebeek opened a new pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency
timtebeek opened a new pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----
Turns out it was way easier to remove PlexusTestCase than I had originally thought. :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] timtebeek commented on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency
Posted by GitBox <gi...@apache.org>.
timtebeek commented on pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-970695981
Done! That indeed helps, and seems a nice addition to not have to declare the engine anymore.
Would you want to restore the `mockito-core` dependency + management? Keep in mind that would trigger Dependabot twice, or require a version variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski edited a comment on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency
Posted by GitBox <gi...@apache.org>.
slawekjaranowski edited a comment on pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-970645781
hint add to `pluginManagment` in root pom
```xml
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.0.0-M5</version>
</plugin>
```
and `junit-jupiter-engine` can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] timtebeek commented on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency
Posted by GitBox <gi...@apache.org>.
timtebeek commented on pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-970014945
Hmm the additional test failures are somewhat puzzling; needs a closer look, which in my case is limited to evenings/weekends. :disappointed:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] timtebeek commented on a change in pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency
Posted by GitBox <gi...@apache.org>.
timtebeek commented on a change in pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125#discussion_r750608081
##########
File path: pom.xml
##########
@@ -128,22 +128,15 @@
<scope>test</scope>
</dependency>
<dependency>
- <!-- Needed as PlexusTestCase extends junit.framework.TestCase -->
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13.2</version>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.mockito</groupId>
- <artifactId>mockito-core</artifactId>
- <version>4.0.0</version>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
Review comment:
Without `junit-jupiter-engine` the tests fail in both `enforcer-rules` and `maven-enforcer-plugin`.
I had run `dependency:tree`, which shows JUnit 4 is no longer on the classpath.
`dependency:analyze` shows `enforcer-rules` would only need `mockito-core` as opposed to `mockito-junit-jupiter`, but then you'd have to manage that dependency as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] timtebeek commented on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency
Posted by GitBox <gi...@apache.org>.
timtebeek commented on pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-971467759
Went through the `mvn dependency:analyze` output once more and removed all unused declared dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] timtebeek commented on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency
Posted by GitBox <gi...@apache.org>.
timtebeek commented on pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-970553691
Turns out we did need the junit-jupiter-engine [after all](https://github.com/apache/maven-enforcer/pull/113#discussion_r749185199); Time for another quick review @slawekjaranowski ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slachiewicz closed pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency
Posted by GitBox <gi...@apache.org>.
slachiewicz closed pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on a change in pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125#discussion_r750595602
##########
File path: pom.xml
##########
@@ -128,22 +128,15 @@
<scope>test</scope>
</dependency>
<dependency>
- <!-- Needed as PlexusTestCase extends junit.framework.TestCase -->
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13.2</version>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.mockito</groupId>
- <artifactId>mockito-core</artifactId>
- <version>4.0.0</version>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
Review comment:
Is it needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-970645781
hint add to `pluginManagment` in root pom
```xml
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.0.0-M5</version>
</plugin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slachiewicz closed pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency
Posted by GitBox <gi...@apache.org>.
slachiewicz closed pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #125: [MENFORCER-372] Drop PlexusTestCase and junit:junit dependency
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #125:
URL: https://github.com/apache/maven-enforcer/pull/125#issuecomment-971406915
For many components from the same project please use property as version and will be one update by dependabot.
Please also check if `maven-plugin-testing-harness`, `maven-compact` is still needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org