[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1825: SOLR-14828: reduce 'error' logging noise in BaseCloudSolrClient.requestWithRetryOnStaleState

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #1825:
URL: https://github.com/apache/lucene-solr/pull/1825#discussion_r488071700



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java
##########
@@ -994,12 +991,15 @@ public RouteException(ErrorCode errorCode, NamedList<Throwable> throwables, Map<
           // and we could not get any information from the server
           //it is probably not worth trying again and again because
           // the state would not have been updated
-          log.info("trying request again");
+          log.info("Request to collection {} failed due to ({}) {}, retry={} commError={} errorCode={} - retrying",
+              inputCollections, errorCode, rootCause, retryCount, wasCommError, errorCode);
           return requestWithRetryOnStaleState(request, retryCount + 1, inputCollections);
         }
       } else {
         log.info("request was not communication error it seems");
       }
+      log.error("Request to collection {} failed due to ({}) {}, retry={} commError={} errorCode={} ",

Review comment:
       `max retries hit` is a little tricky to determine exactly since e.g. `commError` and other things influence the logic. But inclusion of `MAX_STALE_RETRIES` in the logging could make it clear(er) when "max retries hit" was likely the case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org