You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2008/01/31 22:33:10 UTC

[jira] Created: (HTTPCLIENT-738) HostnameVerifier shouldn't shadow simple name of implemented interface

HostnameVerifier shouldn't shadow simple name of implemented interface
----------------------------------------------------------------------

                 Key: HTTPCLIENT-738
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-738
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpClient
            Reporter: Sebb


public interface HostnameVerifier extends javax.net.ssl.HostnameVerifier.

As Findbugs says:

Class names shouldn't shadow simple name of implemented interface

This class/interface has a simple name that is identical to that of an implemented/extended interface, except that the interface is in a different package (e.g., alpha.Foo extends beta.Foo). This can be exceptionally confusing, create lots of situations in which you have to look at import statements to resolve references and creates many opportunities to accidently define methods that do not override methods in their superclasses. 


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Resolved: (HTTPCLIENT-738) HostnameVerifier shouldn't shadow simple name of implemented interface

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-738.
------------------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0 Alpha 3

Renamed o.a.http.conn.ssl.HostnameVerifier to o.a.http.conn.ssl.X509HostnameVerifier

Oleg

> HostnameVerifier shouldn't shadow simple name of implemented interface
> ----------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-738
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-738
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>            Reporter: Sebb
>             Fix For: 4.0 Alpha 3
>
>
> public interface HostnameVerifier extends javax.net.ssl.HostnameVerifier.
> As Findbugs says:
> Class names shouldn't shadow simple name of implemented interface
> This class/interface has a simple name that is identical to that of an implemented/extended interface, except that the interface is in a different package (e.g., alpha.Foo extends beta.Foo). This can be exceptionally confusing, create lots of situations in which you have to look at import statements to resolve references and creates many opportunities to accidently define methods that do not override methods in their superclasses. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org