You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2026/09/09 05:49:00 UTC

[jira] [Commented] (OFBIZ-13525) createQuoteFromCart duplicates QuoteAdjustment records

    [ https://issues.apache.org/jira/browse/OFBIZ-13525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113142#comment-18113142 ] 

ASF subversion and git services commented on OFBIZ-13525:
---------------------------------------------------------

Commit e9c3244ad7c6e237e924a64c60ab54a25a7cbb6b in ofbiz-framework's branch refs/heads/trunk from Mridul Pathak
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e9c3244ad7 ]

Fixed: createQuoteFromCart duplicates QuoteAdjustment records (OFBIZ-13525)

The block that creates QuoteAdjustment records from the cart's store
promotions was nested inside the per-cart-item loop instead of running
once after it. Every store promotion recomputed by makeAllQuoteAdjustments()
covers the whole cart, not a single item, so nesting it inside the loop
persisted the same set of adjustments once per cart item instead of once
per order, inflating quote totals for any cart with more than one item.
Moving the block outside the loop restores the original minilang's
once-per-cart behavior.


> createQuoteFromCart duplicates QuoteAdjustment records
> ------------------------------------------------------
>
>                 Key: OFBIZ-13525
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-13525
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Upcoming Branch, 24.09.07
>            Reporter: Mridul Pathak
>            Assignee: Mridul Pathak
>            Priority: Major
>
> Adjustment creation runs inside the per-item loop instead of once, duplicating records by cart size.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)