You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@gmail.com> on 2012/03/16 23:17:40 UTC
Review Request: FLUME-1035: Fix unit test logging issues with SDK
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4392/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
This patch fixes issues with unit test logging in the SDK.
This addresses bug FLUME-1035.
https://issues.apache.org/jira/browse/FLUME-1035
Diffs
-----
flume-ng-sdk/pom.xml d1c6adf
flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d
flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4
flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION
Diff: https://reviews.apache.org/r/4392/diff
Testing
-------
Thanks,
Mike
Re: Review Request: FLUME-1035: Fix unit test logging issues with SDK
Posted by Mike Percy <mp...@gmail.com>.
> On 2012-03-17 13:33:38, Brock Noland wrote:
> > Attach the patch to the JIRA and I will see if my commit privileges are working.
Done. Thanks Brock!
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4392/#review6063
-----------------------------------------------------------
On 2012-03-17 02:03:05, Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4392/
> -----------------------------------------------------------
>
> (Updated 2012-03-17 02:03:05)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> This patch fixes issues with unit test logging in the SDK.
>
>
> This addresses bug FLUME-1035.
> https://issues.apache.org/jira/browse/FLUME-1035
>
>
> Diffs
> -----
>
> flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION
> flume-ng-sdk/pom.xml d1c6adf
> flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d
> flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4
>
> Diff: https://reviews.apache.org/r/4392/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike
>
>
Re: Review Request: FLUME-1035: Fix unit test logging issues with SDK
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4392/#review6063
-----------------------------------------------------------
Ship it!
Attach the patch to the JIRA and I will see if my commit privileges are working.
- Brock
On 2012-03-17 02:03:05, Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4392/
> -----------------------------------------------------------
>
> (Updated 2012-03-17 02:03:05)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> This patch fixes issues with unit test logging in the SDK.
>
>
> This addresses bug FLUME-1035.
> https://issues.apache.org/jira/browse/FLUME-1035
>
>
> Diffs
> -----
>
> flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION
> flume-ng-sdk/pom.xml d1c6adf
> flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d
> flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4
>
> Diff: https://reviews.apache.org/r/4392/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike
>
>
Re: Review Request: FLUME-1035: Fix unit test logging issues with SDK
Posted by Mike Percy <mp...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4392/
-----------------------------------------------------------
(Updated 2012-03-17 02:03:05.530063)
Review request for Flume.
Changes
-------
There is a weird issue with Maven (bug?) where if one of my dependencies has a dependency set to "test", the distribution will not include it if I have the same dependency set to "compile". For the moment, the workaround is to specify slf4j-api as a dependency, along with slf4j-log4j12, even though they are only used in the tests.
Summary
-------
This patch fixes issues with unit test logging in the SDK.
This addresses bug FLUME-1035.
https://issues.apache.org/jira/browse/FLUME-1035
Diffs (updated)
-----
flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION
flume-ng-sdk/pom.xml d1c6adf
flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d
flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4
Diff: https://reviews.apache.org/r/4392/diff
Testing
-------
Thanks,
Mike