You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2024/03/01 07:07:45 UTC

(maven-compiler-plugin) branch master updated: update comments

This is an automated email from the ASF dual-hosted git repository.

hboutemy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-compiler-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 87ff9f7  update comments
87ff9f7 is described below

commit 87ff9f72af65be3ad3601cf1a66675187d203a37
Author: Hervé Boutemy <hb...@apache.org>
AuthorDate: Fri Mar 1 08:07:35 2024 +0100

    update comments
---
 .../org/apache/maven/plugin/compiler/AbstractCompilerMojo.java     | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java b/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
index 3f4278a..365a649 100644
--- a/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
+++ b/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
@@ -1076,7 +1076,7 @@ public abstract class AbstractCompilerMojo extends AbstractMojo {
             try {
                 if (fork) {
                     if (compilerConfiguration.getExecutable() != null) {
-                        getLog().debug("Excutable: ");
+                        getLog().debug("Executable: ");
                         getLog().debug(" " + compilerConfiguration.getExecutable());
                     }
                 }
@@ -1496,14 +1496,13 @@ public abstract class AbstractCompilerMojo extends AbstractMojo {
         return value;
     }
 
-    // TODO remove the part with ToolchainManager lookup once we depend on
-    // 3.0.9 (have it as prerequisite). Define as regular component field then.
     protected final Toolchain getToolchain() {
         Toolchain tc = null;
 
         if (jdkToolchain != null) {
-            // Maven 3.3.1 has plugin execution scoped Toolchain Support
+            // require Maven 3.3.1, that has plugin execution scoped Toolchain support MNG-5755
             try {
+                // TODO use direct method invocation when prerequisite upgraded to Maven 3.3.1
                 Method getToolchainsMethod = toolchainManager
                         .getClass()
                         .getMethod("getToolchains", MavenSession.class, String.class, Map.class);