You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/27 08:11:28 UTC
[GitHub] [dolphinscheduler] ruanwenjun opened a new pull request, #10631: [Bug] [Master] Worker failover will cause task cannot be failover
ruanwenjun opened a new pull request, #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631
## Purpose of the pull request
close #10630
## Brief change log
* When do worker failover, directly query the taskInstance from cache.
* Add some log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10631: [Bug] [Master] Worker failover will cause task cannot be failover
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631#issuecomment-1167364182
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10631)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_coverage&view=list) [8.9% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #10631: [Bug] [Master] Worker failover will cause task cannot be failover
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631#discussion_r908108266
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java:
##########
@@ -460,23 +460,23 @@ public static int getProcessID() {
}
/**
- * check memory and cpu usage
+ * Check memory and cpu usage is overload the given thredshod.
*
- * @param maxCpuloadAvg maxCpuloadAvg
+ * @param maxCpuLoadAvg maxCpuLoadAvg
* @param reservedMemory reservedMemory
- * @return check memory and cpu usage
+ * @return True, if the cpu or memory exceed the given thredshod.
*/
- public static Boolean checkResource(double maxCpuloadAvg, double reservedMemory) {
+ public static Boolean checkOverload(double maxCpuLoadAvg, double reservedMemory) {
// system load average
double loadAverage = loadAverage();
// system available physical memory
double availablePhysicalMemorySize = availablePhysicalMemorySize();
- if (loadAverage > maxCpuloadAvg || availablePhysicalMemorySize < reservedMemory) {
- logger.warn("current cpu load average {} is too high or available memory {}G is too low, under max.cpuload.avg={} and reserved.memory={}G",
- loadAverage, availablePhysicalMemorySize, maxCpuloadAvg, reservedMemory);
- return false;
- } else {
+ if (loadAverage > maxCpuLoadAvg || availablePhysicalMemorySize < reservedMemory) {
+ logger.warn("Current cpu load average {} is too high or available memory {}G is too low, under max.cpuLoad.avg={} and reserved.memory={}G",
+ loadAverage, availablePhysicalMemorySize, maxCpuLoadAvg, reservedMemory);
return true;
+ } else {
+ return false;
Review Comment:
Done
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/service/FailoverService.java:
##########
@@ -67,15 +71,20 @@ public class FailoverService {
private final MasterConfig masterConfig;
private final ProcessService processService;
private final WorkflowExecuteThreadPool workflowExecuteThreadPool;
+ private final ProcessInstanceExecCacheManager cacheManager;
+ private final String localAddress;
public FailoverService(RegistryClient registryClient,
MasterConfig masterConfig,
ProcessService processService,
- WorkflowExecuteThreadPool workflowExecuteThreadPool) {
+ WorkflowExecuteThreadPool workflowExecuteThreadPool,
+ ProcessInstanceExecCacheManager cacheManager) {
this.registryClient = checkNotNull(registryClient);
this.masterConfig = checkNotNull(masterConfig);
this.processService = checkNotNull(processService);
this.workflowExecuteThreadPool = checkNotNull(workflowExecuteThreadPool);
+ this.cacheManager = checkNotNull(cacheManager);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10631: [Bug] [Master] Worker failover will cause task cannot be failover
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631#issuecomment-1168337268
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10631)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_coverage&view=list) [10.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huanhuande commented on pull request #10631: [Bug] [Master] Worker failover will cause task cannot be failover
Posted by GitBox <gi...@apache.org>.
huanhuande commented on PR #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631#issuecomment-1211624520
Can I ask if 10631 mainly fixes the master deadlock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10631: [Bug] [Master] Worker failover will cause task cannot be failover
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631#issuecomment-1168343511
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10631)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_coverage&view=list) [10.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #10631: [Bug] [Master] Worker failover will cause task cannot be failover
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631#issuecomment-1167394987
@caishunfeng Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #10631: [Bug] [Master] Worker failover will cause task cannot be failover
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631#discussion_r908080548
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java:
##########
@@ -460,23 +460,23 @@ public static int getProcessID() {
}
/**
- * check memory and cpu usage
+ * Check memory and cpu usage is overload the given thredshod.
*
- * @param maxCpuloadAvg maxCpuloadAvg
+ * @param maxCpuLoadAvg maxCpuLoadAvg
* @param reservedMemory reservedMemory
- * @return check memory and cpu usage
+ * @return True, if the cpu or memory exceed the given thredshod.
*/
- public static Boolean checkResource(double maxCpuloadAvg, double reservedMemory) {
+ public static Boolean checkOverload(double maxCpuLoadAvg, double reservedMemory) {
Review Comment:
```suggestion
public static boolean checkOverload(double maxCpuLoadAvg, double reservedMemory) {
```
It'd be more clear if we can rename to something like `isOverloaded`
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java:
##########
@@ -460,23 +460,23 @@ public static int getProcessID() {
}
/**
- * check memory and cpu usage
+ * Check memory and cpu usage is overload the given thredshod.
*
- * @param maxCpuloadAvg maxCpuloadAvg
+ * @param maxCpuLoadAvg maxCpuLoadAvg
* @param reservedMemory reservedMemory
- * @return check memory and cpu usage
+ * @return True, if the cpu or memory exceed the given thredshod.
*/
- public static Boolean checkResource(double maxCpuloadAvg, double reservedMemory) {
+ public static Boolean checkOverload(double maxCpuLoadAvg, double reservedMemory) {
// system load average
double loadAverage = loadAverage();
// system available physical memory
double availablePhysicalMemorySize = availablePhysicalMemorySize();
- if (loadAverage > maxCpuloadAvg || availablePhysicalMemorySize < reservedMemory) {
- logger.warn("current cpu load average {} is too high or available memory {}G is too low, under max.cpuload.avg={} and reserved.memory={}G",
- loadAverage, availablePhysicalMemorySize, maxCpuloadAvg, reservedMemory);
- return false;
- } else {
+ if (loadAverage > maxCpuLoadAvg || availablePhysicalMemorySize < reservedMemory) {
+ logger.warn("Current cpu load average {} is too high or available memory {}G is too low, under max.cpuLoad.avg={} and reserved.memory={}G",
+ loadAverage, availablePhysicalMemorySize, maxCpuLoadAvg, reservedMemory);
return true;
+ } else {
+ return false;
Review Comment:
```suggestion
}
return false;
```
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/service/FailoverService.java:
##########
@@ -67,15 +71,20 @@ public class FailoverService {
private final MasterConfig masterConfig;
private final ProcessService processService;
private final WorkflowExecuteThreadPool workflowExecuteThreadPool;
+ private final ProcessInstanceExecCacheManager cacheManager;
+ private final String localAddress;
public FailoverService(RegistryClient registryClient,
MasterConfig masterConfig,
ProcessService processService,
- WorkflowExecuteThreadPool workflowExecuteThreadPool) {
+ WorkflowExecuteThreadPool workflowExecuteThreadPool,
+ ProcessInstanceExecCacheManager cacheManager) {
this.registryClient = checkNotNull(registryClient);
this.masterConfig = checkNotNull(masterConfig);
this.processService = checkNotNull(processService);
this.workflowExecuteThreadPool = checkNotNull(workflowExecuteThreadPool);
+ this.cacheManager = checkNotNull(cacheManager);
Review Comment:
nit: `@NonNull`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #10631: [Bug] [Master] Worker failover will cause task cannot be failover
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631#discussion_r908107870
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java:
##########
@@ -460,23 +460,23 @@ public static int getProcessID() {
}
/**
- * check memory and cpu usage
+ * Check memory and cpu usage is overload the given thredshod.
*
- * @param maxCpuloadAvg maxCpuloadAvg
+ * @param maxCpuLoadAvg maxCpuLoadAvg
* @param reservedMemory reservedMemory
- * @return check memory and cpu usage
+ * @return True, if the cpu or memory exceed the given thredshod.
*/
- public static Boolean checkResource(double maxCpuloadAvg, double reservedMemory) {
+ public static Boolean checkOverload(double maxCpuLoadAvg, double reservedMemory) {
Review Comment:
Thanks for your suggestion, agree with you.
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java:
##########
@@ -460,23 +460,23 @@ public static int getProcessID() {
}
/**
- * check memory and cpu usage
+ * Check memory and cpu usage is overload the given thredshod.
*
- * @param maxCpuloadAvg maxCpuloadAvg
+ * @param maxCpuLoadAvg maxCpuLoadAvg
* @param reservedMemory reservedMemory
- * @return check memory and cpu usage
+ * @return True, if the cpu or memory exceed the given thredshod.
*/
- public static Boolean checkResource(double maxCpuloadAvg, double reservedMemory) {
+ public static Boolean checkOverload(double maxCpuLoadAvg, double reservedMemory) {
Review Comment:
Thanks for your suggestion, agree with you. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun merged pull request #10631: [Bug] [Master] Worker failover will cause task cannot be failover
Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10631: [Bug] [Master] Worker failover will cause task cannot be failover
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631#issuecomment-1167311823
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10631)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10631&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_coverage&view=list) [8.9% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10631&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10631: [Bug] [Master] Worker failover will cause task cannot be failover
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631#issuecomment-1167356495
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10631?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10631](https://codecov.io/gh/apache/dolphinscheduler/pull/10631?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08f739a) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/a6fc70cdd111a52a1342ff78953f5c3948e8add1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6fc70c) will **decrease** coverage by `0.12%`.
> The diff coverage is `25.60%`.
> :exclamation: Current head 08f739a differs from pull request most recent head f980a4a. Consider uploading reports for the commit f980a4a to get more accurate results
```diff
@@ Coverage Diff @@
## dev #10631 +/- ##
============================================
- Coverage 41.07% 40.95% -0.13%
+ Complexity 4896 4849 -47
============================================
Files 895 895
Lines 36223 36146 -77
Branches 3987 3982 -5
============================================
- Hits 14880 14802 -78
+ Misses 19880 19879 -1
- Partials 1463 1465 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/10631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...r/api/service/impl/WorkFlowLineageServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Xb3JrRmxvd0xpbmVhZ2VTZXJ2aWNlSW1wbC5qYXZh) | `33.01% <0.00%> (-0.32%)` | :arrow_down: |
| [...ache/dolphinscheduler/common/enums/StateEvent.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1N0YXRlRXZlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/dolphinscheduler/common/utils/OSUtils.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL09TVXRpbHMuamF2YQ==) | `34.14% <0.00%> (ø)` | |
| [...ver/master/consumer/TaskPriorityQueueConsumer.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9jb25zdW1lci9UYXNrUHJpb3JpdHlRdWV1ZUNvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...r/server/master/runner/MasterSchedulerService.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyU2NoZWR1bGVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../server/master/runner/StateWheelExecuteThread.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvU3RhdGVXaGVlbEV4ZWN1dGVUaHJlYWQuamF2YQ==) | `0.47% <0.00%> (ø)` | |
| [.../server/master/runner/WorkflowExecuteRunnable.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvV29ya2Zsb3dFeGVjdXRlUnVubmFibGUuamF2YQ==) | `7.68% <0.00%> (-0.01%)` | :arrow_down: |
| [...erver/master/runner/WorkflowExecuteThreadPool.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvV29ya2Zsb3dFeGVjdXRlVGhyZWFkUG9vbC5qYXZh) | `1.36% <0.00%> (+0.05%)` | :arrow_up: |
| [...ler/server/master/runner/task/TaskInstanceKey.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvdGFzay9UYXNrSW5zdGFuY2VLZXkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/dolphinscheduler/remote/command/Command.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvQ29tbWFuZC5qYXZh) | `60.60% <ø> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/dolphinscheduler/pull/10631/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10631?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10631?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6fc70c...f980a4a](https://codecov.io/gh/apache/dolphinscheduler/pull/10631?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org