You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/05 12:37:38 UTC
[GitHub] [flink] libenchao opened a new pull request #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
libenchao opened a new pull request #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pr fix FROM_BASE64 code gen result type.
## Brief change log
This pr fix FROM_BASE64 code gen result type.
## Verifying this change
This change added tests and can be verified as follows:
CalcITCase.testFromBase64
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#discussion_r363162293
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java
##########
@@ -1063,8 +1063,8 @@ public static String toBase64(byte[] bytes){
return Base64.getEncoder().encodeToString(bytes);
}
- public static byte[] fromBase64(BinaryString bs){
- return Base64.getDecoder().decode(bs.getBytes());
+ public static String fromBase64(BinaryString bs){
+ return new String(Base64.getDecoder().decode(bs.getBytes()));
Review comment:
We can not use `new String` directly, because we don't know the default coder must be UTF-8.
Maybe we can use `BinaryString.fromBytes`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570910721
<!--
Meta data
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:MANUAL TriggerID:570919575
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:MANUAL TriggerID:570919575
Hash:987d0db7ac663d1d0690954c902033db3b2c4d1c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143196454 TriggerType:PUSH TriggerID:987d0db7ac663d1d0690954c902033db3b2c4d1c
Hash:987d0db7ac663d1d0690954c902033db3b2c4d1c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4110 TriggerType:PUSH TriggerID:987d0db7ac663d1d0690954c902033db3b2c4d1c
-->
## CI report:
* c5e4ad343ca857112ee41b5b166c0a77186dfb78 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143140734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099)
* 987d0db7ac663d1d0690954c902033db3b2c4d1c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143196454) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4110)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570910721
<!--
Meta data
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
-->
## CI report:
* c5e4ad343ca857112ee41b5b166c0a77186dfb78 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143140734) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570910721
<!--
Meta data
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
-->
## CI report:
* c5e4ad343ca857112ee41b5b166c0a77186dfb78 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143140734) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570992704
Thanks @libenchao , left a comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570910721
<!--
Meta data
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:MANUAL TriggerID:570919575
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:MANUAL TriggerID:570919575
Hash:987d0db7ac663d1d0690954c902033db3b2c4d1c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143196454 TriggerType:PUSH TriggerID:987d0db7ac663d1d0690954c902033db3b2c4d1c
Hash:987d0db7ac663d1d0690954c902033db3b2c4d1c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4110 TriggerType:PUSH TriggerID:987d0db7ac663d1d0690954c902033db3b2c4d1c
Hash:022559152807fb01b9eceb066071486cc1a86064 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:022559152807fb01b9eceb066071486cc1a86064
-->
## CI report:
* c5e4ad343ca857112ee41b5b166c0a77186dfb78 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143140734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099)
* 987d0db7ac663d1d0690954c902033db3b2c4d1c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143196454) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4110)
* 022559152807fb01b9eceb066071486cc1a86064 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#discussion_r363186154
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java
##########
@@ -1063,8 +1063,8 @@ public static String toBase64(byte[] bytes){
return Base64.getEncoder().encodeToString(bytes);
}
- public static byte[] fromBase64(BinaryString bs){
- return Base64.getDecoder().decode(bs.getBytes());
+ public static String fromBase64(BinaryString bs){
+ return new String(Base64.getDecoder().decode(bs.getBytes()));
Review comment:
Yes, Using `BinaryString` is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570910721
<!--
Meta data
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:MANUAL TriggerID:570919575
-->
## CI report:
* c5e4ad343ca857112ee41b5b166c0a77186dfb78 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143140734) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-571456062
CC: @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570910721
<!--
Meta data
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
-->
## CI report:
* c5e4ad343ca857112ee41b5b166c0a77186dfb78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570910721
<!--
Meta data
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:MANUAL TriggerID:570919575
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:MANUAL TriggerID:570919575
Hash:987d0db7ac663d1d0690954c902033db3b2c4d1c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143196454 TriggerType:PUSH TriggerID:987d0db7ac663d1d0690954c902033db3b2c4d1c
Hash:987d0db7ac663d1d0690954c902033db3b2c4d1c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4110 TriggerType:PUSH TriggerID:987d0db7ac663d1d0690954c902033db3b2c4d1c
Hash:022559152807fb01b9eceb066071486cc1a86064 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4126 TriggerType:PUSH TriggerID:022559152807fb01b9eceb066071486cc1a86064
Hash:022559152807fb01b9eceb066071486cc1a86064 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143232242 TriggerType:PUSH TriggerID:022559152807fb01b9eceb066071486cc1a86064
-->
## CI report:
* c5e4ad343ca857112ee41b5b166c0a77186dfb78 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143140734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099)
* 987d0db7ac663d1d0690954c902033db3b2c4d1c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143196454) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4110)
* 022559152807fb01b9eceb066071486cc1a86064 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143232242) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4126)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570910721
<!--
Meta data
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:MANUAL TriggerID:570919575
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:MANUAL TriggerID:570919575
-->
## CI report:
* c5e4ad343ca857112ee41b5b166c0a77186dfb78 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143140734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#discussion_r363149820
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala
##########
@@ -260,4 +260,17 @@ class CalcITCase extends StreamingTestBase {
val expected = List("2,2,Hello", "3,2,Hello world")
assertEquals(expected.sorted, sink.getAppendResults.sorted)
}
+
+ @Test
+ def testFromBase64(): Unit = {
Review comment:
Can you add test in `ScalarFunctionsTest.testFromBase64` instead of it case?
Maybe you can add a nested function call to verify this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570910721
<!--
Meta data
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:MANUAL TriggerID:570919575
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:MANUAL TriggerID:570919575
Hash:987d0db7ac663d1d0690954c902033db3b2c4d1c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143196454 TriggerType:PUSH TriggerID:987d0db7ac663d1d0690954c902033db3b2c4d1c
Hash:987d0db7ac663d1d0690954c902033db3b2c4d1c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4110 TriggerType:PUSH TriggerID:987d0db7ac663d1d0690954c902033db3b2c4d1c
-->
## CI report:
* c5e4ad343ca857112ee41b5b166c0a77186dfb78 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143140734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099)
* 987d0db7ac663d1d0690954c902033db3b2c4d1c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143196454) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4110)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570910721
<!--
Meta data
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:MANUAL TriggerID:570919575
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:MANUAL TriggerID:570919575
-->
## CI report:
* c5e4ad343ca857112ee41b5b166c0a77186dfb78 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143140734) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570908693
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c5e4ad343ca857112ee41b5b166c0a77186dfb78 (Sun Jan 05 12:39:32 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15478).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570919575
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570910721
<!--
Meta data
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:MANUAL TriggerID:570919575
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:MANUAL TriggerID:570919575
Hash:987d0db7ac663d1d0690954c902033db3b2c4d1c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143196454 TriggerType:PUSH TriggerID:987d0db7ac663d1d0690954c902033db3b2c4d1c
Hash:987d0db7ac663d1d0690954c902033db3b2c4d1c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4110 TriggerType:PUSH TriggerID:987d0db7ac663d1d0690954c902033db3b2c4d1c
Hash:022559152807fb01b9eceb066071486cc1a86064 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4126 TriggerType:PUSH TriggerID:022559152807fb01b9eceb066071486cc1a86064
Hash:022559152807fb01b9eceb066071486cc1a86064 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143232242 TriggerType:PUSH TriggerID:022559152807fb01b9eceb066071486cc1a86064
-->
## CI report:
* c5e4ad343ca857112ee41b5b166c0a77186dfb78 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143140734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099)
* 987d0db7ac663d1d0690954c902033db3b2c4d1c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143196454) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4110)
* 022559152807fb01b9eceb066071486cc1a86064 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143232242) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4126)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#discussion_r363260737
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java
##########
@@ -1063,8 +1063,8 @@ public static String toBase64(byte[] bytes){
return Base64.getEncoder().encodeToString(bytes);
}
- public static byte[] fromBase64(BinaryString bs){
- return Base64.getDecoder().decode(bs.getBytes());
+ public static String fromBase64(BinaryString bs){
+ return new String(Base64.getDecoder().decode(bs.getBytes()));
Review comment:
Good idea. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#issuecomment-570910721
<!--
Meta data
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:PUSH TriggerID:c5e4ad343ca857112ee41b5b166c0a77186dfb78
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099 TriggerType:MANUAL TriggerID:570919575
Hash:c5e4ad343ca857112ee41b5b166c0a77186dfb78 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143140734 TriggerType:MANUAL TriggerID:570919575
Hash:987d0db7ac663d1d0690954c902033db3b2c4d1c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:987d0db7ac663d1d0690954c902033db3b2c4d1c
-->
## CI report:
* c5e4ad343ca857112ee41b5b166c0a77186dfb78 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143140734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4099)
* 987d0db7ac663d1d0690954c902033db3b2c4d1c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #10766:
[FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#discussion_r363157664
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala
##########
@@ -260,4 +260,17 @@ class CalcITCase extends StreamingTestBase {
val expected = List("2,2,Hello", "3,2,Hello world")
assertEquals(expected.sorted, sink.getAppendResults.sorted)
}
+
+ @Test
+ def testFromBase64(): Unit = {
Review comment:
It's a good idea. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services