You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/01/02 16:36:34 UTC

[GitHub] [hudi] nsivabalan commented on a change in pull request #2358: [MINOR] Add maven profile to support skipping shade sources jars

nsivabalan commented on a change in pull request #2358:
URL: https://github.com/apache/hudi/pull/2358#discussion_r550897807



##########
File path: pom.xml
##########
@@ -138,6 +138,7 @@
     <jacoco.version>0.8.5</jacoco.version>
     <presto.bundle.bootstrap.scope>compile</presto.bundle.bootstrap.scope>
     <presto.bundle.bootstrap.shade.prefix>org.apache.hudi.</presto.bundle.bootstrap.shade.prefix>
+    <shadeSources>true</shadeSources>

Review comment:
       is the indentation right? from the looks of it, does not look ok. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org