You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by Sagar Gandhi <ga...@live.com> on 2016/05/02 21:33:47 UTC
Review Request 46902: METAMODEL-159 : DataContextFactory misses
methods to create HBase and POJO data contexts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46902/
-----------------------------------------------------------
Review request for MetaModel.
Repository: metamodel
Description
-------
Bug Description :
Every DataContext implementation is represented in the DataContextFactory with a method for creating such DataContext. However, there are no methods for creating HBaseDataContext and PojoDataContext.
Solution :
Created methods for HBase and Pojo. Added different overloaded methods for overloaded constructors.
Diffs
-----
full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2
Diff: https://reviews.apache.org/r/46902/diff/
Testing
-------
Thanks,
Sagar Gandhi
Re: Review Request 46902: METAMODEL-159 : DataContextFactory misses
methods to create HBase and POJO data contexts
Posted by Tomasz Guzialek <to...@guzialek.info>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46902/#review131364
-----------------------------------------------------------
Ship it!
Ship It!
- Tomasz Guzialek
On May 2, 2016, 8:05 p.m., Sagar Gandhi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46902/
> -----------------------------------------------------------
>
> (Updated May 2, 2016, 8:05 p.m.)
>
>
> Review request for MetaModel.
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Bug Description :
> Every DataContext implementation is represented in the DataContextFactory with a method for creating such DataContext. However, there are no methods for creating HBaseDataContext and PojoDataContext.
>
> Solution :
> Created methods for HBase and Pojo. Added different overloaded methods for overloaded constructors.
>
>
> Diffs
> -----
>
> full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2
>
> Diff: https://reviews.apache.org/r/46902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sagar Gandhi
>
>
Re: Review Request 46902: METAMODEL-159 : DataContextFactory misses
methods to create HBase and POJO data contexts
Posted by Tomasz Guziałek <to...@guzialek.info>.
Hi Sagar,
Now a committer needs to take the patch and apply it on master. I will take
it from here. Thanks for your contribution!
Pozdrawiam / Regards / Med venlig hilsen
Tomasz Guziałek
2016-05-02 22:16 GMT+02:00 Sagar Gandhi <ga...@live.com>:
> Hi Tomasz,
>
> can you please guide me how to proceed for check-in ? . I am not a
> committer, what are the steps I need to perform to help committer check-in
> this patch ?
>
>
> Thanks ,
> Mr.Sagar Gandhi,
> Pune.
> (+91)9028440503
>
>
> > Subject: Re: Review Request 46902: METAMODEL-159 : DataContextFactory
> misses methods to create HBase and POJO data contexts
> > From: gandhi.sagar@live.com
> > To: gandhi.sagar@live.com; tomasz@guzialek.info;
> dev@metamodel.apache.org
> > Date: Mon, 2 May 2016 20:13:37 +0000
>
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/46902/
> > -----------------------------------------------------------
> >
> > (Updated May 2, 2016, 8:13 p.m.)
> >
> >
> > Review request for MetaModel.
> >
> >
> > Changes
> > -------
> >
> > Technical error viewing diff 3
> >
> >
> > Repository: metamodel
> >
> >
> > Description
> > -------
> >
> > Bug Description :
> > Every DataContext implementation is represented in the
> DataContextFactory with a method for creating such DataContext. However,
> there are no methods for creating HBaseDataContext and PojoDataContext.
> >
> > Solution :
> > Created methods for HBase and Pojo. Added different overloaded methods
> for overloaded constructors.
> >
> >
> > Diffs (updated)
> > -----
> >
> > full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2
> >
> > Diff: https://reviews.apache.org/r/46902/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Sagar Gandhi
> >
>
RE: Review Request 46902: METAMODEL-159 : DataContextFactory misses
methods to create HBase and POJO data contexts
Posted by Sagar Gandhi <ga...@live.com>.
Hi Tomasz,
can you please guide me how to proceed for check-in ? . I am not a committer, what are the steps I need to perform to help committer check-in this patch ?
Thanks ,
Mr.Sagar Gandhi,
Pune.
(+91)9028440503
> Subject: Re: Review Request 46902: METAMODEL-159 : DataContextFactory misses methods to create HBase and POJO data contexts
> From: gandhi.sagar@live.com
> To: gandhi.sagar@live.com; tomasz@guzialek.info; dev@metamodel.apache.org
> Date: Mon, 2 May 2016 20:13:37 +0000
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46902/
> -----------------------------------------------------------
>
> (Updated May 2, 2016, 8:13 p.m.)
>
>
> Review request for MetaModel.
>
>
> Changes
> -------
>
> Technical error viewing diff 3
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Bug Description :
> Every DataContext implementation is represented in the DataContextFactory with a method for creating such DataContext. However, there are no methods for creating HBaseDataContext and PojoDataContext.
>
> Solution :
> Created methods for HBase and Pojo. Added different overloaded methods for overloaded constructors.
>
>
> Diffs (updated)
> -----
>
> full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2
>
> Diff: https://reviews.apache.org/r/46902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sagar Gandhi
>
Re: Review Request 46902: METAMODEL-159 : DataContextFactory misses
methods to create HBase and POJO data contexts
Posted by Sagar Gandhi <ga...@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46902/
-----------------------------------------------------------
(Updated May 2, 2016, 8:13 p.m.)
Review request for MetaModel.
Changes
-------
Technical error viewing diff 3
Repository: metamodel
Description
-------
Bug Description :
Every DataContext implementation is represented in the DataContextFactory with a method for creating such DataContext. However, there are no methods for creating HBaseDataContext and PojoDataContext.
Solution :
Created methods for HBase and Pojo. Added different overloaded methods for overloaded constructors.
Diffs (updated)
-----
full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2
Diff: https://reviews.apache.org/r/46902/diff/
Testing
-------
Thanks,
Sagar Gandhi
Re: Review Request 46902: METAMODEL-159 : DataContextFactory misses
methods to create HBase and POJO data contexts
Posted by Sagar Gandhi <ga...@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46902/
-----------------------------------------------------------
(Updated May 2, 2016, 8:05 p.m.)
Review request for MetaModel.
Changes
-------
Added changed suggested by Tomasz Guzialek
Repository: metamodel
Description
-------
Bug Description :
Every DataContext implementation is represented in the DataContextFactory with a method for creating such DataContext. However, there are no methods for creating HBaseDataContext and PojoDataContext.
Solution :
Created methods for HBase and Pojo. Added different overloaded methods for overloaded constructors.
Diffs (updated)
-----
full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2
Diff: https://reviews.apache.org/r/46902/diff/
Testing
-------
Thanks,
Sagar Gandhi
Re: Review Request 46902: METAMODEL-159 : DataContextFactory misses
methods to create HBase and POJO data contexts
Posted by Sagar Gandhi <ga...@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46902/
-----------------------------------------------------------
(Updated May 2, 2016, 8 p.m.)
Review request for MetaModel.
Repository: metamodel
Description
-------
Bug Description :
Every DataContext implementation is represented in the DataContextFactory with a method for creating such DataContext. However, there are no methods for creating HBaseDataContext and PojoDataContext.
Solution :
Created methods for HBase and Pojo. Added different overloaded methods for overloaded constructors.
Diffs (updated)
-----
full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2
Diff: https://reviews.apache.org/r/46902/diff/
Testing
-------
Thanks,
Sagar Gandhi
Re: Review Request 46902: METAMODEL-159 : DataContextFactory misses
methods to create HBase and POJO data contexts
Posted by Sagar Gandhi <ga...@live.com>.
> On May 2, 2016, 7:51 p.m., Tomasz Guzialek wrote:
> > full/src/main/java/org/apache/metamodel/DataContextFactory.java, line 765
> > <https://reviews.apache.org/r/46902/diff/1/?file=1369020#file1369020line765>
> >
> > Shouldn't that be a "List<TableDataProvider<?>> tables" as parameter?
Pojo data context have 2 constructors , one with List<TableDataProvider<?>> tables and other with TableDataProvider... tableProviders. for List<TableDataProvider<?>> parameterized constructor , We have already added a method. for TableDataProvider... tableProviders we have changed it to array instead of list.
Thanks for pointing it out. New diff is added. Please review it.
- Sagar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46902/#review131361
-----------------------------------------------------------
On May 2, 2016, 8:05 p.m., Sagar Gandhi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46902/
> -----------------------------------------------------------
>
> (Updated May 2, 2016, 8:05 p.m.)
>
>
> Review request for MetaModel.
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Bug Description :
> Every DataContext implementation is represented in the DataContextFactory with a method for creating such DataContext. However, there are no methods for creating HBaseDataContext and PojoDataContext.
>
> Solution :
> Created methods for HBase and Pojo. Added different overloaded methods for overloaded constructors.
>
>
> Diffs
> -----
>
> full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2
>
> Diff: https://reviews.apache.org/r/46902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sagar Gandhi
>
>
Re: Review Request 46902: METAMODEL-159 : DataContextFactory misses
methods to create HBase and POJO data contexts
Posted by Tomasz Guzialek <to...@guzialek.info>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46902/#review131361
-----------------------------------------------------------
Looks good to me, but see a single comment.
full/src/main/java/org/apache/metamodel/DataContextFactory.java (line 765)
<https://reviews.apache.org/r/46902/#comment195292>
Shouldn't that be a "List<TableDataProvider<?>> tables" as parameter?
- Tomasz Guzialek
On May 2, 2016, 7:33 p.m., Sagar Gandhi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46902/
> -----------------------------------------------------------
>
> (Updated May 2, 2016, 7:33 p.m.)
>
>
> Review request for MetaModel.
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Bug Description :
> Every DataContext implementation is represented in the DataContextFactory with a method for creating such DataContext. However, there are no methods for creating HBaseDataContext and PojoDataContext.
>
> Solution :
> Created methods for HBase and Pojo. Added different overloaded methods for overloaded constructors.
>
>
> Diffs
> -----
>
> full/src/main/java/org/apache/metamodel/DataContextFactory.java 2b3dae2
>
> Diff: https://reviews.apache.org/r/46902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sagar Gandhi
>
>