You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pe...@apache.org on 2026/08/23 19:23:30 UTC
(wicket) branch wicket-10.x updated: Better javadoc for deprecated methods and type in CSP package
This is an automated email from the ASF dual-hosted git repository.
pedrosans pushed a commit to branch wicket-10.x
in repository https://gitbox.apache.org/repos/asf/wicket.git
The following commit(s) were added to refs/heads/wicket-10.x by this push:
new 2b094777f9 Better javadoc for deprecated methods and type in CSP package
2b094777f9 is described below
commit 2b094777f906c45072ba71227c356bf402484929
Author: Pedro Santos <pe...@gmail.com>
AuthorDate: Sun Aug 23 16:23:19 2026 -0300
Better javadoc for deprecated methods and type in CSP package
---
.../org/apache/wicket/csp/CSPRequestCycleListener.java | 6 +++++-
.../apache/wicket/csp/ContentSecurityPolicySettings.java | 14 +++++++++++---
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/wicket-core/src/main/java/org/apache/wicket/csp/CSPRequestCycleListener.java b/wicket-core/src/main/java/org/apache/wicket/csp/CSPRequestCycleListener.java
index 7c7ec9ac13..c8fe154c36 100644
--- a/wicket-core/src/main/java/org/apache/wicket/csp/CSPRequestCycleListener.java
+++ b/wicket-core/src/main/java/org/apache/wicket/csp/CSPRequestCycleListener.java
@@ -32,8 +32,12 @@ import static org.apache.wicket.request.IRequestHandlerDelegate.unwrap;
* @author Sven Haster
* @author Emond Papegaaij
* @see CSPHeaderWriter
- * @deprecated
+ *
+ * @deprecated Pages write their own CSP headers, see
+ * {@link org.apache.wicket.markup.html.WebPage#configureResponse}. This listener only
+ * protects the remaining request handlers and will be removed.
*/
+@Deprecated(since = "10.11.0", forRemoval = true)
public class CSPRequestCycleListener implements IRequestCycleListener
{
private final ContentSecurityPolicySettings settings;
diff --git a/wicket-core/src/main/java/org/apache/wicket/csp/ContentSecurityPolicySettings.java b/wicket-core/src/main/java/org/apache/wicket/csp/ContentSecurityPolicySettings.java
index 2cebf9ed7a..1375d932cc 100644
--- a/wicket-core/src/main/java/org/apache/wicket/csp/ContentSecurityPolicySettings.java
+++ b/wicket-core/src/main/java/org/apache/wicket/csp/ContentSecurityPolicySettings.java
@@ -127,9 +127,14 @@ public class ContentSecurityPolicySettings
* The new filter, must not be null.
* @return {@code this} for chaining.
*
- * @deprecated
* @see org.apache.wicket.markup.html.WebPage#configureResponse
+ *
+ * @deprecated Pages are now protected while they configure their response, see
+ * {@link org.apache.wicket.markup.html.WebPage#configureResponse}. This handler
+ * based filter will be replaced by a {@code Predicate<WebPage>} testing the page
+ * being rendered.
*/
+ @Deprecated(since = "10.11.0", forRemoval = true)
public ContentSecurityPolicySettings setProtectedFilter(
Predicate<IRequestHandler> protectedFilter)
{
@@ -145,10 +150,13 @@ public class ContentSecurityPolicySettings
* @return <code>true</code> by default for all {@link RenderPageRequestHandler}s
*
* @see #setProtectedFilter(Predicate)
- *
- * @deprecated
* @see org.apache.wicket.markup.html.WebPage#configureResponse
+ *
+ * @deprecated Pages are now protected while they configure their response, see
+ * {@link org.apache.wicket.markup.html.WebPage#configureResponse}. This check will
+ * be replaced by one that receives the {@code WebPage} being rendered.
*/
+ @Deprecated(since = "10.11.0", forRemoval = true)
protected boolean mustProtectRequest(IRequestHandler handler)
{
return protectedFilter.test(unwrap(handler));