You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2021/03/11 14:05:32 UTC
[GitHub] [bigtop] elukey opened a new pull request #754: bigtop-deploy: replace hiera() with lookup
elukey opened a new pull request #754:
URL: https://github.com/apache/bigtop/pull/754
I noticed the following while trying to run the docker provisioner:
Warning: The function 'hiera' is deprecated in favor of using 'lookup'.
See https://puppet.com/docs/puppet/5.5/deprecated_language.html
I know that we need to keep compatibility with older OSes, but with Bigtop 3.x we may be able to have a more up to date puppet version available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #754: bigtop-deploy: replace hiera() with lookup
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #754:
URL: https://github.com/apache/bigtop/pull/754#issuecomment-796812537
I got following error on CentOS 7 with the patch. Could you take a look? Puppet 3.6.2 was install on CentOS 7 by bigtop_toolchain/bin/puppetize.sh.
```
$ ./docker-hadoop.sh --create 1 --image bigtop/puppet:trunk-centos-7 --memory 16g --repo file:///bigtop-home/output --disable-gpg-check --stack hdfs,mapreduce,yarn
...
Error: Function lookup() did not find a value for the name 'bigtop::jdk_preinstalled' on node 8ae2b15d58b0.bigtop.apache.org
Error: Function lookup() did not find a value for the name 'bigtop::jdk_preinstalled' on node 8ae2b15d58b0.bigtop.apache.org
$ ./docker-hadoop.sh --exec 1 puppet --version
3.6.2
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey closed pull request #754: (BIGTOP-3525) Replace hiera() with lookup()
Posted by GitBox <gi...@apache.org>.
elukey closed pull request #754:
URL: https://github.com/apache/bigtop/pull/754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #754: bigtop-deploy: replace hiera() with lookup
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #754:
URL: https://github.com/apache/bigtop/pull/754#issuecomment-796831598
> @elukey Could you file a JIRA issue and put the id (BIGTOP-xxxx) on the title of this PR?
> https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
Definitely: BIGTOP-3525
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #754: (BIGTOP-3525) Replace hiera() with lookup()
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #754:
URL: https://github.com/apache/bigtop/pull/754#issuecomment-797321967
With a more fresh mind, Debian 10 installs puppet 5.5, so lookup in there is probably different and not comparable. It seems as if the lookup in puppet 3.6.2 doesn't really accept the default_value, ending up in not finding anything.
Debian 9 has also different problems (with puppet 4), see:
```
Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Lookup of key 'hadoop::kerberos_realm' failed: DataBinding 'hiera': Invalid interpolation method 'lookup' at /bigtop-home/bigtop-deploy/puppet/modules/hadoop/manifests/init.pp:35:7 at /bigtop-home/bigtop-deploy/puppet/manifests/cluster.pp:230 on node b27e057e3765.bigtop.apache.org
```
Will try to see if anything can be done, but maybe it is a task too difficult for the broad range of OSes supported, not sure :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #754: bigtop-deploy: replace hiera() with lookup
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #754:
URL: https://github.com/apache/bigtop/pull/754#issuecomment-796832209
> I got following error on CentOS 7 with the patch. Could you take a look? Puppet 3.6.2 was install on CentOS 7 by bigtop_toolchain/bin/puppetize.sh.
>
> ```
> $ ./docker-hadoop.sh --create 1 --image bigtop/puppet:trunk-centos-7 --memory 16g --repo file:///bigtop-home/output --disable-gpg-check --stack hdfs,mapreduce,yarn
> ...
> Error: Function lookup() did not find a value for the name 'bigtop::jdk_preinstalled' on node 8ae2b15d58b0.bigtop.apache.org
> Error: Function lookup() did not find a value for the name 'bigtop::jdk_preinstalled' on node 8ae2b15d58b0.bigtop.apache.org
>
> $ ./docker-hadoop.sh --exec 1 puppet --version
> 3.6.2
> ```
This is very strange, I can repro (but not on Debian 10). In theory bigtop::jdk_preinstalled has a default "false", no idea why it yields this error, will keep checking!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #754: (BIGTOP-3525) Replace hiera() with lookup()
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #754:
URL: https://github.com/apache/bigtop/pull/754#issuecomment-798684616
I am going to discard this there were a lot of efforts to migrate to puppet 5.x but we decided to avoid it:
https://issues.apache.org/jira/browse/BIGTOP-3161
https://lists.apache.org/thread.html/26e14cf36e9cfd61e0de581ed83bf305565c2e65234f1ce3bfb97628@%3Cdev.bigtop.apache.org%3E
I hoped to be able to move to lookup but the function varies too much from puppet 3 to 5, and adding a ton of conditionals in the code to support both seems only polluting the code with no benefit..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #754: bigtop-deploy: replace hiera() with lookup
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #754:
URL: https://github.com/apache/bigtop/pull/754#issuecomment-796809762
@elukey Could you file a JIRA issue and put the id (BIGTOP-xxxx) on the title of this PR?
https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org