You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/20 16:53:38 UTC

[GitHub] [tvm] yelite opened a new pull request, #13816: Extend the USE_LIBBACKTRACE option

yelite opened a new pull request, #13816:
URL: https://github.com/apache/tvm/pull/13816

   This PR extends the value accepted by USE_LIBBACKTRACE cmake variable. It adds ability to search pre-compile libbacktrace from system path or user-provided path. The behavior of this variable after this PR will be:
   - OFF: Don't use libbacktrace
   - ON: Find libbacktrace from system paths. Fail the build generation if libbacktrace is not found.
   - COMPILE: Build and link to libbacktrace from 3rdparty/libbacktrace. 
   - <PATH>: Looking for the libbacktrace header and static lib from a user-provided path. Fail the build generation if libbacktrace is not found.
   - AUTO: 
     - Find libbacktrace from system paths.
     - If not found, fallback to COMPILE on Linux or MacOS, fallback to OFF on Windows.
   
   cc @junrushao 
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13816: Extend the USE_LIBBACKTRACE option

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13816:
URL: https://github.com/apache/tvm/pull/13816#issuecomment-1398661120

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to auto-tag found, no teams are specified in PR title <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] yelite commented on a diff in pull request #13816: Extend the USE_LIBBACKTRACE option

Posted by "yelite (via GitHub)" <gi...@apache.org>.
yelite commented on code in PR #13816:
URL: https://github.com/apache/tvm/pull/13816#discussion_r1092033360


##########
tests/scripts/task_config_build_cpu.sh:
##########
@@ -54,7 +54,7 @@ echo set\(USE_ETHOSN_HW OFF\) >> config.cmake
 echo set\(USE_CMSISNN OFF\) >> config.cmake
 echo set\(USE_VITIS_AI ON\) >> config.cmake
 echo set\(USE_VERILATOR ON\) >> config.cmake
-echo set\(USE_LIBBACKTRACE ON\) >> config.cmake
+echo set\(USE_LIBBACKTRACE COMPILE\) >> config.cmake

Review Comment:
   It's updated. Also removed the comments from Logging.cmake to avoid duplication.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao commented on pull request #13816: Extend the USE_LIBBACKTRACE option

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #13816:
URL: https://github.com/apache/tvm/pull/13816#issuecomment-1409850077

   CC: @Hzfengsy 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Hzfengsy commented on a diff in pull request #13816: Extend the USE_LIBBACKTRACE option

Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on code in PR #13816:
URL: https://github.com/apache/tvm/pull/13816#discussion_r1091526640


##########
tests/scripts/task_config_build_cpu.sh:
##########
@@ -54,7 +54,7 @@ echo set\(USE_ETHOSN_HW OFF\) >> config.cmake
 echo set\(USE_CMSISNN OFF\) >> config.cmake
 echo set\(USE_VITIS_AI ON\) >> config.cmake
 echo set\(USE_VERILATOR ON\) >> config.cmake
-echo set\(USE_LIBBACKTRACE ON\) >> config.cmake
+echo set\(USE_LIBBACKTRACE COMPILE\) >> config.cmake

Review Comment:
   Could you please update the comments in `config.cmake`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao merged pull request #13816: Extend the USE_LIBBACKTRACE option

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #13816:
URL: https://github.com/apache/tvm/pull/13816


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org