You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/06/30 19:28:49 UTC
[I] Deduplicate Sklearn classifier and training operator descriptors via a shared base [texera]
Ma77Ball opened a new issue, #6038:
URL: https://github.com/apache/texera/issues/6038
### Task Summary
`SklearnClassifierOpDesc` and `SklearnTrainingOpDesc` independently declare the same four configuration fields (`target`, `countVectorizer`, `text`, `tfidfTransformer`) with identical Jackson/JSON-schema annotations, plus a byte-identical `getOutputSchemas`. This is roughly 50 lines of copy-pasted code that can drift between the two classes. Extract the shared fields, the `@JsonIgnore` model-name/import hooks, and `getOutputSchemas` into a single abstract base class so each descriptor keeps only what genuinely differs (its `generatePythonCode` and `operatorInfo`). The 51 leaf subclasses already inherit these fields, so the generated operator schema is unchanged.
### Task Type
- [x] Refactoring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Deduplicate Sklearn classifier and training operator descriptors via a shared base [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #6038: Deduplicate Sklearn classifier and training operator descriptors via a shared base
URL: https://github.com/apache/texera/issues/6038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Deduplicate Sklearn classifier and training operator descriptors via a shared base [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6038:
URL: https://github.com/apache/texera/issues/6038#issuecomment-4847223508
<!-- texera:template-compliance -->
👋 Thanks for opening this issue, @Ma77Ball!
It looks like the issue description doesn't quite follow our template yet:
- This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org