You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by James Peach <jo...@gmail.com> on 2016/04/07 18:29:36 UTC
Re: [02/11] mesos git commit: Added support for contender and detector modules.
> On Apr 6, 2016, at 3:48 PM, kapil@apache.org wrote:
>
> Added support for contender and detector modules.
>
>
> http://git-wip-us.apache.org/repos/asf/mesos/blob/cbbc8f0b/src/tests/module.cpp
> ----------------------------------------------------------------------
> diff --git a/src/tests/module.cpp b/src/tests/module.cpp
> index 8cc305c..4b24048 100644
> --- a/src/tests/module.cpp
> +++ b/src/tests/module.cpp
> @@ -222,6 +222,52 @@ static void addHttpAuthenticatorModules(Modules* modules)
> }
>
>
> +static void addMasterContenderModules(Modules* modules)
> +{
> + CHECK_NOTNULL(modules);
> +
> + const string libraryPath = path::join(
> + tests::flags.build_dir,
> + "src",
> + ".libs",
> + os::libraries::expandName("testmastercontender"));
mesos::internal::tests::getModulePath("testmastercontender");
Re: [02/11] mesos git commit: Added support for contender and
detector modules.
Posted by Shuai Lin <li...@gmail.com>.
Hi Kapil, I created a JIRA about improving the test cpp framework to be
able to load detectors from modules, to make it easier for writing script
tests for the etcd contender/dector module I'm working on. Actually it
could benefit any contender/detector module developer. Do you think it make
sense?
https://issues.apache.org/jira/browse/MESOS-5106
On Fri, Apr 8, 2016 at 12:40 AM, Kapil Arya <ka...@mesosphere.io> wrote:
> Already posted a RR https://reviews.apache.org/r/45876/ :)
>
> On Thu, Apr 7, 2016 at 12:29 PM, James Peach <jo...@gmail.com> wrote:
>
> >
> > > On Apr 6, 2016, at 3:48 PM, kapil@apache.org wrote:
> > >
> > > Added support for contender and detector modules.
> > >
> > >
> > >
> >
> http://git-wip-us.apache.org/repos/asf/mesos/blob/cbbc8f0b/src/tests/module.cpp
> > > ----------------------------------------------------------------------
> > > diff --git a/src/tests/module.cpp b/src/tests/module.cpp
> > > index 8cc305c..4b24048 100644
> > > --- a/src/tests/module.cpp
> > > +++ b/src/tests/module.cpp
> > > @@ -222,6 +222,52 @@ static void addHttpAuthenticatorModules(Modules*
> > modules)
> > > }
> > >
> > >
> > > +static void addMasterContenderModules(Modules* modules)
> > > +{
> > > + CHECK_NOTNULL(modules);
> > > +
> > > + const string libraryPath = path::join(
> > > + tests::flags.build_dir,
> > > + "src",
> > > + ".libs",
> > > + os::libraries::expandName("testmastercontender"));
> >
> > mesos::internal::tests::getModulePath("testmastercontender");
> >
> >
>
Re: [02/11] mesos git commit: Added support for contender and
detector modules.
Posted by Kapil Arya <ka...@mesosphere.io>.
Already posted a RR https://reviews.apache.org/r/45876/ :)
On Thu, Apr 7, 2016 at 12:29 PM, James Peach <jo...@gmail.com> wrote:
>
> > On Apr 6, 2016, at 3:48 PM, kapil@apache.org wrote:
> >
> > Added support for contender and detector modules.
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/mesos/blob/cbbc8f0b/src/tests/module.cpp
> > ----------------------------------------------------------------------
> > diff --git a/src/tests/module.cpp b/src/tests/module.cpp
> > index 8cc305c..4b24048 100644
> > --- a/src/tests/module.cpp
> > +++ b/src/tests/module.cpp
> > @@ -222,6 +222,52 @@ static void addHttpAuthenticatorModules(Modules*
> modules)
> > }
> >
> >
> > +static void addMasterContenderModules(Modules* modules)
> > +{
> > + CHECK_NOTNULL(modules);
> > +
> > + const string libraryPath = path::join(
> > + tests::flags.build_dir,
> > + "src",
> > + ".libs",
> > + os::libraries::expandName("testmastercontender"));
>
> mesos::internal::tests::getModulePath("testmastercontender");
>
>