[jira] [Resolved] (HTTPCLIENT-1888) NullPointerException in SystemDefaultCredentialsProvider.getCredentials when AuthScope.orgin is null

["Oleg Kalnichevski (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-1888.
-------------------------------------------
       Resolution: Fixed
    Fix Version/s: 4.6 Alpha1
                   4.5.5

Fixed in 4.5.x and 4.6.x. 5.x was not affected.

Please review / re-test and close.

Oleg

> NullPointerException in SystemDefaultCredentialsProvider.getCredentials when AuthScope.orgin is null
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1888
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1888
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.5.4
>            Reporter: Collin Peters
>            Priority: Critical
>             Fix For: 4.5.5, 4.6 Alpha1
>
>
> 4.5.4 has the following line in [SystemDefaultCredentialsProvider|https://github.com/apache/httpcomponents-client/blob/4.5.4/httpclient/src/main/java/org/apache/http/impl/client/SystemDefaultCredentialsProvider.java#L114]
>  {code}
>  final String protocol = origin != null ? origin.getSchemeName() : (origin.getPort() == 443 ? "https" : "http");
> {code}
> So 'origin' is still accessed when it is determined that it is null.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org