You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by an...@apache.org on 2021/06/09 08:08:24 UTC

[sling-org-apache-sling-feature-cpconverter] branch SLING-10474 created (now f360589)

This is an automated email from the ASF dual-hosted git repository.

angela pushed a change to branch SLING-10474
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-feature-cpconverter.git.


      at f360589  SLING-10474 : Confusing local variable name in AbstractPolicyEntryHandler

This branch includes the following new commits:

     new f360589  SLING-10474 : Confusing local variable name in AbstractPolicyEntryHandler

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


[sling-org-apache-sling-feature-cpconverter] 01/01: SLING-10474 : Confusing local variable name in AbstractPolicyEntryHandler

Posted by an...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

angela pushed a commit to branch SLING-10474
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-feature-cpconverter.git

commit f36058959e443b0ae4d1dd4e78168ce4ec429bb9
Author: angela <an...@adobe.com>
AuthorDate: Wed Jun 9 10:08:05 2021 +0200

    SLING-10474 : Confusing local variable name in AbstractPolicyEntryHandler
---
 .../feature/cpconverter/handlers/AbstractPolicyEntryHandler.java   | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/sling/feature/cpconverter/handlers/AbstractPolicyEntryHandler.java b/src/main/java/org/apache/sling/feature/cpconverter/handlers/AbstractPolicyEntryHandler.java
index 8b27527..b94f6d2 100644
--- a/src/main/java/org/apache/sling/feature/cpconverter/handlers/AbstractPolicyEntryHandler.java
+++ b/src/main/java/org/apache/sling/feature/cpconverter/handlers/AbstractPolicyEntryHandler.java
@@ -36,7 +36,7 @@ import java.io.StringReader;
 import java.io.StringWriter;
 import java.util.regex.Matcher;
 
-abstract class AbstractPolicyEntryHandler  extends AbstractRegexEntryHandler {
+abstract class AbstractPolicyEntryHandler extends AbstractRegexEntryHandler {
 
     private final SAXTransformerFactory saxTransformerFactory = (SAXTransformerFactory) TransformerFactory.newInstance();
 
@@ -67,13 +67,12 @@ abstract class AbstractPolicyEntryHandler  extends AbstractRegexEntryHandler {
         StringWriter stringWriter = new StringWriter();
         handler.setResult(new StreamResult(stringWriter));
 
-        AbstractPolicyParser systemUserParser = createPolicyParser(new RepoPath(PlatformNameFormat.getRepositoryPath(resourcePath)),
+        AbstractPolicyParser policyParser = createPolicyParser(new RepoPath(PlatformNameFormat.getRepositoryPath(resourcePath)),
                 converter.getAclManager(),
                 handler);
         boolean hasRejectedAcls;
-
         try (InputStream input = archive.openInputStream(entry)) {
-            hasRejectedAcls = systemUserParser.parse(input);
+            hasRejectedAcls = policyParser.parse(input);
         }
 
         if (hasRejectedAcls) {