[GitHub] [wicket] hosea commented on pull request #564: WICKET-7036: MarkupFactory supports IMarkupFilters

["hosea (via GitHub)" <gi...@apache.org>]

hosea commented on PR #564:
URL: https://github.com/apache/wicket/pull/564#issuecomment-1485306655

   Hi @theigl , @martin-g ,
   
   I agree with you, that one could easily extend MarkupFactory and achieve the requirement. That's in fact, what we do now. I just want to explain, why it would be helpful to have such extensions:
   I have about 20 Wicket-Applications developed by several teams sharing several libraries of wicket-components. These "central" libraries use IInitializers. So the code #Application.getMarkupSettings().setMarkupFactory(new AriaAwareMarkupFactory()) is now located in one of the libraries. But if I want to add processing of MarkupFilters in another library, then I cannot use this initialization-code anymore: two Initializers setting a new MarkupFacatory => only one wins and the other functionality is lost. This means, that all 20 Applications have to implement a new MarkupFactory that implements both functionalities, or I have to add a dependency between libraries. Both solutions are not nice.
   Adding to possibility to add IMarkupFilters without replacing the instance of the MarkupFactory makes initialization much easier in such a case. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org