Re: Review Request 17720: OOZIE-1678 HA support for SLA

[Rohini Palaniswamy <ro...@gmail.com>]

> On May 19, 2014, 10:44 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java, line 413
> > <https://reviews.apache.org/r/17720/diff/10/?file=583836#file583836line413>
> >
> >     throw new UnSupportedOperationException(). 
> >     
> >     Add this method to QueryExecutor itself and remove empty overriding in each class.

Comment not addressed. Please mark issues as resolved or dropped. This will help track addressed review comments.


- Rohini


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17720/#review43431
-----------------------------------------------------------


On May 31, 2014, 12:26 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17720/
> -----------------------------------------------------------
> 
> (Updated May 31, 2014, 12:26 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1678
>     https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1678
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java ea7df17 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java d2331e8 
>   core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 319aea0 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java f5304ca 
>   core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1a6ded7 
>   core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java 536743b 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java e3b115f 
>   core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java 79d11ed 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 9156a27 
>   core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java e7d42e9 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetJPAExecutor.java 7b4e177 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLARegistrationGetOnRestartJPAExecutor.java 1510daf 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetJPAExecutor.java 1f7cb4d 
>   core/src/main/java/org/apache/oozie/service/JPAService.java 1b8f53e 
>   core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java 27c97e6 
>   core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java 611b74c 
>   core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java ea53712 
>   core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 618d899 
>   core/src/main/java/org/apache/oozie/sla/SLAOperations.java b0da3dc 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 0a70326 
>   core/src/main/java/org/apache/oozie/sla/service/SLAService.java 7fcb334 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java bc24235 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java 00fb677 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java 2e170a4 
>   core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java ea36720 
>   core/src/test/java/org/apache/oozie/service/TestHASLAService.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java 9270aa2 
>   core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java 9a16722 
>   core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java cb4e434 
>   core/src/test/java/org/apache/oozie/sla/TestSLAJobEventListener.java 3ce86ab 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java 40376a5 
>   core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java cd2fbae 
>   core/src/test/java/org/apache/oozie/sla/TestSLAService.java 291d850 
>   core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java 3a9e72e 
>   core/src/test/java/org/apache/oozie/test/ZKXTestCase.java 7bebaf0 
>   core/src/test/resources/coord-action-sla.xml 4893c61 
> 
> Diff: https://reviews.apache.org/r/17720/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>