You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/05 16:42:20 UTC
[jira] [Commented] (IGNITE-3828) Data streamer: use identity
comparison for "activeKeys" in DataStreamerImpl.load0 method.
[ https://issues.apache.org/jira/browse/IGNITE-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465381#comment-15465381 ]
ASF GitHub Bot commented on IGNITE-3828:
----------------------------------------
GitHub user AMashenkov opened a pull request:
https://github.com/apache/ignite/pull/1034
IGNITE-3828: Data streamer: use identity comparison for "activeKeys" in DataStreamerImpl.load0 method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-3828
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1034.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1034
----
commit f175d3c670025bd619ec347dba2a5c5f68f4cc32
Author: Vladislav Pyatkov <vl...@gmail.com>
Date: 2016-06-02T13:14:10Z
IGNITE-2655: AffinityFunction: primary and backup copies in different locations
Reviewed and merged by Denis Magda (dmagda@gridgain.com)
commit 1da14369c886ed12dbe0fc9b2c4d5a568c76b6b2
Author: Anton Vinogradov <av...@apache.org>
Date: 2016-06-02T14:02:09Z
IGNITE-3183 ScanQuery and localEntries are ignored keepBinary flag in OFFHEAP_TIERED mode
commit e0cf0fcc954a39dad5b0f1969488a7b372ef8f94
Author: Ignite Teamcity <ig...@apache.org>
Date: 2016-06-02T16:16:31Z
1.7.0-SNAPSHOT
commit 91862c7c05bd37e287df1b2b6fb00e5cd2cfbb71
Author: MaBiao <ma...@gmail.com>
Date: 2016-06-03T08:55:14Z
IGNITE-3229: fixing link in Class GridCacheStoreValueBytesSelfTest. This closes #770.
commit 9df1b905cd86384c1d191785d70a8e5c8e741e48
Author: Valentin Kulichenko <va...@gmail.com>
Date: 2016-06-02T13:03:12Z
IGNITE-3232 - Inline transformers for IgniteRDD.savePairs and IgniteRDD.saveValues
commit 7fc1a7f8ecba07869f8706091f076079dd83cb8e
Author: Alexey Goncharuk <al...@gmail.com>
Date: 2016-06-02T19:52:39Z
IGNITE-3232 - Fixed the number of iterations to find an affinity key.
commit 2485d86f63bb2149e8881d3f48c13fb7784c29b0
Author: tledkov-gridgain <tl...@gridgain.com>
Date: 2016-06-02T13:56:20Z
IGNITE-3175 BigDecimal fields are not supported if query is executed from IgniteRDD: fix java.sql.Date mapping
commit 8ea0598c6b5ce9e81ccd114df7246ba17e26817e
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-02T06:11:09Z
IGNITE-3228: Hadoop: workaround/fix for inefficient memory usage.
commit 150e0d3b3ab1b01483b5e44ff28198a51fa35e68
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-02T08:47:38Z
IGNITE-3228: Minor fix.
commit 0d623830e0d67be5f0874f704155367d2d9de45b
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-05T17:57:15Z
IGFS-3246: IGFS: Infrastructure for client optimizations.
commit 14c80a162419931f589f23dae60f2590f0f425a6
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-05T18:19:40Z
Merge remote-tracking branch 'upstream/gridgain-7.6.1' into gridgain-7.6.1
commit fdc3aa6e6f1f163351ef1200e18faed7db96d218
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-05T18:00:53Z
IGNITE-3247: IGFS: Optimized non-stream client operations.
commit 6f99b14ea00bd99ec07014f4cda3f43edc562da7
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-05T18:04:03Z
IGNITE-3248: Optimized fileIds() usage.
commit dc34b6f11b1b850ad6cdfcaa3d34e27e9c6deebf
Author: Denis Magda <dm...@gridgain.com>
Date: 2016-06-06T07:31:59Z
IGNITE-3240: fixed serialization of String and other primitive arrays by CacheObjectBinaryProcessorImpl
(cherry picked from commit 9e9252c2e4ed7380b3933909ac297f6618708980)
commit 3d3bf080bbb5d5a35a9a6cb641a7b1b11867b538
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-06T07:36:26Z
IGNITE-3247: IGFS: Minor fixes after merge.
commit 4799b2601e5928bbb6854f462ae02a6f8935852d
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-06T07:36:45Z
Merge remote-tracking branch 'upstream/gridgain-7.6.1' into gridgain-7.6.1
commit 4e82af8a57d7a627e4d019273f8c5a40574694d3
Author: sboikov <sb...@gridgain.com>
Date: 2016-06-06T11:23:02Z
ignite-3212 More debug logging on exchange timeout. Fixed issue in GridCacheTxRecoveryFuture with message send failure and late discovery event.
commit 4804db9ca806ee7c743f5f54d6eac37163513759
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-06T12:40:59Z
IGNITE-3256: IGFS: Removed "exists" check during input stream close.
commit d4046dc46c0b6e4f122ef45147dd44c09e4c283c
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-06T12:50:13Z
IGNITE-3257: IGFS: FileSystemConfiguration.DFLT_INIT_DFLT_PATH_MODES has been changed to "false".
commit 3cabdcf026fd528fdae305ec2ed832d6ad603cb0
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-06T14:50:58Z
IGNITE-3258: IGFS: Secondary file system input stream is opened only when it is really needed.
commit 33b0eb24dc7daebc13c07eb967e5b4ed7171ae55
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-06T15:10:36Z
IGNITE-3259: Delete worker is not started on client nodes any more.
commit a60bb3b658bb6d4688e07e0e4d07aff6a976c6a3
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-08T11:54:37Z
Merge remote-tracking branch 'upstream/gridgain-7.6.1' into gridgain-7.6.1
commit c300448b94ed0d3f847197d1bbe67c31165c6ae6
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-06T15:12:42Z
IGNITE-3260: IGFS: Delete messages are no longer passed.
commit 4273950458a9bb2f83d5fc0489da49aa1fa1dfaf
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-08T08:50:22Z
IGNITE-3274: Hadoop: Fixed NPE in BasicUserNameMapper.
commit 177ebd5c75b38e772e8889fa3589d86ab3fa8f70
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-08T11:41:49Z
IGNITE-3264: IGFS: Reworked output stream.
commit 7761e5f573d9f39b5cc542f3d67bacab4e66609a
Author: vozerov-gridgain <vo...@gridgain.com>
Date: 2016-06-08T12:13:33Z
IGNITE-3264: IGFS: Reworked output stream.
commit 17020cc81edbb6a75b45f35bdbb28c70c951a667
Author: Igor <ir...@gmail.com>
Date: 2016-06-09T23:38:41Z
IGNITE-3238 Javadoc Warning due to cassandra libs usage
commit 2040c3dda9dd5b4796797ed37a0fc01890dcb861
Author: Vladislav Pyatkov <vl...@gmail.com>
Date: 2016-06-13T10:13:54Z
IGNITE-2616 - NonHeap memory usage metrics don't work as expected.
Reviewed and merged by Denis Magda.
commit 320c1aafdaaa0b5325f32566cb48fcbef455f69d
Author: MaBiao <ma...@gmail.com>
Date: 2016-06-13T10:39:37Z
IGNITE-3304: Fix parameter error in class GridServiceProcessor.
Reviewed and merged by Denis Magda.
commit 4f8ba17b412af8d32812ffba39e7dc2a2326ecf8
Author: Kristian Rosenvold <kr...@gmail.com>
Date: 2016-06-13T11:32:20Z
Mysql support broken in 1.6, externalize sql syntax to make it configurable
Reviewed and merged by Denis Magda.
----
> Data streamer: use identity comparison for "activeKeys" in DataStreamerImpl.load0 method.
> -----------------------------------------------------------------------------------------
>
> Key: IGNITE-3828
> URL: https://issues.apache.org/jira/browse/IGNITE-3828
> Project: Ignite
> Issue Type: Task
> Components: streaming
> Affects Versions: 1.7
> Reporter: Vladimir Ozerov
> Assignee: Andrew Mashenkov
> Priority: Minor
> Labels: performance
> Fix For: 1.8
>
>
> See {{DataStreamerImpl.load0}} method. One of it's arguments is {{activeKeys}} collection. Elements from this collection is removed when batch is successfully applied on the server. Currently this collections is concurrent hash set of {{KeyCacheObject}}. In case hash conflict occurs (which is not unusual for streaming when lots of keys are loaded), it leads to full byte-by-byte comparison of binary objects. It might be very inefficient.
> To avoid the problem we should wrap {{KeyCacheObject}} into additional class with overridden {{equals}} and {{hashCode}} methods, so equality check is performed only through reference equality ({{==}}). This way hash conflicts will be resolved extremely fast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)