You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/06/01 08:02:26 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #7747: Python: Loosen dependency on typing-extensions
Fokko opened a new pull request, #7747:
URL: https://github.com/apache/iceberg/pull/7747
In the CI we pin the `typing-extensions` dependency on `4.5.0`, but it looks like some bug has been introduced in `4.6.1`.
By loosening this requirement, we install the same version as when someone would when they don't install the dev requirements.
Resolves #7746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #7747: Python: Loosen dependency on typing-extensions
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #7747:
URL: https://github.com/apache/iceberg/pull/7747#issuecomment-1597663408
@rajaie-sg A new version is incoming. The issue should only happen if you also install the dev dependency. Otherwise, you can run `pip3 install --upgrade typing-extensions.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #7747: Python: Loosen dependency on typing-extensions
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #7747:
URL: https://github.com/apache/iceberg/pull/7747#issuecomment-1571771309
Thanks for the quick review @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #7747: Python: Loosen dependency on typing-extensions
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #7747:
URL: https://github.com/apache/iceberg/pull/7747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rajaie-sg commented on pull request #7747: Python: Loosen dependency on typing-extensions
Posted by "rajaie-sg (via GitHub)" <gi...@apache.org>.
rajaie-sg commented on PR #7747:
URL: https://github.com/apache/iceberg/pull/7747#issuecomment-1597650119
Does a new version need to be released to PyPI? https://pypi.org/project/pyiceberg/#history
I tried 0.3.0 but it still suffers from the issue in https://github.com/apache/iceberg/issues/7746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rajaie-sg commented on pull request #7747: Python: Loosen dependency on typing-extensions
Posted by "rajaie-sg (via GitHub)" <gi...@apache.org>.
rajaie-sg commented on PR #7747:
URL: https://github.com/apache/iceberg/pull/7747#issuecomment-1597670073
Ah I see, I was running `pip3 install "pyiceberg[glue,s3fs,hive]"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rajaie-sg commented on pull request #7747: Python: Loosen dependency on typing-extensions
Posted by "rajaie-sg (via GitHub)" <gi...@apache.org>.
rajaie-sg commented on PR #7747:
URL: https://github.com/apache/iceberg/pull/7747#issuecomment-1597817280
Actually, it looks like the issue here is with pydantic, which is fixed to version 1.10.4 here https://github.com/apache/iceberg/blob/pyiceberg-0.3.0/python/pyproject.toml#LL58C1-L58C9
Even when I run `pip3 install --upgrade typing-extensions`, I still run into the problem.
It's only when I run `pip3 install --upgrade pydantic ` does the problem get resolved, but this isn't a solution since we are using Poetry and it prevents us from specifying a version of Pydantic other than 1.10.4 in the pyproject.toml file.
pydantic gets installed by default with pyiceberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org