You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by Mohammad Asif Siddiqui <as...@apache.org> on 2018/03/07 17:41:12 UTC
[VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
Hi All,
This is a call for Vote to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1 (second release candidate).
Release Notes : https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md
Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
Release Tag : https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1
Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS
Release Source : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/
Guide to build the release from source : https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release
Voting will start now ( Wednesday, 7th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote.
[ ] +1 Release this package as 1.0.0-m1.
[ ] +0 No Opinion.
[ ] -1 Do not release this package because....
Regards
Asif
Re: ��������� [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
Posted by Mohammad Asif Siddiqui <as...@apache.org>.
Hi Willem,
This is not an issue, this is more like a suggestion to handle the configuration in a better way, as the values of SC_IP can still be changed in js file as per our Readme.
So IMO we don't need to add this in Known Issues list.
Anyhow I have created a JIRA for this [1] to track this issue in m2.
[1] https://issues.apache.org/jira/browse/SCB-377
Regards
Asif
On 2018/03/08 08:55:56, Willem Jiang <wi...@gmail.com> wrote:
> Hi Asifï¼
>
> Please create a JIRA for checking the apiList.js issue.
> Then we can add this known issue to the release note and address it in m2
> release.
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
> http://jnn.iteye.com (Chinese)
> Twitter: willemjiang
> Weibo: å§å®willem
>
> On Thu, Mar 8, 2018 at 3:49 PM, Mohammad Asif Siddiqui <
> asifdxtreme@apache.org> wrote:
>
> > Thanks YangBo and Cuiyihua for the suggestion.
> >
> > We will move the frontend configurations to the app.conf and add the
> > frontend starting guide in the main Readme, so from here on there will be
> > only 1 Readme and 1 conf which can be used by both frontend and
> > service-center.
> >
> > Coming back to configuration of SC api in frontend we will definitely move
> > this to configuration to the app.conf and it can be dynamically replaced
> > when frontend will start, this needs some time of testing in windows system
> > as in linux it's quite easy but in some windows OS version it fails, so
> > that was the reason we kept this conf in apiList.js. We will take this
> > issues in m2 release.
> >
> > Regards
> > Asif
> >
> >
> > On 2018/03/08 07:38:32, "Sure" <su...@qq.com> wrote:
> > > Suggestion: merge these configures in SC app.conf, and move the frontend
> > readme into main readme.
> > >
> > >
> > >
> > >
> > > ------------------ åå§é®ä»¶ ------------------
> > > å件人: "Yang Bo"<oa...@gmail.com>;
> > > åéæ¶é´: 2018å¹´3æ8æ¥(ææå) ä¸å3:36
> > > æ¶ä»¶äºº: "dev"<de...@servicecomb.apache.org>;
> > >
> > > 主é¢: Re: [VOTE] Release Apache ServiceComb Service-Center
> > (incubating)version 1.0.0-m1
> > >
> > >
> > >
> > > Hi Asif,
> > >
> > > For the first issue, It's OK that we leave it as is in this release. But
> > in
> > > the long run, it's still better to put the configurations together(the
> > > frontend.conf file).
> > >
> > >
> > > On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui <
> > > asifdxtreme@apache.org> wrote:
> > >
> > > > Hi YangBo,
> > > >
> > > > Thanks for your vote.
> > > >
> > > > We will fix the 2nd and 3rd Issue.
> > > >
> > > > For 1st Issue I would like to clear that the hardcode values are in js
> > > > files which can be modifies easily afterwards in the release, which we
> > have
> > > > already mentioned in our Readme over here [1]
> > > >
> > > > [1] https://github.com/apache/incubator-servicecomb-service-
> > > > center/tree/master/frontend#note
> > > >
> > > > Regards
> > > > Asif
> > > >
> > > >
> > > > On 2018/03/08 07:20:17, Yang Bo <oa...@gmail.com> wrote:
> > > > > -1 Binding Vote.
> > > > >
> > > > > Below Checks Done:
> > > > > 1. Verified the md5sum, sha1sum and GPG signature for source and
> > binary
> > > > > release packages.
> > > > > 2. Verified the service-center linux release using Java Chassis BMI
> > > > sample.
> > > > > 3. Verified the frontend on both windows and linux.
> > > > > 4. Checked the bundled files, no fonts and images without proper
> > > > licensing
> > > > > bundled.
> > > > > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and
> > > > > source release
> > > > > 6. RAT on source release is OK
> > > > >
> > > > > Some issues:
> > > > > 1. The service-center's address/port is hardcoded in frontend's js
> > file,
> > > > > which cause the frontend to not functioning if service center is not
> > > > > running on 127.0.0.1:30100.
> > > > > Bug report: https://issues.apache.org/jira/browse/SCB-375
> > > > >
> > > > > 2. The scripts in binary release does not contain the ASF header.
> > > > > start-frontend.sh
> > > > > start-service-center.sh
> > > > > stop-frontend.sh
> > > > > stop-service-center.sh
> > > > >
> > > > > 3. Scripts on source release have ASF header but the script shebang
> > is
> > > > not
> > > > > in the first line, which would cause problems if the script is not
> > called
> > > > > directy by bash. We should still put the shell shebang on the first
> > line
> > > > of
> > > > > scripts and followd by a blank line then the ASF header.
> > > > > For example:
> > > > > ===================================
> > > > > #!/bin/bash
> > > > >
> > > > > # Licensed to the Apache ...
> > > > >
> > > > >
> > > > > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C <su...@huawei.com>
> > wrote:
> > > > >
> > > > > > +1 Binding Vote.
> > > > > >
> > > > > > Below Checks Done:
> > > > > > 1. Verify the file signature.
> > > > > > 2. Verified windows release for service center using java chassis
> > demo.
> > > > > > 3. Ran the Service-Center and Frontend, verified basic
> > functionality of
> > > > > > service center and frontend.
> > > > > >
> > > > > > Thanks,
> > > > > > Sukesh.
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Mohammad Asif Siddiqui [mailto:asifdxtreme@apache.org]
> > > > > > Sent: 07 March 2018 23:11
> > > > > > To: dev@servicecomb.apache.org
> > > > > > Subject: [VOTE] Release Apache ServiceComb Service-Center
> > (incubating)
> > > > > > version 1.0.0-m1
> > > > > >
> > > > > > Hi All,
> > > > > >
> > > > > > This is a call for Vote to release Apache ServiceComb
> > Service-Center
> > > > > > (Incubating) version 1.0.0-m1 (second release candidate).
> > > > > >
> > > > > > Release Notes : https://github.com/apache/
> > > > incubator-servicecomb-service-
> > > > > > center/blob/master/docs/release/releaseNotes.md
> > > > > >
> > > > > > Release Candidate : https://dist.apache.org/repos/
> > dist/dev/incubator/
> > > > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
> > > > > >
> > > > > > Release Tag : https://github.com/apache/
> > incubator-servicecomb-service-
> > > > > > center/releases/tag/1.0.0-m1
> > > > > >
> > > > > > Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
> > > > > >
> > > > > > Keys to verify the Release Candidate :
> > https://dist.apache.org/repos/
> > > > > > dist/dev/incubator/servicecomb/KEYS
> > > > > >
> > > > > > Release Source : https://dist.apache.org/repos/dist/dev/incubator/
> > > > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/
> > > > > >
> > > > > > Guide to build the release from source :
> > https://github.com/apache/
> > > > > > incubator-servicecomb-service-center/tree/master/scripts/release
> > > > > >
> > > > > > Voting will start now ( Wednesday, 7th March, 2018) and will remain
> > > > open
> > > > > > for next 72 hours, Request all PPMC members to give their vote.
> > > > > >
> > > > > > [ ] +1 Release this package as 1.0.0-m1.
> > > > > > [ ] +0 No Opinion.
> > > > > > [ ] -1 Do not release this package because....
> > > > > >
> > > > > > Regards
> > > > > > Asif
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Best Regards,
> > > > > Yang.
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Best Regards,
> > > Yang.
> >
>
Re: 回复： [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
Posted by Willem Jiang <wi...@gmail.com>.
Hi Asif，
Please create a JIRA for checking the apiList.js issue.
Then we can add this known issue to the release note and address it in m2
release.
Willem Jiang
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Thu, Mar 8, 2018 at 3:49 PM, Mohammad Asif Siddiqui <
asifdxtreme@apache.org> wrote:
> Thanks YangBo and Cuiyihua for the suggestion.
>
> We will move the frontend configurations to the app.conf and add the
> frontend starting guide in the main Readme, so from here on there will be
> only 1 Readme and 1 conf which can be used by both frontend and
> service-center.
>
> Coming back to configuration of SC api in frontend we will definitely move
> this to configuration to the app.conf and it can be dynamically replaced
> when frontend will start, this needs some time of testing in windows system
> as in linux it's quite easy but in some windows OS version it fails, so
> that was the reason we kept this conf in apiList.js. We will take this
> issues in m2 release.
>
> Regards
> Asif
>
>
> On 2018/03/08 07:38:32, "Sure" <su...@qq.com> wrote:
> > Suggestion: merge these configures in SC app.conf, and move the frontend
> readme into main readme.
> >
> >
> >
> >
> > ------------------ 原始邮件 ------------------
> > 发件人: "Yang Bo"<oa...@gmail.com>;
> > 发送时间: 2018年3月8日(星期四) 下午3:36
> > 收件人: "dev"<de...@servicecomb.apache.org>;
> >
> > 主题: Re: [VOTE] Release Apache ServiceComb Service-Center
> (incubating)version 1.0.0-m1
> >
> >
> >
> > Hi Asif,
> >
> > For the first issue, It's OK that we leave it as is in this release. But
> in
> > the long run, it's still better to put the configurations together(the
> > frontend.conf file).
> >
> >
> > On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui <
> > asifdxtreme@apache.org> wrote:
> >
> > > Hi YangBo,
> > >
> > > Thanks for your vote.
> > >
> > > We will fix the 2nd and 3rd Issue.
> > >
> > > For 1st Issue I would like to clear that the hardcode values are in js
> > > files which can be modifies easily afterwards in the release, which we
> have
> > > already mentioned in our Readme over here [1]
> > >
> > > [1] https://github.com/apache/incubator-servicecomb-service-
> > > center/tree/master/frontend#note
> > >
> > > Regards
> > > Asif
> > >
> > >
> > > On 2018/03/08 07:20:17, Yang Bo <oa...@gmail.com> wrote:
> > > > -1 Binding Vote.
> > > >
> > > > Below Checks Done:
> > > > 1. Verified the md5sum, sha1sum and GPG signature for source and
> binary
> > > > release packages.
> > > > 2. Verified the service-center linux release using Java Chassis BMI
> > > sample.
> > > > 3. Verified the frontend on both windows and linux.
> > > > 4. Checked the bundled files, no fonts and images without proper
> > > licensing
> > > > bundled.
> > > > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and
> > > > source release
> > > > 6. RAT on source release is OK
> > > >
> > > > Some issues:
> > > > 1. The service-center's address/port is hardcoded in frontend's js
> file,
> > > > which cause the frontend to not functioning if service center is not
> > > > running on 127.0.0.1:30100.
> > > > Bug report: https://issues.apache.org/jira/browse/SCB-375
> > > >
> > > > 2. The scripts in binary release does not contain the ASF header.
> > > > start-frontend.sh
> > > > start-service-center.sh
> > > > stop-frontend.sh
> > > > stop-service-center.sh
> > > >
> > > > 3. Scripts on source release have ASF header but the script shebang
> is
> > > not
> > > > in the first line, which would cause problems if the script is not
> called
> > > > directy by bash. We should still put the shell shebang on the first
> line
> > > of
> > > > scripts and followd by a blank line then the ASF header.
> > > > For example:
> > > > ===================================
> > > > #!/bin/bash
> > > >
> > > > # Licensed to the Apache ...
> > > >
> > > >
> > > > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C <su...@huawei.com>
> wrote:
> > > >
> > > > > +1 Binding Vote.
> > > > >
> > > > > Below Checks Done:
> > > > > 1. Verify the file signature.
> > > > > 2. Verified windows release for service center using java chassis
> demo.
> > > > > 3. Ran the Service-Center and Frontend, verified basic
> functionality of
> > > > > service center and frontend.
> > > > >
> > > > > Thanks,
> > > > > Sukesh.
> > > > >
> > > > > -----Original Message-----
> > > > > From: Mohammad Asif Siddiqui [mailto:asifdxtreme@apache.org]
> > > > > Sent: 07 March 2018 23:11
> > > > > To: dev@servicecomb.apache.org
> > > > > Subject: [VOTE] Release Apache ServiceComb Service-Center
> (incubating)
> > > > > version 1.0.0-m1
> > > > >
> > > > > Hi All,
> > > > >
> > > > > This is a call for Vote to release Apache ServiceComb
> Service-Center
> > > > > (Incubating) version 1.0.0-m1 (second release candidate).
> > > > >
> > > > > Release Notes : https://github.com/apache/
> > > incubator-servicecomb-service-
> > > > > center/blob/master/docs/release/releaseNotes.md
> > > > >
> > > > > Release Candidate : https://dist.apache.org/repos/
> dist/dev/incubator/
> > > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
> > > > >
> > > > > Release Tag : https://github.com/apache/
> incubator-servicecomb-service-
> > > > > center/releases/tag/1.0.0-m1
> > > > >
> > > > > Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
> > > > >
> > > > > Keys to verify the Release Candidate :
> https://dist.apache.org/repos/
> > > > > dist/dev/incubator/servicecomb/KEYS
> > > > >
> > > > > Release Source : https://dist.apache.org/repos/dist/dev/incubator/
> > > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/
> > > > >
> > > > > Guide to build the release from source :
> https://github.com/apache/
> > > > > incubator-servicecomb-service-center/tree/master/scripts/release
> > > > >
> > > > > Voting will start now ( Wednesday, 7th March, 2018) and will remain
> > > open
> > > > > for next 72 hours, Request all PPMC members to give their vote.
> > > > >
> > > > > [ ] +1 Release this package as 1.0.0-m1.
> > > > > [ ] +0 No Opinion.
> > > > > [ ] -1 Do not release this package because....
> > > > >
> > > > > Regards
> > > > > Asif
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Best Regards,
> > > > Yang.
> > > >
> > >
> >
> >
> >
> > --
> > Best Regards,
> > Yang.
>
Re: ��������������������������������������������������������������������������������� [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
Posted by Mohammad Asif Siddiqui <as...@apache.org>.
[1] https://github.com/apache/incubator-servicecomb-service-center/pull/300
On 2018/03/08 09:13:03, Mohammad Asif Siddiqui <as...@apache.org> wrote:
> Thanks All for your feedback, here is the PR [1] to fix the above mentioned issues.
>
> We are cancelling this VOTE now, we will be re-intiate the VOTE mail with a new release candidate.
>
> Regards
> Asif
>
>
> On 2018/03/08 07:49:01, Mohammad Asif Siddiqui <as...@apache.org> wrote:
> > Thanks YangBo and Cuiyihua for the suggestion.
> >
> > We will move the frontend configurations to the app.conf and add the frontend starting guide in the main Readme, so from here on there will be only 1 Readme and 1 conf which can be used by both frontend and service-center.
> >
> > Coming back to configuration of SC api in frontend we will definitely move this to configuration to the app.conf and it can be dynamically replaced when frontend will start, this needs some time of testing in windows system as in linux it's quite easy but in some windows OS version it fails, so that was the reason we kept this conf in apiList.js. We will take this issues in m2 release.
> >
> > Regards
> > Asif
> >
> >
> > On 2018/03/08 07:38:32, "Sure" <su...@qq.com> wrote:
> > > Suggestion: merge these configures in SC app.conf, and move the frontend readme into main readme.
> > >
> > >
> > >
> > >
> > > ------------------ ÃÂ¥ÃÂÃÂÃ¥çÃÂéÃÂîäûö ------------------
> > > ÃÂ¥ÃÂÃÂäûöäúú: "Yang Bo"<oa...@gmail.com>;
> > > ÃÂ¥ÃÂÃÂéÃÂÃÂæÃÂöéÃÂô: 2018Ã¥ùô3æÃÂÃÂ8æÃÂÃÂ¥(æÃÂÃÂæÃÂÃÂÃÂ¥ÃÂÃÂ) äøÃÂÃÂ¥ÃÂÃÂ3:36
> > > æÃÂöäûöäúú: "dev"<de...@servicecomb.apache.org>;
> > >
> > > äøûéâÃÂ: Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
> > >
> > >
> > >
> > > Hi Asif,
> > >
> > > For the first issue, It's OK that we leave it as is in this release. But in
> > > the long run, it's still better to put the configurations together(the
> > > frontend.conf file).
> > >
> > >
> > > On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui <
> > > asifdxtreme@apache.org> wrote:
> > >
> > > > Hi YangBo,
> > > >
> > > > Thanks for your vote.
> > > >
> > > > We will fix the 2nd and 3rd Issue.
> > > >
> > > > For 1st Issue I would like to clear that the hardcode values are in js
> > > > files which can be modifies easily afterwards in the release, which we have
> > > > already mentioned in our Readme over here [1]
> > > >
> > > > [1] https://github.com/apache/incubator-servicecomb-service-
> > > > center/tree/master/frontend#note
> > > >
> > > > Regards
> > > > Asif
> > > >
> > > >
> > > > On 2018/03/08 07:20:17, Yang Bo <oa...@gmail.com> wrote:
> > > > > -1 Binding Vote.
> > > > >
> > > > > Below Checks Done:
> > > > > 1. Verified the md5sum, sha1sum and GPG signature for source and binary
> > > > > release packages.
> > > > > 2. Verified the service-center linux release using Java Chassis BMI
> > > > sample.
> > > > > 3. Verified the frontend on both windows and linux.
> > > > > 4. Checked the bundled files, no fonts and images without proper
> > > > licensing
> > > > > bundled.
> > > > > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and
> > > > > source release
> > > > > 6. RAT on source release is OK
> > > > >
> > > > > Some issues:
> > > > > 1. The service-center's address/port is hardcoded in frontend's js file,
> > > > > which cause the frontend to not functioning if service center is not
> > > > > running on 127.0.0.1:30100.
> > > > > Bug report: https://issues.apache.org/jira/browse/SCB-375
> > > > >
> > > > > 2. The scripts in binary release does not contain the ASF header.
> > > > > start-frontend.sh
> > > > > start-service-center.sh
> > > > > stop-frontend.sh
> > > > > stop-service-center.sh
> > > > >
> > > > > 3. Scripts on source release have ASF header but the script shebang is
> > > > not
> > > > > in the first line, which would cause problems if the script is not called
> > > > > directy by bash. We should still put the shell shebang on the first line
> > > > of
> > > > > scripts and followd by a blank line then the ASF header.
> > > > > For example:
> > > > > ===================================
> > > > > #!/bin/bash
> > > > >
> > > > > # Licensed to the Apache ...
> > > > >
> > > > >
> > > > > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C <su...@huawei.com> wrote:
> > > > >
> > > > > > +1 Binding Vote.
> > > > > >
> > > > > > Below Checks Done:
> > > > > > 1. Verify the file signature.
> > > > > > 2. Verified windows release for service center using java chassis demo.
> > > > > > 3. Ran the Service-Center and Frontend, verified basic functionality of
> > > > > > service center and frontend.
> > > > > >
> > > > > > Thanks,
> > > > > > Sukesh.
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Mohammad Asif Siddiqui [mailto:asifdxtreme@apache.org]
> > > > > > Sent: 07 March 2018 23:11
> > > > > > To: dev@servicecomb.apache.org
> > > > > > Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating)
> > > > > > version 1.0.0-m1
> > > > > >
> > > > > > Hi All,
> > > > > >
> > > > > > This is a call for Vote to release Apache ServiceComb Service-Center
> > > > > > (Incubating) version 1.0.0-m1 (second release candidate).
> > > > > >
> > > > > > Release Notes : https://github.com/apache/
> > > > incubator-servicecomb-service-
> > > > > > center/blob/master/docs/release/releaseNotes.md
> > > > > >
> > > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> > > > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
> > > > > >
> > > > > > Release Tag : https://github.com/apache/incubator-servicecomb-service-
> > > > > > center/releases/tag/1.0.0-m1
> > > > > >
> > > > > > Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
> > > > > >
> > > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/
> > > > > > dist/dev/incubator/servicecomb/KEYS
> > > > > >
> > > > > > Release Source : https://dist.apache.org/repos/dist/dev/incubator/
> > > > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/
> > > > > >
> > > > > > Guide to build the release from source : https://github.com/apache/
> > > > > > incubator-servicecomb-service-center/tree/master/scripts/release
> > > > > >
> > > > > > Voting will start now ( Wednesday, 7th March, 2018) and will remain
> > > > open
> > > > > > for next 72 hours, Request all PPMC members to give their vote.
> > > > > >
> > > > > > [ ] +1 Release this package as 1.0.0-m1.
> > > > > > [ ] +0 No Opinion.
> > > > > > [ ] -1 Do not release this package because....
> > > > > >
> > > > > > Regards
> > > > > > Asif
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Best Regards,
> > > > > Yang.
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Best Regards,
> > > Yang.
> >
>
Re: ��������������������������� [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
Posted by Mohammad Asif Siddiqui <as...@apache.org>.
Thanks All for your feedback, here is the PR [1] to fix the above mentioned issues.
We are cancelling this VOTE now, we will be re-intiate the VOTE mail with a new release candidate.
Regards
Asif
On 2018/03/08 07:49:01, Mohammad Asif Siddiqui <as...@apache.org> wrote:
> Thanks YangBo and Cuiyihua for the suggestion.
>
> We will move the frontend configurations to the app.conf and add the frontend starting guide in the main Readme, so from here on there will be only 1 Readme and 1 conf which can be used by both frontend and service-center.
>
> Coming back to configuration of SC api in frontend we will definitely move this to configuration to the app.conf and it can be dynamically replaced when frontend will start, this needs some time of testing in windows system as in linux it's quite easy but in some windows OS version it fails, so that was the reason we kept this conf in apiList.js. We will take this issues in m2 release.
>
> Regards
> Asif
>
>
> On 2018/03/08 07:38:32, "Sure" <su...@qq.com> wrote:
> > Suggestion: merge these configures in SC app.conf, and move the frontend readme into main readme.
> >
> >
> >
> >
> > ------------------ Ã¥ÂÂå§Âé®件 ------------------
> > Ã¥ÂÂ件人: "Yang Bo"<oa...@gmail.com>;
> > Ã¥ÂÂéÂÂæ¶é´: 2018å¹´3æÂÂ8æÂÂ¥(æÂÂæÂÂÃ¥ÂÂ) ä¸ÂÃ¥ÂÂ3:36
> > æ¶件人: "dev"<de...@servicecomb.apache.org>;
> >
> > 主é¢Â: Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
> >
> >
> >
> > Hi Asif,
> >
> > For the first issue, It's OK that we leave it as is in this release. But in
> > the long run, it's still better to put the configurations together(the
> > frontend.conf file).
> >
> >
> > On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui <
> > asifdxtreme@apache.org> wrote:
> >
> > > Hi YangBo,
> > >
> > > Thanks for your vote.
> > >
> > > We will fix the 2nd and 3rd Issue.
> > >
> > > For 1st Issue I would like to clear that the hardcode values are in js
> > > files which can be modifies easily afterwards in the release, which we have
> > > already mentioned in our Readme over here [1]
> > >
> > > [1] https://github.com/apache/incubator-servicecomb-service-
> > > center/tree/master/frontend#note
> > >
> > > Regards
> > > Asif
> > >
> > >
> > > On 2018/03/08 07:20:17, Yang Bo <oa...@gmail.com> wrote:
> > > > -1 Binding Vote.
> > > >
> > > > Below Checks Done:
> > > > 1. Verified the md5sum, sha1sum and GPG signature for source and binary
> > > > release packages.
> > > > 2. Verified the service-center linux release using Java Chassis BMI
> > > sample.
> > > > 3. Verified the frontend on both windows and linux.
> > > > 4. Checked the bundled files, no fonts and images without proper
> > > licensing
> > > > bundled.
> > > > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and
> > > > source release
> > > > 6. RAT on source release is OK
> > > >
> > > > Some issues:
> > > > 1. The service-center's address/port is hardcoded in frontend's js file,
> > > > which cause the frontend to not functioning if service center is not
> > > > running on 127.0.0.1:30100.
> > > > Bug report: https://issues.apache.org/jira/browse/SCB-375
> > > >
> > > > 2. The scripts in binary release does not contain the ASF header.
> > > > start-frontend.sh
> > > > start-service-center.sh
> > > > stop-frontend.sh
> > > > stop-service-center.sh
> > > >
> > > > 3. Scripts on source release have ASF header but the script shebang is
> > > not
> > > > in the first line, which would cause problems if the script is not called
> > > > directy by bash. We should still put the shell shebang on the first line
> > > of
> > > > scripts and followd by a blank line then the ASF header.
> > > > For example:
> > > > ===================================
> > > > #!/bin/bash
> > > >
> > > > # Licensed to the Apache ...
> > > >
> > > >
> > > > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C <su...@huawei.com> wrote:
> > > >
> > > > > +1 Binding Vote.
> > > > >
> > > > > Below Checks Done:
> > > > > 1. Verify the file signature.
> > > > > 2. Verified windows release for service center using java chassis demo.
> > > > > 3. Ran the Service-Center and Frontend, verified basic functionality of
> > > > > service center and frontend.
> > > > >
> > > > > Thanks,
> > > > > Sukesh.
> > > > >
> > > > > -----Original Message-----
> > > > > From: Mohammad Asif Siddiqui [mailto:asifdxtreme@apache.org]
> > > > > Sent: 07 March 2018 23:11
> > > > > To: dev@servicecomb.apache.org
> > > > > Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating)
> > > > > version 1.0.0-m1
> > > > >
> > > > > Hi All,
> > > > >
> > > > > This is a call for Vote to release Apache ServiceComb Service-Center
> > > > > (Incubating) version 1.0.0-m1 (second release candidate).
> > > > >
> > > > > Release Notes : https://github.com/apache/
> > > incubator-servicecomb-service-
> > > > > center/blob/master/docs/release/releaseNotes.md
> > > > >
> > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> > > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
> > > > >
> > > > > Release Tag : https://github.com/apache/incubator-servicecomb-service-
> > > > > center/releases/tag/1.0.0-m1
> > > > >
> > > > > Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
> > > > >
> > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/
> > > > > dist/dev/incubator/servicecomb/KEYS
> > > > >
> > > > > Release Source : https://dist.apache.org/repos/dist/dev/incubator/
> > > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/
> > > > >
> > > > > Guide to build the release from source : https://github.com/apache/
> > > > > incubator-servicecomb-service-center/tree/master/scripts/release
> > > > >
> > > > > Voting will start now ( Wednesday, 7th March, 2018) and will remain
> > > open
> > > > > for next 72 hours, Request all PPMC members to give their vote.
> > > > >
> > > > > [ ] +1 Release this package as 1.0.0-m1.
> > > > > [ ] +0 No Opinion.
> > > > > [ ] -1 Do not release this package because....
> > > > >
> > > > > Regards
> > > > > Asif
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Best Regards,
> > > > Yang.
> > > >
> > >
> >
> >
> >
> > --
> > Best Regards,
> > Yang.
>
Re: ��������� [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
Posted by Mohammad Asif Siddiqui <as...@apache.org>.
Thanks YangBo and Cuiyihua for the suggestion.
We will move the frontend configurations to the app.conf and add the frontend starting guide in the main Readme, so from here on there will be only 1 Readme and 1 conf which can be used by both frontend and service-center.
Coming back to configuration of SC api in frontend we will definitely move this to configuration to the app.conf and it can be dynamically replaced when frontend will start, this needs some time of testing in windows system as in linux it's quite easy but in some windows OS version it fails, so that was the reason we kept this conf in apiList.js. We will take this issues in m2 release.
Regards
Asif
On 2018/03/08 07:38:32, "Sure" <su...@qq.com> wrote:
> Suggestion: merge these configures in SC app.conf, and move the frontend readme into main readme.
>
>
>
>
> ------------------ åå§é®ä»¶ ------------------
> å件人: "Yang Bo"<oa...@gmail.com>;
> åéæ¶é´: 2018å¹´3æ8æ¥(ææå) ä¸å3:36
> æ¶ä»¶äºº: "dev"<de...@servicecomb.apache.org>;
>
> 主é¢: Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
>
>
>
> Hi Asif,
>
> For the first issue, It's OK that we leave it as is in this release. But in
> the long run, it's still better to put the configurations together(the
> frontend.conf file).
>
>
> On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui <
> asifdxtreme@apache.org> wrote:
>
> > Hi YangBo,
> >
> > Thanks for your vote.
> >
> > We will fix the 2nd and 3rd Issue.
> >
> > For 1st Issue I would like to clear that the hardcode values are in js
> > files which can be modifies easily afterwards in the release, which we have
> > already mentioned in our Readme over here [1]
> >
> > [1] https://github.com/apache/incubator-servicecomb-service-
> > center/tree/master/frontend#note
> >
> > Regards
> > Asif
> >
> >
> > On 2018/03/08 07:20:17, Yang Bo <oa...@gmail.com> wrote:
> > > -1 Binding Vote.
> > >
> > > Below Checks Done:
> > > 1. Verified the md5sum, sha1sum and GPG signature for source and binary
> > > release packages.
> > > 2. Verified the service-center linux release using Java Chassis BMI
> > sample.
> > > 3. Verified the frontend on both windows and linux.
> > > 4. Checked the bundled files, no fonts and images without proper
> > licensing
> > > bundled.
> > > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and
> > > source release
> > > 6. RAT on source release is OK
> > >
> > > Some issues:
> > > 1. The service-center's address/port is hardcoded in frontend's js file,
> > > which cause the frontend to not functioning if service center is not
> > > running on 127.0.0.1:30100.
> > > Bug report: https://issues.apache.org/jira/browse/SCB-375
> > >
> > > 2. The scripts in binary release does not contain the ASF header.
> > > start-frontend.sh
> > > start-service-center.sh
> > > stop-frontend.sh
> > > stop-service-center.sh
> > >
> > > 3. Scripts on source release have ASF header but the script shebang is
> > not
> > > in the first line, which would cause problems if the script is not called
> > > directy by bash. We should still put the shell shebang on the first line
> > of
> > > scripts and followd by a blank line then the ASF header.
> > > For example:
> > > ===================================
> > > #!/bin/bash
> > >
> > > # Licensed to the Apache ...
> > >
> > >
> > > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C <su...@huawei.com> wrote:
> > >
> > > > +1 Binding Vote.
> > > >
> > > > Below Checks Done:
> > > > 1. Verify the file signature.
> > > > 2. Verified windows release for service center using java chassis demo.
> > > > 3. Ran the Service-Center and Frontend, verified basic functionality of
> > > > service center and frontend.
> > > >
> > > > Thanks,
> > > > Sukesh.
> > > >
> > > > -----Original Message-----
> > > > From: Mohammad Asif Siddiqui [mailto:asifdxtreme@apache.org]
> > > > Sent: 07 March 2018 23:11
> > > > To: dev@servicecomb.apache.org
> > > > Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating)
> > > > version 1.0.0-m1
> > > >
> > > > Hi All,
> > > >
> > > > This is a call for Vote to release Apache ServiceComb Service-Center
> > > > (Incubating) version 1.0.0-m1 (second release candidate).
> > > >
> > > > Release Notes : https://github.com/apache/
> > incubator-servicecomb-service-
> > > > center/blob/master/docs/release/releaseNotes.md
> > > >
> > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
> > > >
> > > > Release Tag : https://github.com/apache/incubator-servicecomb-service-
> > > > center/releases/tag/1.0.0-m1
> > > >
> > > > Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
> > > >
> > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/
> > > > dist/dev/incubator/servicecomb/KEYS
> > > >
> > > > Release Source : https://dist.apache.org/repos/dist/dev/incubator/
> > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/
> > > >
> > > > Guide to build the release from source : https://github.com/apache/
> > > > incubator-servicecomb-service-center/tree/master/scripts/release
> > > >
> > > > Voting will start now ( Wednesday, 7th March, 2018) and will remain
> > open
> > > > for next 72 hours, Request all PPMC members to give their vote.
> > > >
> > > > [ ] +1 Release this package as 1.0.0-m1.
> > > > [ ] +0 No Opinion.
> > > > [ ] -1 Do not release this package because....
> > > >
> > > > Regards
> > > > Asif
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > Best Regards,
> > > Yang.
> > >
> >
>
>
>
> --
> Best Regards,
> Yang.
回复： [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
Posted by Sure <su...@qq.com>.
Suggestion: merge these configures in SC app.conf, and move the frontend readme into main readme.
------------------ 原始邮件 ------------------
发件人: "Yang Bo"<oa...@gmail.com>;
发送时间: 2018年3月8日(星期四) 下午3:36
收件人: "dev"<de...@servicecomb.apache.org>;
主题: Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
Hi Asif,
For the first issue, It's OK that we leave it as is in this release. But in
the long run, it's still better to put the configurations together(the
frontend.conf file).
On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui <
asifdxtreme@apache.org> wrote:
> Hi YangBo,
>
> Thanks for your vote.
>
> We will fix the 2nd and 3rd Issue.
>
> For 1st Issue I would like to clear that the hardcode values are in js
> files which can be modifies easily afterwards in the release, which we have
> already mentioned in our Readme over here [1]
>
> [1] https://github.com/apache/incubator-servicecomb-service-
> center/tree/master/frontend#note
>
> Regards
> Asif
>
>
> On 2018/03/08 07:20:17, Yang Bo <oa...@gmail.com> wrote:
> > -1 Binding Vote.
> >
> > Below Checks Done:
> > 1. Verified the md5sum, sha1sum and GPG signature for source and binary
> > release packages.
> > 2. Verified the service-center linux release using Java Chassis BMI
> sample.
> > 3. Verified the frontend on both windows and linux.
> > 4. Checked the bundled files, no fonts and images without proper
> licensing
> > bundled.
> > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and
> > source release
> > 6. RAT on source release is OK
> >
> > Some issues:
> > 1. The service-center's address/port is hardcoded in frontend's js file,
> > which cause the frontend to not functioning if service center is not
> > running on 127.0.0.1:30100.
> > Bug report: https://issues.apache.org/jira/browse/SCB-375
> >
> > 2. The scripts in binary release does not contain the ASF header.
> > start-frontend.sh
> > start-service-center.sh
> > stop-frontend.sh
> > stop-service-center.sh
> >
> > 3. Scripts on source release have ASF header but the script shebang is
> not
> > in the first line, which would cause problems if the script is not called
> > directy by bash. We should still put the shell shebang on the first line
> of
> > scripts and followd by a blank line then the ASF header.
> > For example:
> > ===================================
> > #!/bin/bash
> >
> > # Licensed to the Apache ...
> >
> >
> > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C <su...@huawei.com> wrote:
> >
> > > +1 Binding Vote.
> > >
> > > Below Checks Done:
> > > 1. Verify the file signature.
> > > 2. Verified windows release for service center using java chassis demo.
> > > 3. Ran the Service-Center and Frontend, verified basic functionality of
> > > service center and frontend.
> > >
> > > Thanks,
> > > Sukesh.
> > >
> > > -----Original Message-----
> > > From: Mohammad Asif Siddiqui [mailto:asifdxtreme@apache.org]
> > > Sent: 07 March 2018 23:11
> > > To: dev@servicecomb.apache.org
> > > Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating)
> > > version 1.0.0-m1
> > >
> > > Hi All,
> > >
> > > This is a call for Vote to release Apache ServiceComb Service-Center
> > > (Incubating) version 1.0.0-m1 (second release candidate).
> > >
> > > Release Notes : https://github.com/apache/
> incubator-servicecomb-service-
> > > center/blob/master/docs/release/releaseNotes.md
> > >
> > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
> > >
> > > Release Tag : https://github.com/apache/incubator-servicecomb-service-
> > > center/releases/tag/1.0.0-m1
> > >
> > > Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
> > >
> > > Keys to verify the Release Candidate : https://dist.apache.org/repos/
> > > dist/dev/incubator/servicecomb/KEYS
> > >
> > > Release Source : https://dist.apache.org/repos/dist/dev/incubator/
> > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/
> > >
> > > Guide to build the release from source : https://github.com/apache/
> > > incubator-servicecomb-service-center/tree/master/scripts/release
> > >
> > > Voting will start now ( Wednesday, 7th March, 2018) and will remain
> open
> > > for next 72 hours, Request all PPMC members to give their vote.
> > >
> > > [ ] +1 Release this package as 1.0.0-m1.
> > > [ ] +0 No Opinion.
> > > [ ] -1 Do not release this package because....
> > >
> > > Regards
> > > Asif
> > >
> > >
> > >
> >
> >
> > --
> > Best Regards,
> > Yang.
> >
>
--
Best Regards,
Yang.
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)
version 1.0.0-m1
Posted by Yang Bo <oa...@gmail.com>.
Hi Asif,
For the first issue, It's OK that we leave it as is in this release. But in
the long run, it's still better to put the configurations together(the
frontend.conf file).
On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui <
asifdxtreme@apache.org> wrote:
> Hi YangBo,
>
> Thanks for your vote.
>
> We will fix the 2nd and 3rd Issue.
>
> For 1st Issue I would like to clear that the hardcode values are in js
> files which can be modifies easily afterwards in the release, which we have
> already mentioned in our Readme over here [1]
>
> [1] https://github.com/apache/incubator-servicecomb-service-
> center/tree/master/frontend#note
>
> Regards
> Asif
>
>
> On 2018/03/08 07:20:17, Yang Bo <oa...@gmail.com> wrote:
> > -1 Binding Vote.
> >
> > Below Checks Done:
> > 1. Verified the md5sum, sha1sum and GPG signature for source and binary
> > release packages.
> > 2. Verified the service-center linux release using Java Chassis BMI
> sample.
> > 3. Verified the frontend on both windows and linux.
> > 4. Checked the bundled files, no fonts and images without proper
> licensing
> > bundled.
> > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and
> > source release
> > 6. RAT on source release is OK
> >
> > Some issues:
> > 1. The service-center's address/port is hardcoded in frontend's js file,
> > which cause the frontend to not functioning if service center is not
> > running on 127.0.0.1:30100.
> > Bug report: https://issues.apache.org/jira/browse/SCB-375
> >
> > 2. The scripts in binary release does not contain the ASF header.
> > start-frontend.sh
> > start-service-center.sh
> > stop-frontend.sh
> > stop-service-center.sh
> >
> > 3. Scripts on source release have ASF header but the script shebang is
> not
> > in the first line, which would cause problems if the script is not called
> > directy by bash. We should still put the shell shebang on the first line
> of
> > scripts and followd by a blank line then the ASF header.
> > For example:
> > ===================================
> > #!/bin/bash
> >
> > # Licensed to the Apache ...
> >
> >
> > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C <su...@huawei.com> wrote:
> >
> > > +1 Binding Vote.
> > >
> > > Below Checks Done:
> > > 1. Verify the file signature.
> > > 2. Verified windows release for service center using java chassis demo.
> > > 3. Ran the Service-Center and Frontend, verified basic functionality of
> > > service center and frontend.
> > >
> > > Thanks,
> > > Sukesh.
> > >
> > > -----Original Message-----
> > > From: Mohammad Asif Siddiqui [mailto:asifdxtreme@apache.org]
> > > Sent: 07 March 2018 23:11
> > > To: dev@servicecomb.apache.org
> > > Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating)
> > > version 1.0.0-m1
> > >
> > > Hi All,
> > >
> > > This is a call for Vote to release Apache ServiceComb Service-Center
> > > (Incubating) version 1.0.0-m1 (second release candidate).
> > >
> > > Release Notes : https://github.com/apache/
> incubator-servicecomb-service-
> > > center/blob/master/docs/release/releaseNotes.md
> > >
> > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
> > >
> > > Release Tag : https://github.com/apache/incubator-servicecomb-service-
> > > center/releases/tag/1.0.0-m1
> > >
> > > Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
> > >
> > > Keys to verify the Release Candidate : https://dist.apache.org/repos/
> > > dist/dev/incubator/servicecomb/KEYS
> > >
> > > Release Source : https://dist.apache.org/repos/dist/dev/incubator/
> > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/
> > >
> > > Guide to build the release from source : https://github.com/apache/
> > > incubator-servicecomb-service-center/tree/master/scripts/release
> > >
> > > Voting will start now ( Wednesday, 7th March, 2018) and will remain
> open
> > > for next 72 hours, Request all PPMC members to give their vote.
> > >
> > > [ ] +1 Release this package as 1.0.0-m1.
> > > [ ] +0 No Opinion.
> > > [ ] -1 Do not release this package because....
> > >
> > > Regards
> > > Asif
> > >
> > >
> > >
> >
> >
> > --
> > Best Regards,
> > Yang.
> >
>
--
Best Regards,
Yang.
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
Posted by Mohammad Asif Siddiqui <as...@apache.org>.
Hi YangBo,
Thanks for your vote.
We will fix the 2nd and 3rd Issue.
For 1st Issue I would like to clear that the hardcode values are in js files which can be modifies easily afterwards in the release, which we have already mentioned in our Readme over here [1]
[1] https://github.com/apache/incubator-servicecomb-service-center/tree/master/frontend#note
Regards
Asif
On 2018/03/08 07:20:17, Yang Bo <oa...@gmail.com> wrote:
> -1 Binding Vote.
>
> Below Checks Done:
> 1. Verified the md5sum, sha1sum and GPG signature for source and binary
> release packages.
> 2. Verified the service-center linux release using Java Chassis BMI sample.
> 3. Verified the frontend on both windows and linux.
> 4. Checked the bundled files, no fonts and images without proper licensing
> bundled.
> 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and
> source release
> 6. RAT on source release is OK
>
> Some issues:
> 1. The service-center's address/port is hardcoded in frontend's js file,
> which cause the frontend to not functioning if service center is not
> running on 127.0.0.1:30100.
> Bug report: https://issues.apache.org/jira/browse/SCB-375
>
> 2. The scripts in binary release does not contain the ASF header.
> start-frontend.sh
> start-service-center.sh
> stop-frontend.sh
> stop-service-center.sh
>
> 3. Scripts on source release have ASF header but the script shebang is not
> in the first line, which would cause problems if the script is not called
> directy by bash. We should still put the shell shebang on the first line of
> scripts and followd by a blank line then the ASF header.
> For example:
> ===================================
> #!/bin/bash
>
> # Licensed to the Apache ...
>
>
> On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C <su...@huawei.com> wrote:
>
> > +1 Binding Vote.
> >
> > Below Checks Done:
> > 1. Verify the file signature.
> > 2. Verified windows release for service center using java chassis demo.
> > 3. Ran the Service-Center and Frontend, verified basic functionality of
> > service center and frontend.
> >
> > Thanks,
> > Sukesh.
> >
> > -----Original Message-----
> > From: Mohammad Asif Siddiqui [mailto:asifdxtreme@apache.org]
> > Sent: 07 March 2018 23:11
> > To: dev@servicecomb.apache.org
> > Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating)
> > version 1.0.0-m1
> >
> > Hi All,
> >
> > This is a call for Vote to release Apache ServiceComb Service-Center
> > (Incubating) version 1.0.0-m1 (second release candidate).
> >
> > Release Notes : https://github.com/apache/incubator-servicecomb-service-
> > center/blob/master/docs/release/releaseNotes.md
> >
> > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
> >
> > Release Tag : https://github.com/apache/incubator-servicecomb-service-
> > center/releases/tag/1.0.0-m1
> >
> > Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
> >
> > Keys to verify the Release Candidate : https://dist.apache.org/repos/
> > dist/dev/incubator/servicecomb/KEYS
> >
> > Release Source : https://dist.apache.org/repos/dist/dev/incubator/
> > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/
> >
> > Guide to build the release from source : https://github.com/apache/
> > incubator-servicecomb-service-center/tree/master/scripts/release
> >
> > Voting will start now ( Wednesday, 7th March, 2018) and will remain open
> > for next 72 hours, Request all PPMC members to give their vote.
> >
> > [ ] +1 Release this package as 1.0.0-m1.
> > [ ] +0 No Opinion.
> > [ ] -1 Do not release this package because....
> >
> > Regards
> > Asif
> >
> >
> >
>
>
> --
> Best Regards,
> Yang.
>
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)
version 1.0.0-m1
Posted by Yang Bo <oa...@gmail.com>.
-1 Binding Vote.
Below Checks Done:
1. Verified the md5sum, sha1sum and GPG signature for source and binary
release packages.
2. Verified the service-center linux release using Java Chassis BMI sample.
3. Verified the frontend on both windows and linux.
4. Checked the bundled files, no fonts and images without proper licensing
bundled.
5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and
source release
6. RAT on source release is OK
Some issues:
1. The service-center's address/port is hardcoded in frontend's js file,
which cause the frontend to not functioning if service center is not
running on 127.0.0.1:30100.
Bug report: https://issues.apache.org/jira/browse/SCB-375
2. The scripts in binary release does not contain the ASF header.
start-frontend.sh
start-service-center.sh
stop-frontend.sh
stop-service-center.sh
3. Scripts on source release have ASF header but the script shebang is not
in the first line, which would cause problems if the script is not called
directy by bash. We should still put the shell shebang on the first line of
scripts and followd by a blank line then the ASF header.
For example:
===================================
#!/bin/bash
# Licensed to the Apache ...
On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C <su...@huawei.com> wrote:
> +1 Binding Vote.
>
> Below Checks Done:
> 1. Verify the file signature.
> 2. Verified windows release for service center using java chassis demo.
> 3. Ran the Service-Center and Frontend, verified basic functionality of
> service center and frontend.
>
> Thanks,
> Sukesh.
>
> -----Original Message-----
> From: Mohammad Asif Siddiqui [mailto:asifdxtreme@apache.org]
> Sent: 07 March 2018 23:11
> To: dev@servicecomb.apache.org
> Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating)
> version 1.0.0-m1
>
> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Service-Center
> (Incubating) version 1.0.0-m1 (second release candidate).
>
> Release Notes : https://github.com/apache/incubator-servicecomb-service-
> center/blob/master/docs/release/releaseNotes.md
>
> Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
>
> Release Tag : https://github.com/apache/incubator-servicecomb-service-
> center/releases/tag/1.0.0-m1
>
> Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
>
> Keys to verify the Release Candidate : https://dist.apache.org/repos/
> dist/dev/incubator/servicecomb/KEYS
>
> Release Source : https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/
>
> Guide to build the release from source : https://github.com/apache/
> incubator-servicecomb-service-center/tree/master/scripts/release
>
> Voting will start now ( Wednesday, 7th March, 2018) and will remain open
> for next 72 hours, Request all PPMC members to give their vote.
>
> [ ] +1 Release this package as 1.0.0-m1.
> [ ] +0 No Opinion.
> [ ] -1 Do not release this package because....
>
> Regards
> Asif
>
>
>
--
Best Regards,
Yang.
RE: [VOTE] Release Apache ServiceComb Service-Center (incubating)
version 1.0.0-m1
Posted by Sukesh A C <su...@huawei.com>.
+1 Binding Vote.
Below Checks Done:
1. Verify the file signature.
2. Verified windows release for service center using java chassis demo.
3. Ran the Service-Center and Frontend, verified basic functionality of service center and frontend.
Thanks,
Sukesh.
-----Original Message-----
From: Mohammad Asif Siddiqui [mailto:asifdxtreme@apache.org]
Sent: 07 March 2018 23:11
To: dev@servicecomb.apache.org
Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
Hi All,
This is a call for Vote to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1 (second release candidate).
Release Notes : https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md
Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
Release Tag : https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1
Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS
Release Source : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/
Guide to build the release from source : https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release
Voting will start now ( Wednesday, 7th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote.
[ ] +1 Release this package as 1.0.0-m1.
[ ] +0 No Opinion.
[ ] -1 Do not release this package because....
Regards
Asif
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
Posted by 郑扬勇 <ya...@qq.com>.
+0 No Opinion.
Below Checks Done, No problem found:
1.Release both windows and linux from source
2.Verified the windows release using Java Chassis BMI sample and Java Chassis SpringMvc Integration Test
3.Verified the linux release by see port is listen and can curl page content from frontend
------------------ Original ------------------
From: "Mohammad Asif Siddiqui"<as...@apache.org>;
Date: Thu, Mar 8, 2018 01:41 AM
To: "dev"<de...@servicecomb.apache.org>;
Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
Hi All,
This is a call for Vote to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1 (second release candidate).
Release Notes : https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md
Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
Release Tag : https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1
Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f
Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS
Release Source : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/
Guide to build the release from source : https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release
Voting will start now ( Wednesday, 7th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote.
[ ] +1 Release this package as 1.0.0-m1.
[ ] +0 No Opinion.
[ ] -1 Do not release this package because....
Regards
Asif