You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/05/17 09:56:32 UTC
[GitHub] zeppelin pull request #2971: [ZEPPELIN-3466] Table export to excel is not wo...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2971
[ZEPPELIN-3466] Table export to excel is not working due to missing dependencies
### What is this PR for?
Table export to excel is not working due to missing dependencies.
angular-ui-grid 4.4.7 onwards comes pre-packaged with jszip and excel-builder, but have few noticeable bugs hence not upgrading to latest.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [ZEPPELIN-3466](https://issues.apache.org/jira/browse/ZEPPELIN-3466)
### How should this be tested?
* Export to excel should work.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3466
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2971.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2971
----
commit 8ce42c7c46f77c3b3b1791a6c450a14d0a95f971
Author: Prabhjyot Singh <pr...@...>
Date: 2018-05-16T17:38:47Z
ZEPPELIN-3466: Table export to excel is not working due to missing dependencies
Change-Id: Ibce8fee548a21e3aa49885a69456b9c785fbd3b5
----
---
[GitHub] zeppelin issue #2971: [ZEPPELIN-3466] Table export to excel is not working d...
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2971
How to activate XLS/XLSX download option?
It doesn't show up for me with this PR applied.
---
[GitHub] zeppelin issue #2971: [ZEPPELIN-3466] Table export to excel is not working d...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2971
Yeah, I know it looks redundant and might be confusing, both have their ups and downs, we can choose to hide one.
---
[GitHub] zeppelin issue #2971: [ZEPPELIN-3466] Table export to excel is not working d...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2971
Yes, this affects branch-0.8. I mean prior to ZEPPELIN-3289 there was no "Table export to excel".
Let me merge this soon so that this also becomes part of the Zeppelin-0.8 release.
---
[GitHub] zeppelin issue #2971: [ZEPPELIN-3466] Table export to excel is not working d...
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2971
Could you please also have a look at https://issues.apache.org/jira/browse/ZEPPELIN-3478
CSV/TSV exports seem to be broken too.
---
[GitHub] zeppelin issue #2971: [ZEPPELIN-3466] Table export to excel is not working d...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2971
@Tagar It shows up on the table (comes as a part of angular-ui-grid)
---
[GitHub] zeppelin issue #2971: [ZEPPELIN-3466] Table export to excel is not working d...
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2971
Thanks @prabhjyotsingh - filed https://issues.apache.org/jira/browse/ZEPPELIN-3511 to consider removing old export csv/tsv which is broken in some other ways (like when data has double quotes and commas) .
---
[GitHub] zeppelin issue #2971: [ZEPPELIN-3466] Table export to excel is not working d...
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2971
Got it @prabhjyotsingh - thanks.
So there are two separate ways to export data now - [1] is the newer way and [2] is the older way.
What's advantage of having two export options?
Should we leave just [1] if this newer export through Angular-ui-grid seems to be better?
For example, I think it might be a little bit confusing to users to have two different ways to exprot csv.
Thanks.
[1]
[2]
---
[GitHub] zeppelin pull request #2971: [ZEPPELIN-3466] Table export to excel is not wo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2971
---