[jira] [Commented] (AIRFLOW-97) "airflow" "DAG" strings in file necessary to import dag

["Ivan Vergiliev (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965855#comment-15965855 ] 

Ivan Vergiliev commented on AIRFLOW-97:
---------------------------------------

[~maxime.beauchemin@apache.org] just a ping here - curious why the `safe_mode` argument was introduced? I don't see reasoning in the commit message. Is it a performance improvement to avoid parsing some files? It's pretty confusing when trying to use DAG factories (and leads to the hacks already mentioned). Do you think we can at least make it default to `False`?

> "airflow" "DAG" strings in file necessary to import dag
> -------------------------------------------------------
>
>                 Key: AIRFLOW-97
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-97
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: Airflow 1.7.0
>            Reporter: Etiene Dalcol
>            Priority: Minor
>
> Hello airflow team! Thanks for the awesome tool!
> We made a small module to automate our DAG building process and we are using this module on our DAG definition. Our airflow version is 1.7.0.
> However, airflow will not import this file because it doesn't have the words DAG and airflow on it. (The imports etc are done inside our little module). Apparently there's a safe_mode that skips files without these strings.
> (https://github.com/apache/incubator-airflow/blob/1.7.0/airflow/models.py#L197)
> This safe_mode is default to True but is not passed to the process_file function, so it is always True and there's no apparent way to disable it.
> (https://github.com/apache/incubator-airflow/blob/1.7.0/airflow/models.py#L177)
> (https://github.com/apache/incubator-airflow/blob/1.7.0/airflow/models.py#L313)
> Putting this comment on the top of the file makes it work for the moment and brought me a good laugh today 👯 
> #DAG airflow —> DO NOT REMOVE. the world will explode



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)