You are viewing a plain text version of this content. The canonical link for it is here.
Posted to taglibs-dev@jakarta.apache.org by bu...@apache.org on 2008/06/12 23:45:25 UTC
DO NOT REPLY [Bug 45197] New: Need to support the JSTL 1.2
specification
https://issues.apache.org/bugzilla/show_bug.cgi?id=45197
Summary: Need to support the JSTL 1.2 specification
Product: Taglibs
Version: 1.1.0
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Standard Taglib
AssignedTo: taglibs-dev@jakarta.apache.org
ReportedBy: goff1@us.ibm.com
There should be an opensource JSTL 1.2 implementation. Please implement the
changes required for JSTL 1.2 compliance.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 45197] Need to support the JSTL 1.2 specification
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45197
joebohn@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |joebohn@gmail.com
--- Comment #5 from joebohn@gmail.com 2008-11-17 10:10:20 PST ---
I'm interested in a release that includes this enhancement for possible
inclusion in Apache Geronimo
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 45197] Need to support the JSTL 1.2 specification
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45197
--- Comment #7 from Henri Yandell <ba...@apache.org> 2008-12-17 00:34:44 PST ---
Created an attachment (id=23032)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23032)
Fix to previous patch for one file that does not happily apply.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 45197] Need to support the JSTL 1.2 specification
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45197
--- Comment #10 from Henri Yandell <ba...@apache.org> 2008-12-21 11:15:56 PST ---
EvaluationTest (which fails, but I suspect has for a long time) produces the
same results. So that's a successful regression test.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 45197] Need to support the JSTL 1.2 specification
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45197
--- Comment #8 from Henri Yandell <ba...@apache.org> 2008-12-17 00:36:20 PST ---
Branch created - trunk for standard is now 1.2 specific.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 45197] Need to support the JSTL 1.2 specification
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45197
--- Comment #9 from Henri Yandell <ba...@apache.org> 2008-12-18 00:14:51 PST ---
Build updated. Build succeeds. Unit tests pass.
After a bit of build logic adjustments, Cactus tests pass too.
Need to do a sanity check on each change against:
http://jcp.org/aboutJava/communityprocess/maintenance/jsr052/jstl-1_2-mr-changeLog_PFD.html
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 45197] Need to support the JSTL 1.2 specification
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45197
--- Comment #6 from Henri Yandell <ba...@apache.org> 2008-12-16 10:17:30 PST ---
Software grant looks to have been received :)
Need to branch 1.1 and 1.2 from each other somehow, and apply the below. I
already have the 1.2 TCK so can try to start running that (never run a TCK
before... I hear they're "fun").
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 45197] Need to support the JSTL 1.2 specification
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45197
--- Comment #11 from Henri Yandell <ba...@apache.org> 2008-12-21 16:25:53 PST ---
Patch is applied with detailed SVN commit comment:
http://svn.apache.org/viewvc?view=rev&revision=728565
A few followup items still to do:
* Look at the question in SetSupport.java and resolve.
* Look at questions in the length method in ForEachSupport.java
* Look at commented out code in prepre in ForEachSupport.java
* javadoc for new Expression classes
* Ensure equals()/hashCode() is fine in new Expression classes
# Not covered and suggest unit tests are implemented for each if possible:
* Example involving <fmt:parseDate> in section 9.9 was incorrect. A
pattern has been added so the date can be parsed properly.
* Clarified the fact that the output of <c:url> wont work for the url
attribute value of <c:import> for context relative URLs (URLs that start with a
'/'). (section 7.4)
# Create unit test for JSTL change #1
# Create unit test for JSTL change #2
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 45197] Need to support the JSTL 1.2 specification
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45197
--- Comment #4 from Henri Yandell <ba...@apache.org> 2008-06-18 00:27:55 PST ---
Patch pretty much applies to the latest trunk.
src/org/apache/taglibs/standard/tag/common/core/SetSupport.java has some
problems and will have to be done by hand, and PageContextImpl.java moved to
/test/org/apache/taglibs/standard/lang/jstl/test/.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 45197] Need to support the JSTL 1.2 specification
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45197
--- Comment #1 from Robert Goff <go...@us.ibm.com> 2008-06-12 15:06:51 PST ---
Created an attachment (id=22121)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=22121)
The attachment implements the JSTL 1.2 specification changes.
There were also some build.xml changes needed to
- Update the standard-version to 1.2
- Update to use the JSP 2.1 spec
- Update the library-build to include EL-1.0
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 45197] Need to support the JSTL 1.2 specification
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45197
Henri Yandell <ba...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bayard@apache.org
Status|NEW |ASSIGNED
--- Comment #3 from Henri Yandell <ba...@apache.org> 2008-06-18 00:20:07 PST ---
This rocks, thankyou Robert for the patch and Donald for testing it.
Robert - I think a software grant would be needed for a contribution of this
importance:
http://www.apache.org/licenses/software-grant.txt
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 45197] Need to support the JSTL 1.2 specification
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45197
Donald Woods <dw...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dwoods@apache.org
--- Comment #2 from Donald Woods <dw...@apache.org> 2008-06-17 06:11:12 PST ---
I verified the patch against a local copy of 1.1.2 and built it using the
latest IBM 1.5.0 Java SDK on SLED10 and MacOSX. This patch and creating an
Apache version of JSTL 1.2 is important, as the Sun RI JSTL 1.2 jar will only
pass the JavaEE 5 TCK on a Sun JVM, due to hard-coded dependencies on Sun
renamed Xerces/Xalan classes in their JVM (sun.org.apache.*). If we want to
support JSTL 1.2 users on Apache Harmony and other JDKs, then we need to
release an Apache implementation.
-Donald Woods
dwoods@apache.org
Apache Geronimo Committer and PMC Member
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org