[GitHub] [helix] zhangmeng916 commented on a change in pull request #1485: Add offline node purge timeout in cluster config

[GitBox <gi...@apache.org>]

zhangmeng916 commented on a change in pull request #1485:
URL: https://github.com/apache/helix/pull/1485#discussion_r512935173



##########
File path: helix-core/src/test/java/org/apache/helix/model/TestClusterConfig.java
##########
@@ -320,6 +320,29 @@ public void testSetOfflineNodeTimeOutForMaintenanceMode() {
             -1), 10000L);
   }
 
+
+  @Test
+  public void testGetOfflineNodeTimeOutForPurge() {
+    ClusterConfig testConfig = new ClusterConfig("testId");
+    Assert.assertEquals(testConfig.getOfflineNodeTimeOutForPurge(), -1);
+
+    testConfig.getRecord()
+        .setLongField(ClusterConfig.ClusterConfigProperty.OFFLINE_NODE_TIME_OUT_FOR_PURGE
+                .name(),
+            10000L);
+    Assert.assertEquals(testConfig.getOfflineNodeTimeOutForPurge(), 10000L);
+  }
+
+  @Test
+  public void testSetOfflineNodeTimeOutForPurge() {

Review comment:
       Tiny difference in how they set the field. But I agree they're doing the same thing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org