You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2012/12/28 00:10:12 UTC
[jira] [Updated] (DERBY-3275) Mismatch between comments and actual
use of initialSize parameter in CacheFactory and Clock
[ https://issues.apache.org/jira/browse/DERBY-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-3275:
--------------------------------------
Fix Version/s: 10.10.0.0
Assignee: Knut Anders Hatlen
Issue Type: Improvement (was: Bug)
> Mismatch between comments and actual use of initialSize parameter in CacheFactory and Clock
> -------------------------------------------------------------------------------------------
>
> Key: DERBY-3275
> URL: https://issues.apache.org/jira/browse/DERBY-3275
> Project: Derby
> Issue Type: Improvement
> Components: Services
> Affects Versions: 10.4.1.3
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Labels: derby_triage10_5_2
> Fix For: 10.10.0.0
>
> Attachments: javadoc.diff
>
>
> The javadoc for org.apache.derby.iapi.services.cache.CacheFactory.newCacheManager() describes the initialSize parameter like this:
> @param initialSize The number of initial holder objects that will be created
> And org.apache.derby.impl.services.cache.Clock's constructor says the following:
> @param initialSize the initial number of cachable object this cache
> holds.
> @param maximumSize the maximum size of the cache. The cache may grow
> from initialSize to maximumSize if the cache policy notices that there
> is not enough free buffers availiable. Once the cache hits maximumSize
> it will not grow. If the cache is full, an exception will be thrown
> However, when Clock is created, it does not populate the cache with "holder objects" or "cacheable [objects]". It only uses the initialSize to specify the initial capacity of the HashMap and the ArrayList that are created.
> Either the code should be changed so that it's in line with the comments, or the comments should be changed to match the code. I don't see any compelling reason for changing the code, so I think I would prefer changing the comments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira