You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/03/25 09:27:21 UTC
[GitHub] [phoenix] stoty opened a new pull request #1184: PHOENIX-6357 Change all command line tools to use the fixed commons-c…
stoty opened a new pull request #1184:
URL: https://github.com/apache/phoenix/pull/1184
…li constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1184: PHOENIX-6357 Change all command line tools to use the fixed commons-c…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1184:
URL: https://github.com/apache/phoenix/pull/1184#issuecomment-813996980
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 7m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 55s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 13m 4s | master passed |
| +0 | hbaserecompile | 25m 3s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 7s | master passed |
| +1 :green_heart: | checkstyle | 1m 39s | master passed |
| +1 :green_heart: | javadoc | 1m 32s | master passed |
| +0 :ok: | spotbugs | 3m 19s | phoenix-core in master has 956 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 53s | phoenix-pherf in master has 51 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 42s | phoenix-tools in master has 3 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 10m 10s | the patch passed |
| +0 | hbaserecompile | 17m 15s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 7s | the patch passed |
| +1 :green_heart: | javac | 2m 7s | the patch passed |
| -1 :x: | checkstyle | 1m 13s | phoenix-core: The patch generated 25 new + 2539 unchanged - 39 fixed = 2564 total (was 2578) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 1m 32s | the patch passed |
| +1 :green_heart: | spotbugs | 5m 24s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 124m 4s | phoenix-core in the patch failed. |
| -1 :x: | unit | 9m 39s | phoenix-pherf in the patch failed. |
| +1 :green_heart: | unit | 2m 59s | phoenix-tools in the patch passed. |
| +1 :green_heart: | asflicense | 1m 32s | The patch does not generate ASF License warnings. |
| | | 212m 16s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.pherf.PherfMainIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1184 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux c7b11abf5297 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 21599ac |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/3/artifact/yetus-general-check/output/patch-unit-phoenix-pherf.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/3/testReport/ |
| Max. process+thread count | 10064 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf phoenix-tools U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/3/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #1184: PHOENIX-6357 Change all command line tools to use the fixed commons-c…
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #1184:
URL: https://github.com/apache/phoenix/pull/1184#discussion_r628905242
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/AbstractBulkLoadTool.java
##########
@@ -181,40 +181,12 @@ public int run(String[] args) throws Exception {
return loadData(conf, cmdLine);
}
- /**
- * Check schema or table name that start with two double quotes i.e ""t"" -> true
- */
- private boolean isStartWithTwoDoubleQuotes (String name) {
- boolean start = false;
- boolean end = false;
- if (name != null && name.length() > 1) {
- int length = name.length();
- start = name.substring(0,2).equals("\"\"");
- end = name.substring(length-2, length).equals("\"\"");
- if (start && !end) {
- throw new IllegalArgumentException("Invalid table/schema name " + name +
- ". Please check if name end with two double quotes.");
- }
- }
- return start;
- }
-
private int loadData(Configuration conf, CommandLine cmdLine) throws Exception {
String tableName = cmdLine.getOptionValue(TABLE_NAME_OPT.getOpt());
String schemaName = cmdLine.getOptionValue(SCHEMA_NAME_OPT.getOpt());
String indexTableName = cmdLine.getOptionValue(INDEX_TABLE_NAME_OPT.getOpt());
- boolean quotedTableName = isStartWithTwoDoubleQuotes(tableName);
- if (quotedTableName) {
- // Commons-cli cannot parse full quoted argument i.e "t" (CLI-275).
- // if \"\"t\"\" passed, then both pairs of quoted are left intact as ""t"".
- // So remove one pair of quote from tablename ""t"" -> "t".
- tableName = tableName.substring(1, tableName.length() - 1);
- }
- boolean quotedSchemaName = isStartWithTwoDoubleQuotes(schemaName);
- if (quotedSchemaName) {
- schemaName = schemaName.substring(1,schemaName.length() - 1);
- }
+
Review comment:
Yes, this was for the double doublequote hack to workaround CLI-254, which we patch in phoenix-thirdparty now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1184: PHOENIX-6357 Change all command line tools to use the fixed commons-c…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1184:
URL: https://github.com/apache/phoenix/pull/1184#issuecomment-807393087
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 13s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 54s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 12m 49s | master passed |
| +0 | hbaserecompile | 24m 37s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 6s | master passed |
| +1 :green_heart: | checkstyle | 1m 39s | master passed |
| +1 :green_heart: | javadoc | 1m 32s | master passed |
| +0 :ok: | spotbugs | 3m 19s | phoenix-core in master has 956 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 49s | phoenix-pherf in master has 42 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 43s | phoenix-tools in master has 3 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 9m 57s | the patch passed |
| +0 | hbaserecompile | 16m 57s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 6s | the patch passed |
| +1 :green_heart: | javac | 2m 6s | the patch passed |
| -1 :x: | checkstyle | 1m 12s | phoenix-core: The patch generated 25 new + 2540 unchanged - 39 fixed = 2565 total (was 2579) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 1m 28s | the patch passed |
| +1 :green_heart: | spotbugs | 5m 24s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 124m 25s | phoenix-core in the patch failed. |
| -1 :x: | unit | 10m 40s | phoenix-pherf in the patch failed. |
| +1 :green_heart: | unit | 3m 5s | phoenix-tools in the patch passed. |
| +1 :green_heart: | asflicense | 1m 30s | The patch does not generate ASF License warnings. |
| | | 207m 9s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT |
| | phoenix.pherf.PherfMainIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1184 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 21341f6bf058 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / f9532bd |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/2/artifact/yetus-general-check/output/patch-unit-phoenix-pherf.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/2/testReport/ |
| Max. process+thread count | 10758 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf phoenix-tools U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/2/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1184: PHOENIX-6357 Change all command line tools to use the fixed commons-c…
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1184:
URL: https://github.com/apache/phoenix/pull/1184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1184: PHOENIX-6357 Change all command line tools to use the fixed commons-c…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1184:
URL: https://github.com/apache/phoenix/pull/1184#issuecomment-834530001
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 10s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 55s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 13m 29s | master passed |
| +0 | hbaserecompile | 26m 18s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 25s | master passed |
| +1 :green_heart: | checkstyle | 1m 56s | master passed |
| +1 :green_heart: | javadoc | 2m 3s | master passed |
| +0 :ok: | spotbugs | 3m 44s | phoenix-core in master has 959 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 1m 2s | phoenix-pherf in master has 51 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 51s | phoenix-tools in master has 3 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 10m 19s | the patch passed |
| +0 | hbaserecompile | 17m 51s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 22s | the patch passed |
| +1 :green_heart: | javac | 2m 22s | the patch passed |
| -1 :x: | checkstyle | 1m 13s | phoenix-core: The patch generated 25 new + 2540 unchanged - 39 fixed = 2565 total (was 2579) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 1m 37s | the patch passed |
| +1 :green_heart: | spotbugs | 6m 24s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 127m 47s | phoenix-core in the patch failed. |
| -1 :x: | unit | 8m 53s | phoenix-pherf in the patch failed. |
| +1 :green_heart: | unit | 3m 27s | phoenix-tools in the patch passed. |
| +1 :green_heart: | asflicense | 1m 27s | The patch does not generate ASF License warnings. |
| | | 214m 58s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.ConcurrentUpsertsWithoutIndexedColsIT |
| | phoenix.end2end.UpsertSelectIT |
| | phoenix.pherf.workload.mt.tenantoperation.TenantViewOperationWorkloadIT |
| | phoenix.pherf.PherfMainIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1184 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 557331b84312 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 5265164 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/4/artifact/yetus-general-check/output/patch-unit-phoenix-pherf.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/4/testReport/ |
| Max. process+thread count | 8864 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf phoenix-tools U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/4/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1184: PHOENIX-6357 Change all command line tools to use the fixed commons-c…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1184:
URL: https://github.com/apache/phoenix/pull/1184#issuecomment-806667477
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 4m 50s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 12m 40s | master passed |
| +0 | hbaserecompile | 24m 32s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 6s | master passed |
| +1 :green_heart: | checkstyle | 1m 41s | master passed |
| +1 :green_heart: | javadoc | 1m 30s | master passed |
| +0 :ok: | spotbugs | 3m 16s | phoenix-core in master has 956 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 49s | phoenix-pherf in master has 42 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 44s | phoenix-tools in master has 3 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 9m 52s | the patch passed |
| +0 | hbaserecompile | 16m 52s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 5s | the patch passed |
| +1 :green_heart: | javac | 2m 5s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 13s | phoenix-core: The patch generated 0 new + 2577 unchanged - 1 fixed = 2577 total (was 2578) |
| +1 :green_heart: | checkstyle | 0m 16s | The patch passed checkstyle in phoenix-pherf |
| +1 :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in phoenix-tools |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 1m 29s | the patch passed |
| +1 :green_heart: | spotbugs | 5m 27s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 112m 31s | phoenix-core in the patch failed. |
| -1 :x: | unit | 8m 37s | phoenix-pherf in the patch failed. |
| +1 :green_heart: | unit | 3m 4s | phoenix-tools in the patch passed. |
| +1 :green_heart: | asflicense | 1m 28s | The patch does not generate ASF License warnings. |
| | | 192m 50s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.CsvBulkLoadToolIT |
| | phoenix.pherf.PherfMainIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1184 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux a7fb216012c6 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / f9532bd |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/1/artifact/yetus-general-check/output/patch-unit-phoenix-pherf.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/1/testReport/ |
| Max. process+thread count | 11676 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf phoenix-tools U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1184/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1184: PHOENIX-6357 Change all command line tools to use the fixed commons-c…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1184:
URL: https://github.com/apache/phoenix/pull/1184#discussion_r628898021
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/AbstractBulkLoadTool.java
##########
@@ -181,40 +181,12 @@ public int run(String[] args) throws Exception {
return loadData(conf, cmdLine);
}
- /**
- * Check schema or table name that start with two double quotes i.e ""t"" -> true
- */
- private boolean isStartWithTwoDoubleQuotes (String name) {
- boolean start = false;
- boolean end = false;
- if (name != null && name.length() > 1) {
- int length = name.length();
- start = name.substring(0,2).equals("\"\"");
- end = name.substring(length-2, length).equals("\"\"");
- if (start && !end) {
- throw new IllegalArgumentException("Invalid table/schema name " + name +
- ". Please check if name end with two double quotes.");
- }
- }
- return start;
- }
-
private int loadData(Configuration conf, CommandLine cmdLine) throws Exception {
String tableName = cmdLine.getOptionValue(TABLE_NAME_OPT.getOpt());
String schemaName = cmdLine.getOptionValue(SCHEMA_NAME_OPT.getOpt());
String indexTableName = cmdLine.getOptionValue(INDEX_TABLE_NAME_OPT.getOpt());
- boolean quotedTableName = isStartWithTwoDoubleQuotes(tableName);
- if (quotedTableName) {
- // Commons-cli cannot parse full quoted argument i.e "t" (CLI-275).
- // if \"\"t\"\" passed, then both pairs of quoted are left intact as ""t"".
- // So remove one pair of quote from tablename ""t"" -> "t".
- tableName = tableName.substring(1, tableName.length() - 1);
- }
- boolean quotedSchemaName = isStartWithTwoDoubleQuotes(schemaName);
- if (quotedSchemaName) {
- schemaName = schemaName.substring(1,schemaName.length() - 1);
- }
+
Review comment:
This change is not required because cli's parsing issue with double quote is no longer an issue. Is it correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org