You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stevedlawrence (via GitHub)" <gi...@apache.org> on 2023/06/07 16:27:01 UTC
[GitHub] [daffodil] stevedlawrence opened a new pull request, #1026: Support text numbers that parse to negative zero double
stevedlawrence opened a new pull request, #1026:
URL: https://github.com/apache/daffodil/pull/1026
ICU parses negative zero to a Double type, which we do not currently allow, expecting only Infinifity or NaN. This modifies the assertion to allow negative zero as well.
DAFFODIL-2818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji commented on a diff in pull request #1026: Support text numbers that parse to negative zero double
Posted by "tuxji (via GitHub)" <gi...@apache.org>.
tuxji commented on code in PR #1026:
URL: https://github.com/apache/daffodil/pull/1026#discussion_r1221917840
##########
daffodil-test/src/test/resources/org/apache/daffodil/section05/simple_types/SimpleTypes.tdml:
##########
@@ -3683,6 +3683,18 @@
</tdml:errors>
</tdml:unparserTestCase>
+ <tdml:parserTestCase name="double_negativeZero" root="doubleText"
+ model="SimpleTypes-Embedded.dfdl.xsd" description="Section 5 Schema types-double - DFDL-5-009R"
Review Comment:
(Aside) I am interested in ways to test Daffodil's C code generator more thoroughly. However, the majority of Daffodil's tests (like this one) parse textual data, not binary data. Even when I find binary data tests, they might also use hidden groups, input and/or output value calculations, variables, or other unsupported features. Is there an easy way to identify existing Daffodil tests which could be run with "daffodil test -I daffodilC" successfully (besides just trying it on all tests and seeing which ones pass)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle commented on a diff in pull request #1026: Support text numbers that parse to negative zero double
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on code in PR #1026:
URL: https://github.com/apache/daffodil/pull/1026#discussion_r1221955122
##########
daffodil-test/src/test/resources/org/apache/daffodil/section05/simple_types/SimpleTypes.tdml:
##########
@@ -3683,6 +3683,18 @@
</tdml:errors>
</tdml:unparserTestCase>
+ <tdml:parserTestCase name="double_negativeZero" root="doubleText"
+ model="SimpleTypes-Embedded.dfdl.xsd" description="Section 5 Schema types-double - DFDL-5-009R"
Review Comment:
I suggest trying all tests and see what ones pass :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence merged pull request #1026: Support text numbers that parse to negative zero double
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence merged PR #1026:
URL: https://github.com/apache/daffodil/pull/1026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org