You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Ashish Singh <as...@cloudera.com> on 2016/08/24 01:28:43 UTC
Review Request 51357: SENTRY-1450: Have privilege converter set by
Kafka binding
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51357/
-----------------------------------------------------------
Review request for sentry, Dapeng Sun, Hao Hao, and Sravya Tirukkovalur.
Bugs: SENTRY-1450
https://issues.apache.org/jira/browse/SENTRY-1450
Repository: sentry
Description
-------
Have privilege converter set by Kafka binding. This will avoid users from having to specify one extra config, which as of now can only take one value for Kafka plugin, when enabling caching.
Diffs
-----
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java 53e7a3c641698ee86cee1fa6f48e1ac4d396f412
sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java 10d6af73ddcab8c886377c80f0b3c604505c101a
Diff: https://reviews.apache.org/r/51357/diff/
Testing
-------
Tested with e2e tests.
Thanks,
Ashish Singh
Re: Review Request 51357: SENTRY-1450: Have privilege converter set
by Kafka binding
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51357/#review146604
-----------------------------------------------------------
Ship it!
Ship It!
- Dapeng Sun
On \u516b\u6708 24, 2016, 9:28 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51357/
> -----------------------------------------------------------
>
> (Updated \u516b\u6708 24, 2016, 9:28 a.m.)
>
>
> Review request for sentry, Dapeng Sun, Hao Hao, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-1450
> https://issues.apache.org/jira/browse/SENTRY-1450
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Have privilege converter set by Kafka binding. This will avoid users from having to specify one extra config, which as of now can only take one value for Kafka plugin, when enabling caching.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java 53e7a3c641698ee86cee1fa6f48e1ac4d396f412
> sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java 10d6af73ddcab8c886377c80f0b3c604505c101a
>
> Diff: https://reviews.apache.org/r/51357/diff/
>
>
> Testing
> -------
>
> Tested with e2e tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 51357: SENTRY-1450: Have privilege converter set
by Kafka binding
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51357/#review146602
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On Aug. 24, 2016, 1:28 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51357/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2016, 1:28 a.m.)
>
>
> Review request for sentry, Dapeng Sun, Hao Hao, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-1450
> https://issues.apache.org/jira/browse/SENTRY-1450
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Have privilege converter set by Kafka binding. This will avoid users from having to specify one extra config, which as of now can only take one value for Kafka plugin, when enabling caching.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java 53e7a3c641698ee86cee1fa6f48e1ac4d396f412
> sentry-tests/sentry-tests-kafka/src/test/java/org/apache/sentry/tests/e2e/kafka/AbstractKafkaSentryTestBase.java 10d6af73ddcab8c886377c80f0b3c604505c101a
>
> Diff: https://reviews.apache.org/r/51357/diff/
>
>
> Testing
> -------
>
> Tested with e2e tests.
>
>
> Thanks,
>
> Ashish Singh
>
>