[GitHub] [kafka] cadonna commented on a change in pull request #10765: KAFKA-12519: Remove built-in Streams metrics for versions 0.10.0-2.4

[GitBox <gi...@apache.org>]

cadonna commented on a change in pull request #10765:
URL: https://github.com/apache/kafka/pull/10765#discussion_r639602759



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##########
@@ -52,8 +51,7 @@
 public class StreamsMetricsImpl implements StreamsMetrics {
 
     public enum Version {
-        LATEST,
-        FROM_0100_TO_24
+        LATEST

Review comment:
       Since we decided to keep the config `built.in.metrics.version` I think it is OK to keep also this enum.

##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##########
@@ -175,11 +171,7 @@ public StreamsMetricsImpl(final Metrics metrics,
     }
 
     private static Version parseBuiltInMetricsVersion(final String builtInMetricsVersion) {

Review comment:
       Removed it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org