You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jens Geyer <je...@hotmail.com> on 2010/10/17 19:13:20 UTC
Minor inconsistency in TFileTransport.cpp
Right now I stumbled across some small inconsistency in TFileTransport.cpp.
The declaration is as follows (note the comment):
writerThreadIOErrorSleepTime_ : uint32_t; // sleep duration in seconds
when an IO error is encountered in the writer thread
it's initialized here:
writerThreadIOErrorSleepTime_ := DEFAULT_WRITER_THREAD_SLEEP_TIME_US;
but at the usage, we can read this:
T_ERROR('TFileTransport: writer thread going to sleep for %d
microseconds due to IO errors', [writerThreadIOErrorSleepTime_]);
Since DEFAULT_WRITER_THREAD_SLEEP_TIME_US is defined as uint32_t( 60 * 1000
* 1000) and usleep() also takes microseconds AFAIK, I would guess that the
declaration comment should just read "microseconds" instead of "seconds"?
Regards,
Jens Geyer