You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by serDrem <gi...@git.apache.org> on 2017/06/20 21:15:09 UTC
[GitHub] incubator-trafficcontrol pull request #695: TrafficMonitor IPV6 improvements
GitHub user serDrem opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/695
TrafficMonitor IPV6 improvements
Enables TM to poll health information over IPV6, and optionally combine it with IPV4 information for traffic router.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/serDrem/incubator-trafficcontrol tm_ipv6_2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/695.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #695
----
commit 6e435a9ff05c859d735caddf0d5dc2bb71cab90b
Author: serDrem <se...@comcast.com>
Date: 2017-05-30T15:30:28Z
improved ipv6 handling
commit e9808a4ec4c11f53ba1e0af91cbe9e46375d3816
Author: serDrem <se...@comcast.com>
Date: 2017-06-20T20:14:33Z
new ipv6 for tm
commit 93afe94d499ff2f9aebb6515dd4b4a7a8faeb522
Author: serDrem <se...@comcast.com>
Date: 2017-06-20T20:21:31Z
remove nagios.go
commit e5808a7223600d7aa6ee383a22040f7ee5f9d0d9
Author: serDrem <se...@comcast.com>
Date: 2017-06-20T20:31:13Z
removed weird files
commit 049bf6923564f27b37e42a1699a91f8931c5a979
Author: serDrem <se...@gmail.com>
Date: 2017-06-20T21:12:58Z
Delete centos@tm.cdn.sys.comcast.net
commit 4a4869b6c0f68152f9a983482f085a967f845777
Author: serDrem <se...@gmail.com>
Date: 2017-06-20T21:13:19Z
Delete traffic_monitor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #695: TrafficMonitor IPV6 improvements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/695
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #695: TrafficMonitor IPV6 improvements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/695
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/18/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #695: TrafficMonitor IPV6 improvements
Posted by dneuman64 <gi...@git.apache.org>.
Github user dneuman64 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/695
+1 to @alficles comments. @serDrem can you please make this two PRs? One for astats and one for TM?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #695: TrafficMonitor IPV6 improvements
Posted by dneuman64 <gi...@git.apache.org>.
Github user dneuman64 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/695
This should also be linked to this issue: https://issues.apache.org/jira/browse/TC-230
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #695: TrafficMonitor IPV6 improvements
Posted by alficles <gi...@git.apache.org>.
Github user alficles commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/695
This is pretty cool. It looks like there are two separate PRs in here, and the second one could really use a squash. The astats changes can stand on their own, so they should probably get their own PR. And the IPv6 for TM should be squashed. There are some confusing reverts of inadvertent changes that probably shouldn't go in, even as intermediate changesets.
It'll be a lot easier to review it that way, I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #695: TrafficMonitor IPV6 improvements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/695
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---