You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/30 17:46:08 UTC

[GitHub] [kafka] guozhangwang opened a new pull request #8593: MINOR: Improve Sensor recording efficiency

guozhangwang opened a new pull request #8593:
URL: https://github.com/apache/kafka/pull/8593


   1. Added a `recordInternal` function to let all other public functions trigger, so that `shouldRecord` would only be checked once.
   
   2. In Streams, pass along the current wall-clock time inside InternalProcessorContext when process / punctuate which can be passed in to the `record` function to reduce the calling frequency of `SystemTime.milliseconds()`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #8593: MINOR: Improve Sensor recording efficiency

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8593:
URL: https://github.com/apache/kafka/pull/8593#issuecomment-622003689


   @vvcephei @cadonna for reviews.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on a change in pull request #8593: MINOR: Improve Sensor recording efficiency

Posted by GitBox <gi...@apache.org>.
vvcephei commented on a change in pull request #8593:
URL: https://github.com/apache/kafka/pull/8593#discussion_r418735906



##########
File path: streams/src/test/java/org/apache/kafka/test/MockSourceNode.java
##########
@@ -48,7 +48,7 @@ public void process(final K key, final V value) {
     }
 
     @Override
-    public void init(final InternalProcessorContext context) {
+    public void init(final InternalProcessorContext<Object, Object> context) {

Review comment:
       Note, these parameters (and elsewhere) will be gone when you rebase.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org