[jira] [Commented] (NUTCH-2850) Method ignores exceptional return value

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286234#comment-17286234 ] 

ASF GitHub Bot commented on NUTCH-2850:
---------------------------------------

lewismc opened a new pull request #570:
URL: https://github.com/apache/nutch/pull/570


   PR to address https://issues.apache.org/jira/browse/NUTCH-2850
   I've confirmed that Spotbugs no longer flags this issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Method ignores exceptional return value
> ---------------------------------------
>
>                 Key: NUTCH-2850
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2850
>             Project: Nutch
>          Issue Type: Sub-task
>          Components: dumpers
>    Affects Versions: 1.18
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Major
>             Fix For: 1.19
>
>
> In class org.apache.nutch.tools.FileDumper
> In method org.apache.nutch.tools.FileDumper.dump(File, File, String[], boolean, boolean, boolean)
> Called method java.io.File.mkdirs()
> At FileDumper.java:[line 237]
> Exceptional return value of java.io.File.mkdirs() ignored in org.apache.nutch.tools.FileDumper.dump(File, File, String[], boolean, boolean, boolean)
> This method returns a value that is not checked. The return value should be checked since it can indicate an unusual or unexpected function execution. For example, the File.delete() method returns false if the file could not be successfully deleted (rather than throwing an Exception). If you don't check the result, you won't notice if the method invocation signals unexpected behavior by returning an atypical return value. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)